Reviews for wip-haskell-platform-7.10.2-a

Reviews for wip-haskell-platform-7.10.2-a

[ericbavier]

I apologize in advance that so many of these comments pertain to the synopses
and descriptions, but I find that aspect of packaging important, and Ludo was
kind enough to write up the "Synopses and Descriptions" section in guix.info.

Along the way I gave up trying to analyse and comment on inputs vs
propagated-inputs.  The builds check out, and we can adjust later if needed.

In the absense of comments on a patch, assume a "LGTM!" :)

Thank you, Paul for all the effort,

`~Eric

Re: [PATCH] gnu: Add ghc-attoparsec.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-attoparsec): New variable.
> ---
>  gnu/packages/haskell.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 35cfed6..91fe2b4 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1160,6 +1160,37 @@ Both IPv4 and IPv6 are supported.")
>  by Roman Cheplyaka).")
>      (license bsd-3)))
>  
> +(define-public ghc-attoparsec
> +  (package
> +    (name "ghc-attoparsec")
> +    (version "0.13.0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/attoparsec/attoparsec-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0cprkr7bl4lrr80pz8mryb4rbfwdgpsrl7g0fbcaybhl8p5hm26f"))))
> +    (build-system haskell-build-system)
> +    (arguments `(#:tests? #f)) ; FIXME: ghc-test-framework unavailable
> +    (propagated-inputs
> +     `(("ghc-scientific" ,ghc-scientific)))
> +    (inputs
> +     `(
> +       ("ghc-text" ,ghc-text)

Move this onto the previous line.

`~Eric

> +       ("ghc-quickcheck" ,ghc-quickcheck)
> +       ("ghc-quickcheck-unicode" ,ghc-quickcheck-unicode)
> +       ("ghc-vector" ,ghc-vector)))
> +    (home-page "https://github.com/bos/attoparsec")
> +    (synopsis "Fast combinator parsing for bytestrings and text")
> +    (description "This library provides a fast parser combinator library,
> +aimed particularly at dealing efficiently with network protocols and
> +complicated text/binary file formats.")
> +    (license bsd-3)))
> +
>  (define-public ghc-appar
>    (package
>      (name "ghc-appar")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-base64-bytestring.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-base64-bytestring): New variable.
> ---
>  gnu/packages/haskell.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index a61ad05..4246b64 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1381,6 +1381,31 @@ optimized for performance critical use, both in terms of large data quantities
>  and high speed.")
>      (license bsd-3)))
>  
> +(define-public ghc-base64-bytestring
> +  (package
> +    (name "ghc-base64-bytestring")
> +    (version "1.0.0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/base64-bytestring/base64-bytestring-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0l1v4ddjdsgi9nqzyzcxxj76rwar3lzx8gmwf2r54bqan3san9db"))))
> +    (build-system haskell-build-system)
> +    (arguments `(#:tests? #f))         ; FIXME: testing libraries are missing.
> +    (inputs
> +     `(("ghc-quickcheck" ,ghc-quickcheck)
> +       ("ghc-hunit" ,ghc-hunit)))

These inputs could probably be left out if #:tests? #f.

> +    (home-page "https://github.com/bos/base64-bytestring")
> +    (synopsis "Fast base64 encoding and decoding for ByteStrings")

Perhaps leave out the "Fast" part.

`~Eric

Re: [PATCH] gnu: Add ghc-blaze-builder.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-blaze-builder): New variable.
> ---
>  gnu/packages/haskell.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 1b37942..219a63c 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -2000,6 +2000,38 @@ of base to a wider range of compilers, without requiring the use of CPP
>  pragmas in your code.")
>      (license bsd-3)))
>  
> +(define-public ghc-blaze-builder
> +  (package
[...]
> +    (arguments `(#:tests? #f))          ; FIXME: Missing test libraries.
> +    (inputs
> +     `(("ghc-text" ,ghc-text)
> +       ("ghc-hunit" ,ghc-hunit)
> +       ("ghc-quickcheck" ,ghc-quickcheck)
> +       ("ghc-utf8-string" ,ghc-utf8-string)))

The ghc-hunit and ghc-quickcheck inputs can be removed because #:tests? #f.
The ghc-text and ghc-utf8-string inputs should probably be propagated.

`~Eric

Re: [PATCH] gnu: Add ghc-blaze-markup.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-blaze-markup): New variable.
> ---
>  gnu/packages/haskell.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 219a63c..d507360 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -2032,6 +2032,36 @@ code that uses the old interface can interoperate with code that uses the new
>  implementation.")
>      (license bsd-3)))
>  
> +(define-public ghc-blaze-markup
> +  (package
[...]
> +    (arguments `(#:tests? #f)) ; FIXME: testing libraries are missing.
> +    (inputs
> +     `(("ghc-blaze-builder" ,ghc-blaze-builder)
> +       ("ghc-text" ,ghc-text)
> +       ("ghc-hunit" ,ghc-hunit)
> +       ("ghc-quickcheck" ,ghc-quickcheck)))

ghc-blaze-builder and ghc-text should be propagated, and the others may be
removed because #:tests? #f.

> +    (home-page "http://jaspervdj.be/blaze")
> +    (synopsis
> +     "Blazingly fast markup combinator library for Haskell")

Maybe just: Fast markup combinator library for Haskell

> +    (description
> +     "Core modules of a blazingly fast markup combinator library for the
> +Haskell programming language.  The Text.Blaze module is a good starting point,
> +as well as @uref{http://jaspervdj.be/blaze/tutorial.html, the tutorial}.")
> +    (license bsd-3)))

How about:

This library contains core modules for a markup combinator library for the
Haskell programming language.


Similar comments for the ghc-blaze-html patch.

`~Eric

Re: [PATCH] gnu: Add ghc-bytestring-builder.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-bytestring-builder): New variable.
> ---
>  gnu/packages/haskell.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 620a842..9b23f38 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -2445,6 +2445,32 @@ or timeout period.  This package provides alternative functions which use the
>  unbounded @code{Integer} type.")
>      (license bsd-3)))
>  
> +(define-public ghc-bytestring-builder
> +  (package
[...]
> +    (arguments `(#:haddock? #f)) ; FIXME: testing framework unavailable

Did you mean '#:tests? #f'? or is the comment incorrect?

`~Eric

Re: [PATCH] gnu: Add ghc-cereal.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-cereal): New variable.
> ---
>  gnu/packages/haskell.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 35952ed..9e97757 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1248,6 +1248,30 @@ Haskell.")
>  modifying, and extracting files from zip archives.")
>      (license bsd-3)))
>  
> +(define-public ghc-cereal
> +  (package
> +    (name "ghc-cereal")
> +    (version "0.4.1.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/cereal/cereal-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "15rhfn9hrjm01ksh9xpz9syxsp9vkvpp6b736iqq38wv2wb7416z"))))
> +    (build-system haskell-build-system)
> +    (home-page
> +     "http://hackage.haskell.org/package/cereal")
> +    (synopsis "Binary serialization library")
> +    (description
> +     "This package provides a binary serialization library, similar to binary,

It may not be apparent that the "binary" being referred to here is a haskell
library.  It should maybe be written as "similar to the @code{binary} library,
...".

`~Eric

> +that introduces an isolate primitive for parser isolation, and labeled blocks
> +for better error messages.")
> +    (license bsd-3)))
> +
>  (define-public ghc-appar
>    (package
>      (name "ghc-appar")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-clock.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-clock): New variable.
> ---
>  gnu/packages/haskell.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 6aa3a91..be37c5a 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -2445,6 +2445,28 @@ or timeout period.  This package provides alternative functions which use the
>  unbounded @code{Integer} type.")
>      (license bsd-3)))
>  
> +(define-public ghc-clock
> +  (package
> +    (name "ghc-clock")
> +    (version "0.5.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/"
> +             "clock/"
> +             "clock-" version ".tar.gz"))
> +       (sha256
> +        (base32 "1ncph7vi2q6ywwc8ysxl1ibw6i5dwfvln88ssfazk8jgpj4iyykw"))))
> +    (build-system haskell-build-system)
> +    (arguments `(#:tests? #f)) ;; Testing suite depends on ghc-clock

A trick that's used with some other packages is to define an unexported
*-bootstrap package.  The ghc-clock-bootstrap package would have tests
disabled, then the ghc-clock package would inherit from the
ghc-clock-bootstrap package, declare ghc-clock-bootstrap as an input, and
enable tests.

`~Eric

Re: [PATCH] gnu: Add ghc-cpphs.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-cpphs): New variable.
> ---
>  gnu/packages/haskell.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index aa038e4..cd2456d 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -413,6 +413,37 @@ are no options for manipulating the reflected expressions beyond showing
>  them.")
>      (license bsd-3)))
>  
> +(define-public ghc-cpphs
> +  (package
> +    (name "ghc-cpphs")

We should probably name this package "cpphs".

> +    (version "1.19.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/cpphs/cpphs-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1njpmxgpah5pcqppcl1cxb5xicf6xlqrd162qm12khp9hainlm72"))))
> +    (build-system haskell-build-system)
> +    (propagated-inputs
> +     `(("ghc-polyparse" ,ghc-polyparse)
> +       ("ghc-old-locale" ,ghc-old-locale)
> +       ("ghc-old-time" ,ghc-old-time)))
> +    (home-page "http://projects.haskell.org/cpphs/")
> +    (synopsis
> +     "Liberalised re-implementation of cpp, the C pre-processor")
> +    (description
> +     "Cpphs is a re-implementation of the C pre-processor that is both more
> +compatible with Haskell, and itself written in Haskell so that it can be
> +distributed with compilers.  This version of the C pre-processor is
> +pretty-much feature-complete and compatible with traditional (K&R)
> +pre-processors.  Additional features include: a plain-text mode; an option to
> +unlit literate code files; and an option to turn off macro-expansion.")
> +    (license lgpl2.1)))

It looks to me as if the library portions are under the lgpl2.1+ (the '+'
because they specify no version), and the executable 'cpphs' is under the
gpl3+ (again, because no version is specified in the source), so both licenses
should be listed.

`~Eric

> +
>  (define-public ghc-reflection
>    (package
>      (name "ghc-reflection")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-doctest.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-doctest): New variable.
> ---
>  gnu/packages/haskell.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index cfe2ebe..855a21b 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -2215,4 +2215,39 @@ command line options in Haskell.")
>  available in later versions of base to a wider (older) range of compilers.")
>      (license bsd-3)))
>  
> +(define-public ghc-doctest
> +  (package
> +    (name "ghc-doctest")
> +    (version "0.10.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/doctest/doctest-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1jbyhzbi2hfrfg7vbkpj6vriaap8cn99nnmzwcfscwaijz09jyrm"))))
> +    (build-system haskell-build-system)
> +    (arguments `(#:tests? #f))          ; FIXME: missing test framework
> +    (propagated-inputs
> +     `(("ghc-syb" ,ghc-syb)
> +       ("ghc-paths" ,ghc-paths)))
> +    (inputs
> +     `(("ghc-base-compat" ,ghc-base-compat)
> +       ("ghc-hunit" ,ghc-hunit)
> +       ("ghc-hspec" ,ghc-hspec)
> +       ("ghc-quickcheck" ,ghc-quickcheck)
> +       ("ghc-stringbuilder" ,ghc-stringbuilder)
> +       ("ghc-silently" ,ghc-silently)
> +       ("ghc-setenv" ,ghc-setenv)))

Testing for and with doctest is tricky.  I'm not sure your comment about
missing test frameworks is accurate; it looks, from what I can tell, like all
the necessary inputs are present.

I believe the issue is that tests that call the 'doctest' function may not
(probably do not) include the "-package-db" argument in the parameter list
given, but since haskell-build-system relies on the fact that cabal passes
that argument to GHC, it is essential that that information get there somehow.
I would say it's a deficiency of most package's build systems that they do not
take this situation into account.

So, either the tests files can be patched to include "-package-db" in the GHC
arguments given to the 'doctest' function, or GHC_PACKAGE_PATH can be defined
appropriately before the 'check' phase (at that point in the build cabal will
not complain, as it would if GHC_PACKAGE_PATH were defined during the
'configure' phase).

It looks to me like tests are disabled for all packages that use doctest in
this patch series:

ghc-trifecta
ghc-lens
ghc-wai-logger
ghc-parsers
ghc-semigroupoids
ghc-comonad
ghc-distributive
ghc-http-types
ghc-unix-time
ghc-iproute

I would suggest that tests for these packages simply be disabled (and the
corresponding test-only inputs be removed) for the time being.  The pending
GHC native-search-path patches should trivially resolve this issue, at which
time tests for these packages can be revisited.

WDYT?

`~Eric

Re: [PATCH] gnu: Add ghc-fingertree.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-fingertree): New variable.
> ---
>  gnu/packages/haskell.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 50da7ff..05751b1 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1870,4 +1870,32 @@ over threads in Haskell, in which @code{Async a} is a concurrent thread that
>  will eventually deliver a value of type @code{a}.")
>      (license bsd-3)))
>  
> +(define-public ghc-fingertree
> +  (package
> +    (name "ghc-fingertree")
> +    (version "0.1.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/fingertree/fingertree-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1w6x3kp3by5yjmam6wlrf9vap5l5rrqaip0djbrdp0fpf2imn30n"))))
> +    (build-system haskell-build-system)
> +    (arguments `(#:tests? #f)) ; FIXME: testing libraries are missing.
> +    (inputs
> +     `(("ghc-hunit" ,ghc-hunit)
> +       ("ghc-quickcheck" ,ghc-quickcheck)))

Test-only inputs could be left out completely here.

> +    (home-page "http://hackage.haskell.org/package/fingertree")
> +    (synopsis "Generic finger-tree structure, with example instances")

The mention of examples here is probably superfluous.

`~Eric

Re: [PATCH] gnu: Add ghc-free.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-free): New variable.
> ---
>  gnu/packages/haskell.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 729deb3..d280172 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -3262,6 +3262,43 @@ where every element did not have to have an inverse, thus the name
>  semigroup.")
>      (license bsd-3)))
>  
> +(define-public ghc-free
> +  (package
> +    (name "ghc-free")
> +    (version "4.12.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/free/free-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0sr8phvrb4ny8j1wzq55rdn8q4br23q4pw2j276npr844825jr9p"))))
> +    (build-system haskell-build-system)
> +    (propagated-inputs
> +     `(("ghc-prelude-extras" ,ghc-prelude-extras)
> +       ("ghc-profunctors" ,ghc-profunctors)
> +       ("ghc-exceptions" ,ghc-exceptions)))
> +    (inputs
> +     `(("ghc-bifunctors" ,ghc-bifunctors)
> +       ("ghc-comonad" ,ghc-comonad)
> +       ("ghc-distributive" ,ghc-distributive)
> +       ("ghc-mtl" ,ghc-mtl)
> +       ("ghc-semigroupoids" ,ghc-semigroupoids)
> +       ("ghc-semigroups" ,ghc-semigroups)))
> +    (home-page "http://github.com/ekmett/free/")
> +    (synopsis "Monads for free")

How about: "Unrestricted monads for Haskell"

`~Eric

> +    (description "This library provides free monads, which are useful for many
> +tree-like structures and domain specific languages.  If @code{f} is a
> +@code{Functor} then the free @code{Monad} on @code{f} is the type of trees
> +whose nodes are labeled with the constructors of @code{f}.  The word \"free\"
> +is used in the sense of \"unrestricted\" rather than \"zero-cost\": @code{Free
> +f} makes no constraining assumptions beyond those given by @code{f} and the
> +definition of @code{Monad}.")
> +    (license bsd-3)))
> +
>  (define-public ghc-fast-logger
>    (package
>      (name "ghc-fast-logger")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-gluraw.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-gluraw): New variable.
> ---
>  gnu/packages/haskell.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index af863ef..468a345 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -890,6 +890,33 @@ needed for building this package.  If an API entry is not found at runtime, a
>  userError is thrown.")
>      (license bsd-3)))
>  
> +(define-public ghc-gluraw
> +  (package
> +    (name "ghc-gluraw")
> +    (version "1.5.0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/GLURaw/GLURaw-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0gscd9lhp9mb10q8s716nx26m8qng9xbb4h6b3f48zzgkc1sy96x"))))
> +    (build-system haskell-build-system)
> +    (propagated-inputs
> +     `(("ghc-openglraw" ,ghc-openglraw)))
> +    (home-page
> +     "http://www.haskell.org/haskellwiki/Opengl")
> +    (synopsis
> +     "Raw bindings for the OpenGL graphics system")

How about: "Raw Haskell bindings for GLU"

`~Eric

> +    (description
> +     "GLURaw is a raw Haskell binding for the GLU 1.3 OpenGL utility library.
> +It is basically a 1:1 mapping of GLU's C API, intended as a basis for a nicer
> +interface.")
> +    (license bsd-3)))
> +
>  (define-public ghc-streaming-commons
>    (package
>      (name "ghc-streaming-commons")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-haddock-api.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-haddock-api): New variable.
> ---
>  gnu/packages/haskell.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 4dacc92..be14e82 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -417,6 +417,31 @@ project if you can't release often.  For interacting with Haddock itself, see
>  the ‘haddock’ package.")
>      (license bsd-3)))
>  
> +(define-public ghc-haddock-api
> +  (package
> +    (name "ghc-haddock-api")
> +    (version "2.16.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/haddock-api/haddock-api-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1spd5axg1pdjv4dkdb5gcwjsc8gg37qi4mr2k2db6ayywdkis1p2"))))
> +    (build-system haskell-build-system)
> +    (propagated-inputs
> +     `(("ghc-paths" ,ghc-paths)
> +       ("ghc-haddock-library" ,ghc-haddock-library)))
> +    (home-page "http://www.haskell.org/haddock/")
> +    (synopsis
> +     "Documentation-generation tool for Haskell libraries")
> +    (description
> +     "Haddock is a documentation-generation tool for Haskell libraries.")

Could you adjust the synopsis and description to differentiate this package
from ghc-haddock?

Thanks,
`~Eric

> +    (license bsd-3)))
> +
>  (define-public ghc-simple-reflect
>    (package
>      (name "ghc-simple-reflect")

Re: [PATCH] gnu: Add ghc-haskell-src-exts.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-haskell-src-exts): New variable.
> ---
>  gnu/packages/haskell.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index d374b8d..d56c9e2 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -461,6 +461,43 @@ specification in BNF, Happy generates Haskell code to parse the grammar.
>  Happy works in a similar way to the yacc tool for C.")
>      (license bsd-3)))
>  
> +(define-public ghc-haskell-src-exts
> +  (package
[...]
> +     "Manipulating Haskell source: abstract syntax, lexer, parser, and
> +pretty-printer")

How about: "Manipulate Haskell source"

`~Eric

> +    (description
> +     "Haskell-Source with Extensions (HSE, haskell-src-exts) is an extension
> +of the standard haskell-src package, and handles most registered syntactic
> +extensions to Haskell.  All extensions implemented in GHC are supported.
> +Apart from these standard extensions, it also handles regular patterns as per
> +the HaRP extension as well as HSX-style embedded XML syntax.")
> +    (license bsd-3)))
> +
>  (define-public ghc-cpphs
>    (package
>      (name "ghc-cpphs")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-hlint.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-hlint): New variable.
> ---
>  gnu/packages/haskell.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index d56c9e2..c03848f 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -498,6 +498,36 @@ Apart from these standard extensions, it also handles regular patterns as per
>  the HaRP extension as well as HSX-style embedded XML syntax.")
>      (license bsd-3)))
>  
> +(define-public ghc-hlint
> +  (package
> +    (name "ghc-hlint")

I would suggest calling this package simple "hlint", as it is primarily a tool.

`~Eric

> +    (version "1.9.21")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/hlint/hlint-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "14v3rdjjlml9nimdk7d5dvir2bw78ai49yylvms9lnzmw29s3546"))))
> +    (build-system haskell-build-system)
> +    (inputs
> +     `(("ghc-cpphs" ,ghc-cpphs)
> +       ("ghc-cmdargs" ,ghc-cmdargs)
> +       ("ghc-haskell-src-exts" ,ghc-haskell-src-exts)
> +       ("ghc-uniplate" ,ghc-uniplate)
> +       ("ghc-ansi-terminal" ,ghc-ansi-terminal)
> +       ("ghc-extra" ,ghc-extra)
> +       ("ghc-hscolour" ,ghc-hscolour)))
> +    (home-page
> +     "http://community.haskell.org/~ndm/hlint/")
> +    (synopsis "Source code suggestions")

"Make suggestions for Haskell source code"

> +    (description
> +     "HLint gives suggestions on how to improve your source code.")

How about, from the home-page:

"HLint reads Haskell programs and suggests changes that hopefully make them
easier to read.  HLint also makes it easy to disable unwanted suggestions, and
to add your own custom suggestions."

> +    (license bsd-3)))
> +
>  (define-public ghc-cpphs
>    (package
>      (name "ghc-cpphs")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-hscolour.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-hscolour): New variable.
> ---
>  gnu/packages/haskell.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 905471d..ebad06a 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1331,6 +1331,30 @@ for better error messages.")
>      (description "This library provides @code{Comonad}s for Haskell.")
>      (license bsd-3)))
>  
> +(define-public ghc-hscolour
> +  (package
> +    (name "ghc-hscolour")

I would suggest we name this package "hscolour" because it is primarily
program or tool.  It also has libraries; perhaps those could be put in a "lib"
output?  WDYT?

`~Eric

> +    (version "1.23")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/hscolour/hscolour-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1c4i2zpami8g3w9949nm3f92g7xwh5c94vkx658zz7ihrjp7w5lp"))))
> +    (build-system haskell-build-system)
> +    (home-page "https://hackage.haskell.org/package/hscolour")
> +    (synopsis "Script to colourise Haskell code")
> +    (description "HSColour is a small Haskell script to colourise Haskell
> +code.  It currently has six output formats: ANSI terminal codes (optionally
> +XTerm-256colour codes), HTML 3.2 with font tags, HTML 4.01 with CSS, HTML 4.01
> +with CSS and mouseover annotations, XHTML 1.0 with inline CSS styling, LaTeX,
> +and mIRC chat codes.")
> +    (license bsd-3)))
> +
>  (define-public ghc-appar
>    (package
>      (name "ghc-appar")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-opengl.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-opengl): New variable.
> ---
>  gnu/packages/haskell.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 5203cd0..792dce0 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -940,6 +940,36 @@ It is basically a 1:1 mapping of GLU's C API, intended as a basis for a nicer
>  interface.")
>      (license bsd-3)))
>  
> +(define-public ghc-opengl
> +  (package
[...]
> +    (synopsis
> +     "Bindings for the OpenGL graphics system")

"Haskell bindings for the OpenGL graphics system"

> +    (description
> +     "A Haskell binding for the OpenGL graphics system (GL, version 4.5) and
> +its accompanying utility library (GLU, version 1.3).")

"This package provides Haskell bindings for..."

And similar suggestions for ghc-glut.

`~Eric

> +    (license bsd-3)))
> +
>  (define-public ghc-streaming-commons
>    (package
>      (name "ghc-streaming-commons")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-openglraw.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

[...]
> +(define-public ghc-openglraw
> +  (package
> +    (name "ghc-openglraw")
> +    (version "2.5.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/OpenGLRaw/OpenGLRaw-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1kfq24mxg922ml3kkmym2qfpc56jbmrfbiix4rc2cxlwv05i191k"))))
> +    (build-system haskell-build-system)
> +    (inputs
> +     `(("ghc-half" ,ghc-half)
> +       ("glu" ,glu)
> +       ("ghc-text" ,ghc-text)))
> +    (home-page
> +     "http://www.haskell.org/haskellwiki/Opengl")
> +    (synopsis
> +     "Raw bindings for the OpenGL graphics system")

"Raw bindings" -> "Raw Haskell bindings"

`~Eric

Re: [PATCH] gnu: Add ghc-pcre-light.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-pcre-light): New variable.
> ---
>  gnu/packages/haskell.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
[...]
> +    (synopsis
> +     "Efficient and portable Perl-compatible regex library")

In order to disambiguate with other pcre libraries, how about:

"Haskell library for Perl 5 compatible regular expressions"

> +    (description
> +     "This package provides a small, efficient and portable regex library for

We tend to make use of the Oxford comma. --------^

`~Eric

Re: [PATCH] gnu: Add ghc-reflection.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-reflection): New variable.
> ---
>  gnu/packages/haskell.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index ee30454..86fc76f 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -364,6 +364,31 @@ package.")
>  package.")
>      (license bsd-3)))
>  
> +(define-public ghc-reflection
> +  (package
> +    (name "ghc-reflection")
> +    (version "2.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/reflection/reflection-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "10w3m6v3g6am203wbrikdbp57x9vw6b4jsh7bxdzsss4nmpm81zg"))))
> +    (build-system haskell-build-system)
> +    (inputs `(("ghc-tagged" ,ghc-tagged)))
> +    (home-page "http://github.com/ekmett/reflection")
> +    (synopsis "Reifies arbitrary terms into types that can be reflected back
> +into terms")

"Reifies" -> "Reify"

> +    (description "This package addresses the 'configuration problem' which is
> +propogating configurations that are available at run-time, allowing multible

"multible" -> "multiple"

> +configurations to coexist without resorting to mutable global variables or
> +@code{System.IO.Unsafe.unsafePerformIO}.")
> +    (license bsd-3)))
> +
>  (define-public ghc-old-locale
>    (package
>      (name "ghc-old-locale")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-regex-base.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-regex-base): New variable.
> ---
>  gnu/packages/haskell.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
[...]
> +    (description
> +     "Interface API for regex-posix, pcre, parsec, tdfa, dfa.")

How about:

Text.Regex.Base provides the interface API for regex-posix, regex-pcre,
regex-parsec, regex-tdfa, and regex-dfa.

`~Eric

Re: [PATCH] gnu: Add ghc-regex-posix.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-regex-posix): New variable.
> ---
>  gnu/packages/haskell.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index bff7a54..92345f0 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1692,6 +1692,28 @@ Both IPv4 and IPv6 are supported.")
>       "Interface API for regex-posix, pcre, parsec, tdfa, dfa.")
>      (license bsd-3)))
>  
> +(define-public ghc-regex-posix
> +  (package
> +    (name "ghc-regex-posix")
> +    (version "0.95.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/regex-posix/regex-posix-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0gkhzhj8nvfn1ija31c7xnl6p0gadwii9ihyp219ck2arlhrj0an"))))
> +    (build-system haskell-build-system)
> +    (inputs `(("ghc-regex-base" ,ghc-regex-base)))
> +    (home-page "http://sourceforge.net/projects/lazy-regex")
> +    (synopsis "Replaces/Enhances Text.Regex")

How about: "POSIX regular expressions for Haskell"

`~Eric

> +    (description "This library provides the posix regex backend used by
> +@code{regex-base}.")
> +    (license bsd-3)))
> +
>  (define-public ghc-regex-tdfa-rc
>    (package
>      (name "ghc-regex-tdfa-rc")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-regex-tdfa-rc.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-regex-tdfa-rc): New variable.
> ---
>  gnu/packages/haskell.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index be37c5a..810dfb1 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1132,6 +1132,34 @@ Both IPv4 and IPv6 are supported.")
>       "Interface API for regex-posix, pcre, parsec, tdfa, dfa.")
>      (license bsd-3)))
>  
> +(define-public ghc-regex-tdfa-rc
> +  (package
> +    (name "ghc-regex-tdfa-rc")
> +    (version "1.1.8.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/regex-tdfa-rc/regex-tdfa-rc-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1vi11i23gkkjg6193ak90g55akj69bhahy542frkwb68haky4pp3"))))
> +    (build-system haskell-build-system)
> +    (propagated-inputs
> +     `(("ghc-regex-base" ,ghc-regex-base)
> +       ("ghc-parsec" ,ghc-parsec)))
> +    (inputs
> +     `(("ghc-mtl" ,ghc-mtl)))

I would be surprised if this did not also need to be propagated, but I confess
I do not know of a reliable way to check.

> +    (home-page
> +     "http://hackage.haskell.org/package/regex-tdfa")
> +    (synopsis "Replaces/Enhances Text.Regex")

How about: "Tagged DFA regex engine for Haskell"

`~Eric

Re: [PATCH] gnu: Add ghc-sdl-mixer.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-sdl-mixer): New variable.
> ---
>  gnu/packages/haskell.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 161b3e5..914c518 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -894,6 +894,48 @@ by MPEG playback software, emulators, and many popular games, including the
>  award winning Linux port of \"Civilization: Call To Power.\"")
>      (license bsd-3)))
>  
> +(define-public ghc-sdl-mixer
> +  (package
> +    (name "ghc-sdl-mixer")
> +    (version "0.6.1.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/SDL-mixer/SDL-mixer-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0md3238hx79mxb9a7l43kg3b3d28x4mqvj0hjsbsh15ajnvy9x2z"))))
> +    (build-system haskell-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       (let* ((sdl-mixer (assoc-ref %build-inputs "sdl-mixer"))
> +              (sdl-mixer-lib (string-append sdl-mixer "/lib"))
> +              (sdl-mixer-include (string-append sdl-mixer "/include/SDL")))
> +         (list (string-append "--extra-include-dirs=" sdl-mixer-include)
> +               (string-append "--extra-lib-dirs=" sdl-mixer-lib)))

Is the --extra-lib-dirs argument really necessary?  I think
haskell-build-system already passes flags for every "lib" directory it sees in
inputs.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before
> +          'configure 'fix-/bin/sh
> +          (lambda _
> +            ;; Use `sh', not `/bin/sh'.
> +            (substitute* (find-files "." "Makefile|configure")
> +              (("/bin/sh") "sh")))))))

See comments about ghc-doctest package.

> +    (propagated-inputs
> +     `(("sdl-mixer" ,sdl-mixer)

I can understand propagating ghc-sdl, but is it necessary to propagate the
sdl-mixer library too?

> +       ("ghc-sdl" ,ghc-sdl)))
> +    (home-page
> +     "http://hackage.haskell.org/package/SDL-mixer")
> +    (synopsis "Binding to libSDL_mixer")

"Haskell bindings to libSDL_mixer"

Similar comments for the ghc-sdl-image patch.

`~Eric

> +    (description "SDL_mixer is a sample multi-channel audio mixer library.  It
> +supports any number of simultaneously playing channels of 16 bit stereo audio,
> +plus a single channel of music, mixed by the popular MikMod MOD, Timidity
> +MIDI, Ogg Vorbis, and SMPEG MP3 libraries.")
> +    (license bsd-3)))
> +
>  (define-public ghc-half
>    (package
>      (name "ghc-half")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-semigroupoids.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-semigroupoids): New variable.
> ---
>  gnu/packages/haskell.scm | 39 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 9b1c4cb..c6b092b 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -3087,6 +3087,45 @@ are implemented as FFI bindings to efficient code from zlib.")
>      (description "This package provides bifunctors for Haskell.")
>      (license bsd-3)))
>  
> +(define-public ghc-semigroupoids
> +  (package
> +    (name "ghc-semigroupoids")
> +    (version "5.0.0.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/semigroupoids/semigroupoids-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1jf7jnfhdvl6p18wdr21yi2fim1xb8alcn6szhrdswj0dkilgq6d"))))
> +    (build-system haskell-build-system)
> +    (propagated-inputs
> +     `(("ghc-base-orphans" ,ghc-base-orphans)
> +       ("ghc-transformers-compat" ,ghc-transformers-compat)
> +       ("ghc-bifunctors" ,ghc-bifunctors)
> +       ("ghc-comonad" ,ghc-comonad)
> +       ("ghc-contravariant" ,ghc-contravariant)
> +       ("ghc-distributive" ,ghc-distributive)))
> +    (arguments `(#:tests? #f)) ; FIXME: test framework unavailable
> +    (inputs
> +     `(("ghc-semigroups" ,ghc-semigroups)
> +       ("ghc-tagged" ,ghc-tagged)
> +       ("ghc-doctest" ,ghc-doctest)))
> +    (home-page "http://github.com/ekmett/semigroupoids")
> +    (synopsis "Semigroupoids: Category sans id")

How about: "Semigroupoid operations for Haskell"

`~Eric

> +    (description "This library provides a wide array of (semi)groupoids and
> +operations for working with them.  A @code{Semigroupoid} is a @code{Category}
> +without the requirement of identity arrows for every object in the category.
> +A @code{Category} is any @code{Semigroupoid} for which the Yoneda lemma holds.
> +Finally, to work with these weaker structures it is beneficial to have
> +containers that can provide stronger guarantees about their contents, so
> +versions of @code{Traversable} and @code{Foldable} that can be folded with
> +just a @code{Semigroup} are added.")
> +    (license bsd-3)))
> +
>  (define-public ghc-contravariant
>    (package
>      (name "ghc-contravariant")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-semigroups.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-semigroups): New variable.
> ---
>  gnu/packages/haskell.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index a26c7cf..a40cc3c 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -2468,6 +2468,39 @@ unbounded @code{Integer} type.")
>      (description "This library provides the natural numbers for Haskell.")
>      (license bsd-3)))
>  
> +(define-public ghc-semigroups
> +  (package
[...]
> +    (inputs
> +     `(("ghc-text" ,ghc-text)
> +       ("ghc-hashable" ,ghc-hashable)))

Do these not need to also be propagated?

> +    (synopsis "Anything that associates")

This is quite general.  How about: "Semigroup operations for Haskell"

`~Eric

Re: [PATCH] gnu: Add ghc-tasty-golden.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-tasty-golden): New variable.
> ---
>  gnu/packages/haskell.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index e017595..ccfb087 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -2877,6 +2877,41 @@ It is modeled after doctest for Python, see
>  Haskell test framework.")
>      (license expat)))
>  
> +(define-public ghc-tasty-golden
> +  (package
[...]
> +    (description
> +     "This package provides support for «golden testing».  A golden test is an

It might be best to use standard quotes here, rather than the guillemets, and
let translators handle localization.  WDYT?

`~Eric

Re: [PATCH] gnu: Add ghc-uniplate.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-uniplate): New variable.
> ---
>  gnu/packages/haskell.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 4246b64..50da7ff 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1381,6 +1381,34 @@ optimized for performance critical use, both in terms of large data quantities
>  and high speed.")
>      (license bsd-3)))
>  
> +(define-public ghc-uniplate
> +  (package
[...]
> +    (synopsis
> +     "Help writing simple, concise and fast generic operations")

How about: "Simple, concise, and fast generic operations"

> +    (description "Uniplate is library for writing simple and concise generic

Uniplate is _a_ library...

> +operations.  Uniplate has similar goals to the original Scrap Your Boilerplate
> +work, but is substantially simpler and faster.")

       ^---- I believe this comma is grammatically unnecessary.

`~Eric

Re: [PATCH] gnu: Add ghc-unix-time.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-unix-time): New variable.
> ---
>  gnu/packages/haskell.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index fc1f836..de55610 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -972,6 +972,46 @@ transformers 0.2 or 0.3 compatibility to run on old versions of the platform,
>  but also need those types.")
>      (license bsd-3)))
>  
> +(define-public ghc-unix-time
> +  (package
> +    (name "ghc-unix-time")
> +    (version "0.3.6")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/unix-time/unix-time-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0dyvyxwaffb94bgri1wc4b9wqaasy32pyjn0lww3dqblxv8fn5ax"))))
> +    (build-system haskell-build-system)
> +    (arguments
> +     `(#:tests? #f ; FIXME: Test fails with "System.Time not found".  This is
> +                   ; weird, that should be provided by GHC 7.10.2.
> +       #:phases
> +       (alist-cons-before
> +        'configure 'fix-/bin/sh
> +        (lambda _
> +          ;; Use `sh', not `/bin/sh'.
> +          (substitute* (find-files "." "Makefile|configure")
> +            (("/bin/sh")
> +             "sh")))
> +        %standard-phases)))

See the ghc-x11 package for a, IMHO, more elegant solution.

This appears to be a more general issue however.  Any package that declares in
its *.cabal file "build-type: Configure" is going to need CONFIG_SHELL and/or
SHELL in the environment.  See additionally the proposed ghc-sdl,
ghc-sdl-image, ghc-sdl-mixer, and ghc-old-time patches.

Perhaps we could patch haskell-build-system to export appropriate CONFIG_SHELL
and SHELL variables if it sees a "configure" file in the top-level source
directory.  WDYT?  Would you like to send a patch?

`~Eric

Re: [PATCH] gnu: Add ghc-wai.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-wai): New variable.
> ---
>  gnu/packages/haskell.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 4236aab..accbd35 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -4004,4 +4004,36 @@ for Haskell, optimized for ease of use and high performance.  (A note on
>  naming: in Greek mythology, Aeson was the father of Jason.)")
>      (license bsd-3)))
>  
> +(define-public ghc-wai
> +  (package
> +    (name "ghc-wai")
> +    (version "3.0.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/wai/wai-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1551n0g0n22vml33v0jz5xgjcy6j79algvsdqg11a1z5ljjrjlqf"))))
> +    (build-system haskell-build-system)
> +    (propagated-inputs
> +     `(("ghc-bytestring-builder" ,ghc-bytestring-builder)
> +       ("ghc-unix-compat" ,ghc-unix-compat)
> +       ("ghc-vault" ,ghc-vault)
> +       ("ghc-blaze-builder" ,ghc-blaze-builder)
> +       ("ghc-network" ,ghc-network)))
> +    (inputs
> +     `(("ghc-quickcheck" ,ghc-quickcheck)
> +       ("ghc-hunit" ,ghc-hunit)
> +       ("ghc-hspec" ,ghc-hspec)
> +       ("ghc-text" ,ghc-text)
> +       ("ghc-http-types" ,ghc-http-types)))
> +    (home-page "https://hackage.haskell.org/package/wai")
> +    (synopsis "WAI: Web Application Interface")

How about: "Web application interface library for Haskell."

> +    (description "Web Application Interface library for Haskell.")

and:

"This package provides a Web Application Interface (WAI) library for the
Haskell language.  It defines a common protocol for communication between web
applications and web servers."

`~Eric

> +    (license bsd-3)))
> +
>  ;;; haskell.scm ends here
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add ghc-xml.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-xml): New variable.
> ---
>  gnu/packages/haskell.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 28a65fb..ff11c1b 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1085,6 +1085,27 @@ Transformers\" available @uref{http://okmij.org/ftp/papers/LogicT.pdf,
>  online}.")
>      (license bsd-3)))
>  
> +(define-public ghc-xml
> +  (package
[...]
> +    (inputs `(("ghc-text" ,ghc-text)))

This input should probably be propagated.

`~Eric

Re: [PATCH] gnu: Add ghc-zip-archive.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-zip-archive): New variable.
> ---
>  gnu/packages/haskell.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index d9704c8..35952ed 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -31,6 +31,7 @@
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages elf)
>    #:use-module (gnu packages bootstrap)
> +  #:use-module (gnu packages zip)
>    #:use-module (gnu packages ghostscript)
>    #:use-module (gnu packages libffi)
>    #:use-module (gnu packages libedit)
> @@ -1217,6 +1218,36 @@ complicated text/binary file formats.")
>  Haskell.")
>      (license bsd-3)))
>  
> +(define-public ghc-zip-archive
> +  (package
> +    (name "ghc-zip-archive")
> +    (version "0.2.3.7")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/zip-archive/zip-archive-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "169nkxr5zlbymiz1ydlhlqr66vqiycmg85xh559phpkr64w3nqj1"))))
> +    (build-system haskell-build-system)
> +    (propagated-inputs
> +     `(("ghc-old-time" ,ghc-old-time)
> +       ("ghc-digest" ,ghc-digest)))
> +    (inputs
> +     `(("ghc-hunit" ,ghc-hunit)
> +       ("ghc-mtl" ,ghc-mtl)
> +       ("zip" ,zip)
> +       ("ghc-text" ,ghc-text)
> +       ("ghc-zlib" ,ghc-zlib)))
> +    (home-page "https://hackage.haskell.org/package/zip-archive")
> +    (synopsis "Zip archive library")

Let's distinguish this package with a "for Haskell" in the synopsis.  WDYT?

`~Eric

> +    (description "The zip-archive library provides functions for creating,
> +modifying, and extracting files from zip archives.")
> +    (license bsd-3)))
> +
>  (define-public ghc-appar
>    (package
>      (name "ghc-appar")
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: Add Idris, the dependently-typed language.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

With our conventions, the subject line should be just "gnu: Add Idris"

> * gnu/packages/haskell.scm (idris): New variable.
> ---
>  gnu/packages/haskell.scm | 62 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index e814f24..5cf1827 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -32,6 +32,7 @@
>    #:use-module (gnu packages elf)
>    #:use-module (gnu packages bootstrap)
>    #:use-module (gnu packages zip)
> +  #:use-module (gnu packages gcc)
>    #:use-module (gnu packages ghostscript)
>    #:use-module (gnu packages libffi)
>    #:use-module (gnu packages libedit)
> @@ -4314,4 +4315,65 @@ naming: in Greek mythology, Aeson was the father of Jason.)")
>  functionality.")
>      (license expat)))
>  
> +(define-public idris
> +  (package
> +    (name "idris")
> +    (version "0.9.19.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://hackage.haskell.org/package/idris-"
> +                           version "/idris-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "10641svdsjlxbxmbvylpia04cz5nn9486lpiay8ibqcrc1792qgc"))))
> +    (build-system haskell-build-system)
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-before 'configure 'patch-cc-command
> +                              (lambda _
> +                                (setenv "CC" "gcc")
> +                                ;; Package description file has a too-tight
> +                                ;; version restriction, rendering it
> +                                ;; incompatible with GHC 7.10.2.  This is
> +                                ;; fixed upstream.
> +                                (substitute* "idris.cabal"
> +                                  (("vector < 0.11") "vector < 0.12")))))))

Try adding "--allow-newer=vector" to #:configure-flags.  Otherwise move this
to a separate phase, as it's not strictly related to patching cc.

> +    (native-inputs
> +     `(("gcc" ,gcc)))

gcc is already in the implicit inputs, so this may be left out.

Otherwise LGTM!

`~Eric

> +    (inputs
> +     `(("gmp" ,gmp)
> +       ("ncurses" ,ncurses)
> +       ("ghc-annotated-wl-pprint" ,ghc-annotated-wl-pprint)
> +       ("ghc-ansi-terminal" ,ghc-ansi-terminal)
> +       ("ghc-ansi-wl-pprint" ,ghc-ansi-wl-pprint)
> +       ("ghc-base64-bytestring" ,ghc-base64-bytestring)
> +       ("ghc-blaze-html" ,ghc-blaze-html)
> +       ("ghc-blaze-markup" ,ghc-blaze-markup)
> +       ("ghc-cheapskate" ,ghc-cheapskate)
> +       ("ghc-fingertree" ,ghc-fingertree)
> +       ("ghc-mtl" ,ghc-mtl)
> +       ("ghc-network" ,ghc-network)
> +       ("ghc-optparse-applicative" ,ghc-optparse-applicative)
> +       ("ghc-parsers" ,ghc-parsers)
> +       ("ghc-safe" ,ghc-safe)
> +       ("ghc-split" ,ghc-split)
> +       ("ghc-text" ,ghc-text)
> +       ("ghc-trifecta" ,ghc-trifecta)
> +       ("ghc-uniplate" ,ghc-uniplate)
> +       ("ghc-unordered-containers" ,ghc-unordered-containers)
> +       ("ghc-utf8-string" ,ghc-utf8-string)
> +       ("ghc-vector-binary-instances" ,ghc-vector-binary-instances)
> +       ("ghc-vector" ,ghc-vector)
> +       ("ghc-zip-archive" ,ghc-zip-archive)
> +       ("ghc-zlib" ,ghc-zlib)))
> +    (home-page "http://www.idris-lang.org")
> +    (synopsis "General purpose language with full dependent types")
> +    (description "Idris is a general purpose language with full dependent
> +types.  It is compiled, with eager evaluation.  Dependent types allow types to
> +be predicated on values, meaning that some aspects of a program's behaviour
> +can be specified precisely in the type.  The language is closely related to
> +Epigram and Agda.")
> +    (license bsd-3)))
> +
>  ;;; haskell.scm ends here
> -- 
> 2.5.0
> 

Re: [PATCH] gnu: ghc-split: Update dependencies.

[ericbavier]

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-split): Update package dependencies for
>   compatibility with new GHC.
> ---
>  gnu/packages/haskell.scm | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 2d5f857..6b4b5eb 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1397,8 +1397,27 @@ and high speed.")
>          (base32
>           "0xa3j0gwr6k5vizxybnzk5fgb3pppgspi6mysnp2gwjp2dbrxkzr"))))
>      (build-system haskell-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before
> +          'configure 'update-cabal
> +          ;; the cabal file on hackage is updated, but the tar.gz does not
> +          ;; include it.
> +          (lambda* _
> +            (copy-file (assoc-ref %build-inputs "ghc-split-cabal-update")
> +                       "split.cabal"))))))
>      (inputs
> -     `(("ghc-quickcheck" ,ghc-quickcheck)))
> +     `(("ghc-quickcheck" ,ghc-quickcheck)
> +       ("ghc-split-cabal-update"
> +        ,(origin
> +           (method url-fetch)
> +           (uri (string-append
> +                 "https://hackage.haskell.org/package/split-"
> +                 version "/revision/1.cabal"))
> +           (sha256
> +            (base32
> +             "1i1h5v1zqvganhzy1wdd9r648yjpir078n0g8051njg82h2f964h"))))))
>      (home-page "http://hackage.haskell.org/package/split")
>      (synopsis
>       "Combinator library for splitting lists")

Similarly to the xmonad cabal patch, perhaps this could be addressed with 

  #:configure-flags '("--allow-newer=base")

with an appropriate comment.  Otherwise using an origin snippet.

`~Eric

Re: Reviews for wip-haskell-platform-7.10.2-a

[Paul van der Walt]

Hey Eric,

Thank you for all the review-work!

On 2015-10-22 at 05:10, quoth ericbavier@openmailbox.org:
> I apologize in advance that so many of these comments pertain to the synopses
> and descriptions, but I find that aspect of packaging important, and Ludo was
> kind enough to write up the "Synopses and Descriptions" section in guix.info.

I guess that's the way it should be.  I admit that my descriptions are
often shoddy simply because i wasn't sure what the library does.  But of
course that's no excuse to not follow the style (e.g., sentence
fragments, formatting).

> Along the way I gave up trying to analyse and comment on inputs vs
> propagated-inputs.  The builds check out, and we can adjust later if needed.

Right.  I tried to be conservative with propagated-inputs, but at least
they all work...  I'm curious to see how the library search path patch
will influence things.

> In the absense of comments on a patch, assume a "LGTM!" :)

Okay, well, i'll deal with all the comments before merging anything.

> Thank you, Paul for all the effort,

Seems you went to a lot of effort too, thank you for your thorough
reviews!

On to a more Haskell-friendly Guix! :)

Cheers,
p.

Re: [PATCH] gnu: Add ghc-attoparsec.

[Paul van der Walt]

On 2015-10-22 at 05:10, quoth ericbavier@openmailbox.org:
>> +    (arguments `(#:tests? #f)) ; FIXME: ghc-test-framework unavailable
>> +    (propagated-inputs
>> +     `(("ghc-scientific" ,ghc-scientific)))
>> +    (inputs
>> +     `(
>> +       ("ghc-text" ,ghc-text)
>
> Move this onto the previous line.

Done.  That slipped by me...

> `~Eric
>
>> +       ("ghc-quickcheck" ,ghc-quickcheck)
>> +       ("ghc-quickcheck-unicode" ,ghc-quickcheck-unicode)

I also removed these test-only inputs.

Re: [PATCH] gnu: Add ghc-base64-bytestring.

[Paul van der Walt]

On 2015-10-22 at 05:10, quoth ericbavier@openmailbox.org:
>> +    (arguments `(#:tests? #f))         ; FIXME: testing libraries are missing.
>> +    (inputs
>> +     `(("ghc-quickcheck" ,ghc-quickcheck)
>> +       ("ghc-hunit" ,ghc-hunit)))
>
> These inputs could probably be left out if #:tests? #f.

Correct.  Fixed.

>> +    (home-page "https://github.com/bos/base64-bytestring")
>> +    (synopsis "Fast base64 encoding and decoding for ByteStrings")
>
> Perhaps leave out the "Fast" part.

Done.

Re: [PATCH] gnu: Add ghc-blaze-markup.

[Paul van der Walt]

On 2015-10-22 at 05:18, quoth ericbavier@openmailbox.org:
>> +    (arguments `(#:tests? #f)) ; FIXME: testing libraries are missing.
>> +    (inputs
>> +     `(("ghc-blaze-builder" ,ghc-blaze-builder)
>> +       ("ghc-text" ,ghc-text)
>> +       ("ghc-hunit" ,ghc-hunit)
>> +       ("ghc-quickcheck" ,ghc-quickcheck)))
>
> ghc-blaze-builder and ghc-text should be propagated, and the others may be
> removed because #:tests? #f.

Corrected.

>> +    (home-page "http://jaspervdj.be/blaze")
>> +    (synopsis
>> +     "Blazingly fast markup combinator library for Haskell")
>
> Maybe just: Fast markup combinator library for Haskell

Indeed, i've fixed all the ghc-blaze-* packages with your comments on
synopsis and description.

> This library contains core modules for a markup combinator library for the
> Haskell programming language.
>
> Similar comments for the ghc-blaze-html patch.

Done.

Thanks,
p.

Re: [PATCH] gnu: Add ghc-bytestring-builder.

[Paul van der Walt]

On 2015-10-22 at 05:18, quoth ericbavier@openmailbox.org:
>> +    (arguments `(#:haddock? #f)) ; FIXME: testing framework unavailable
>
> Did you mean '#:tests? #f'? or is the comment incorrect?

Indeed the package contains no documentation.  Comment fixed.  Also took
the opportunity to improve the description.

Ciao,
p.

Re: [PATCH] gnu: Add ghc-blaze-builder.

[Paul van der Walt]

On 2015-10-22 at 05:18, quoth ericbavier@openmailbox.org:
>> +    (arguments `(#:tests? #f))          ; FIXME: Missing test libraries.
>> +    (inputs
>> +     `(("ghc-text" ,ghc-text)
>> +       ("ghc-hunit" ,ghc-hunit)
>> +       ("ghc-quickcheck" ,ghc-quickcheck)
>> +       ("ghc-utf8-string" ,ghc-utf8-string)))
>
> The ghc-hunit and ghc-quickcheck inputs can be removed because #:tests? #f.
> The ghc-text and ghc-utf8-string inputs should probably be propagated.

Done.

Re: [PATCH] gnu: Add ghc-cpphs.

[Paul van der Walt]

Hi Eric,

On 2015-10-22 at 05:25, quoth ericbavier@openmailbox.org:
>> +    (name "ghc-cpphs")
>
> We should probably name this package "cpphs".

Indeed.  I've also renamed ghc-hlint to hlint.

>> +    (license lgpl2.1)))
>
> It looks to me as if the library portions are under the lgpl2.1+ (the '+'
> because they specify no version), and the executable 'cpphs' is under the
> gpl3+ (again, because no version is specified in the source), so both licenses
> should be listed.

Fixed.

Re: [PATCH] gnu: Add ghc-cereal.

[Paul van der Walt]

On 2015-10-22 at 05:25, quoth ericbavier@openmailbox.org:
>> +    (home-page
>> +     "http://hackage.haskell.org/package/cereal")
>> +    (synopsis "Binary serialization library")
>> +    (description
>> +     "This package provides a binary serialization library, similar to binary,
>
> It may not be apparent that the "binary" being referred to here is a haskell
> library.  It should maybe be written as "similar to the @code{binary} library,
> ...".

Description fixed.

Re: [PATCH] gnu: Add ghc-fingertree.

[Paul van der Walt]

On 2015-10-22 at 05:32, quoth ericbavier@openmailbox.org:
>> +    (arguments `(#:tests? #f)) ; FIXME: testing libraries are missing.
>> +    (inputs
>> +     `(("ghc-hunit" ,ghc-hunit)
>> +       ("ghc-quickcheck" ,ghc-quickcheck)))
>
> Test-only inputs could be left out completely here.

Done.

>> +    (home-page "http://hackage.haskell.org/package/fingertree")
>> +    (synopsis "Generic finger-tree structure, with example instances")
>
> The mention of examples here is probably superfluous.

Indeed, removed.

Re: [PATCH] gnu: Add ghc-free.

[Paul van der Walt]

On 2015-10-22 at 05:32, quoth ericbavier@openmailbox.org:
>> +    (synopsis "Monads for free")
>
> How about: "Unrestricted monads for Haskell"

Done.

Re: [PATCH] gnu: Add ghc-doctest.

[Paul van der Walt]

On 2015-10-22 at 05:32, quoth ericbavier@openmailbox.org:
> Testing for and with doctest is tricky.  I'm not sure your comment about
> missing test frameworks is accurate; it looks, from what I can tell, like all
> the necessary inputs are present.
>
> I believe the issue is that tests that call the 'doctest' function may not
> (probably do not) include the "-package-db" argument in the parameter list
> given, but since haskell-build-system relies on the fact that cabal passes
> that argument to GHC, it is essential that that information get there somehow.
> I would say it's a deficiency of most package's build systems that they do not
> take this situation into account.

I see, i finally understand the issue.  That sounds exactly right,
indeed.

> So, either the tests files can be patched to include "-package-db" in the GHC
> arguments given to the 'doctest' function, or GHC_PACKAGE_PATH can be defined
> appropriately before the 'check' phase (at that point in the build cabal will
> not complain, as it would if GHC_PACKAGE_PATH were defined during the
> 'configure' phase).

I think this is unnecessarily complex, especially given the upcoming
native-search-path patch.

> It looks to me like tests are disabled for all packages that use doctest in
> this patch series:
>
> ghc-trifecta
> ghc-lens
> ghc-wai-logger
> ghc-parsers
> ghc-semigroupoids
> ghc-comonad
> ghc-distributive
> ghc-http-types
> ghc-unix-time
> ghc-iproute
>
> I would suggest that tests for these packages simply be disabled (and the
> corresponding test-only inputs be removed) for the time being.  The pending
> GHC native-search-path patches should trivially resolve this issue, at which
> time tests for these packages can be revisited.

I have indeed simply removed the test-only inputs on these packages, and
fixed the comments to correspond to the real problem.

Thanks,
p.

Re: [PATCH] gnu: Add ghc-clock.

[Paul van der Walt]

Hi Eric,

On 2015-10-22 at 05:25, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-clock
>> +  (package
>> +    (name "ghc-clock")
>> +    (version "0.5.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "http://hackage.haskell.org/package/"
>> +             "clock/"
>> +             "clock-" version ".tar.gz"))
>> +       (sha256
>> +        (base32 "1ncph7vi2q6ywwc8ysxl1ibw6i5dwfvln88ssfazk8jgpj4iyykw"))))
>> +    (build-system haskell-build-system)
>> +    (arguments `(#:tests? #f)) ;; Testing suite depends on ghc-clock
>
> A trick that's used with some other packages is to define an unexported
> *-bootstrap package.  The ghc-clock-bootstrap package would have tests
> disabled, then the ghc-clock package would inherit from the
> ghc-clock-bootstrap package, declare ghc-clock-bootstrap as an input, and
> enable tests.

I see what you mean, that's a nice idea.  I've reshuffled the order of
the patches around what used to be ghc-clock a bit, turned it into
ghc-clock-bootstrap, and when the needed test packages (which were the
ones depending on ghc-clock) are defined, i add ghc-clock with tests.
This works!  Could you please tell me if i've done it properly?
Everything (including your other comments) has been pushed to the
`wip-haskell-platform-7.10.2-a` branch.

Thank you again for so much constructive criticism, i hope the patches
are finally up to scratch!

Regards,
p.

Re: [PATCH] gnu: Add ghc-haskell-src-exts.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +     "Manipulating Haskell source: abstract syntax, lexer, parser, and
>> +pretty-printer")
>
> How about: "Manipulate Haskell source"

Done!

Re: [PATCH] gnu: Add ghc-semigroups.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (inputs
>> +     `(("ghc-text" ,ghc-text)
>> +       ("ghc-hashable" ,ghc-hashable)))
>
> Do these not need to also be propagated?

This is a comment that comes up frequently.  To be honest, i don't know
how to check.  My packaging strategy has been,

1) put everything in `inputs`

2) make sure the package P1 builds

3) use P1 as an input elsewhere, say in P2

4) if and only if P2 cannot build because of the usual "broken package,
   missing dependencies for P1" error, i add the missing packages to
   `propagated-inputs` of P1.

So no, pragmatically speaking, those inputs do not need to be
propagated, because subsequent builds work fine (up to and including
Idris, which was the root of the dependency tree causing me to add this
and many other packages).

If, however, you believe it's preferable to put the inputs you mention
into `propagated-inputs`, i will not provide any resistance.

Regards,
p.

Re: [PATCH] gnu: Add ghc-gluraw.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (synopsis
>> +     "Raw bindings for the OpenGL graphics system")
>
> How about: "Raw Haskell bindings for GLU"

Done!

Re: [PATCH] gnu: Add Idris, the dependently-typed language.

[Paul van der Walt]

Hi Eric,

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
> With our conventions, the subject line should be just "gnu: Add Idris"

Awww, no embellishments allowed *sniff*?  :)

Fixed though.

> Try adding "--allow-newer=vector" to #:configure-flags.

I tried, this option does not exist.

> Otherwise move this to a separate phase, as it's not strictly related
> to patching cc.

Done.

>> +    (native-inputs
>> +     `(("gcc" ,gcc)))
>
> gcc is already in the implicit inputs, so this may be left out.

Indeed, done!

p.

Re: [PATCH] gnu: Add ghc-zip-archive.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (synopsis "Zip archive library")
>
> Let's distinguish this package with a "for Haskell" in the synopsis.  WDYT?

Good point, done!

Re: [PATCH] gnu: Add ghc-xml.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-xml
>> +  (package
> [...]
>> +    (inputs `(("ghc-text" ,ghc-text)))
>
> This input should probably be propagated.

Changed.

Re: [PATCH] gnu: Add ghc-wai.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (synopsis "WAI: Web Application Interface")
>
> How about: "Web application interface library for Haskell."
>
>> +    (description "Web Application Interface library for Haskell.")
>
> and:
>
> "This package provides a Web Application Interface (WAI) library for the
> Haskell language.  It defines a common protocol for communication between web
> applications and web servers."

Both changed, thanks for the suggestions!

Re: [PATCH] gnu: Add ghc-uniplate.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (synopsis
>> +     "Help writing simple, concise and fast generic operations")
>
> How about: "Simple, concise, and fast generic operations"

Changed.

>> +    (description "Uniplate is library for writing simple and concise generic
>
> Uniplate is _a_ library...

Good catch, thanks.

>> +operations.  Uniplate has similar goals to the original Scrap Your Boilerplate
>> +work, but is substantially simpler and faster.")
>
>        ^---- I believe this comma is grammatically unnecessary.

Without the comma, i find the sentence a bit breathless.

p.

Re: [PATCH] gnu: Add ghc-tasty-golden.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (description
>> +     "This package provides support for «golden testing».  A golden test is an
>
> It might be best to use standard quotes here, rather than the guillemets, and
> let translators handle localization.  WDYT?

I simply used the original package description, but okay, i've updated
it to use quotes.

Re: [PATCH] gnu: Add ghc-semigroups.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-semigroups
>> +  (package
> [...]
>> +    (inputs
>> +     `(("ghc-text" ,ghc-text)
>> +       ("ghc-hashable" ,ghc-hashable)))
>
> Do these not need to also be propagated?

I don't know, but it works for me (including packages which depend on
this one).  See my previous email on the subject.

>> +    (synopsis "Anything that associates")
>
> This is quite general.  How about: "Semigroup operations for Haskell"

Fixed.

Re: [PATCH] gnu: Add ghc-semigroupoids.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (synopsis "Semigroupoids: Category sans id")
>
> How about: "Semigroupoid operations for Haskell"

Fixed.

Re: [PATCH] gnu: Add ghc-regex-tdfa-rc.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (inputs
>> +     `(("ghc-mtl" ,ghc-mtl)))
>
> I would be surprised if this did not also need to be propagated, but I confess
> I do not know of a reliable way to check.

Works for me.  Maybe we should look at this stuff after the
native-search-path patch has been applied.

>> +    (home-page
>> +     "http://hackage.haskell.org/package/regex-tdfa")
>> +    (synopsis "Replaces/Enhances Text.Regex")
>
> How about: "Tagged DFA regex engine for Haskell"

Fixed.

Re: [PATCH] gnu: Add ghc-regex-posix.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (synopsis "Replaces/Enhances Text.Regex")
>
> How about: "POSIX regular expressions for Haskell"

Fixed.

Re: [PATCH] gnu: Add ghc-regex-base.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (description
>> +     "Interface API for regex-posix, pcre, parsec, tdfa, dfa.")
>
> How about:
>
> Text.Regex.Base provides the interface API for regex-posix, regex-pcre,
> regex-parsec, regex-tdfa, and regex-dfa.

Fixed.

Re: [PATCH] gnu: Add ghc-reflection.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (synopsis "Reifies arbitrary terms into types that can be reflected back
>> +into terms")
>
> "Reifies" -> "Reify"
>
>> +    (description "This package addresses the 'configuration problem' which is
>> +propogating configurations that are available at run-time, allowing multible
>
> "multible" -> "multiple"

Both fixed.

Re: [PATCH] gnu: Add ghc-pcre-light.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (synopsis
>> +     "Efficient and portable Perl-compatible regex library")
>
> In order to disambiguate with other pcre libraries, how about:
>
> "Haskell library for Perl 5 compatible regular expressions"
>
>> +    (description
>> +     "This package provides a small, efficient and portable regex library for
>
> We tend to make use of the Oxford comma. --------^

All fixed.

Re: [PATCH] gnu: Add ghc-openglraw.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (synopsis
>> +     "Raw bindings for the OpenGL graphics system")
>
> "Raw bindings" -> "Raw Haskell bindings"

Done.

Re: [PATCH] gnu: Add ghc-opengl.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-opengl
>> +  (package
> [...]
>> +    (synopsis
>> +     "Bindings for the OpenGL graphics system")
>
> "Haskell bindings for the OpenGL graphics system"
>
>> +    (description
>> +     "A Haskell binding for the OpenGL graphics system (GL, version 4.5) and
>> +its accompanying utility library (GLU, version 1.3).")
>
> "This package provides Haskell bindings for..."
>
> And similar suggestions for ghc-glut.

Fixed for ghc-glut and ghc-opengl.

Re: [PATCH] gnu: Add ghc-hlint.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-hlint
>> +  (package
>> +    (name "ghc-hlint")
>
> I would suggest calling this package simple "hlint", as it is primarily a tool.

Indeed, i had the same feeling :).  Done.

>> +    (synopsis "Source code suggestions")
>
> "Make suggestions for Haskell source code"

Slightly modified, but done.

>> +    (description
>> +     "HLint gives suggestions on how to improve your source code.")
>
> How about, from the home-page:
>
> "HLint reads Haskell programs and suggests changes that hopefully make them
> easier to read.  HLint also makes it easy to disable unwanted suggestions, and
> to add your own custom suggestions."

Perfect, applied.

Re: [PATCH] gnu: Add ghc-hscolour.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-hscolour
>> +  (package
>> +    (name "ghc-hscolour")
>
> I would suggest we name this package "hscolour" because it is primarily
> program or tool.

Indeed, i have renamed it.

> It also has libraries; perhaps those could be put in a "lib"
> output?  WDYT?

Maybe i should be less lazy (surely we can forgive that in the context
of Haskell), but to be perfectly frank, i'd just love to get these
patches off my plate.  Given that the Guix behaviour mirrors the Cabal
behaviour for this package (that is, it's installed, or not) i think
it's fine.  But indeed i am not the most pedantic person here.

I will defer to your better judgement, but for now i've only changed the
package name.

Thanks,
p.

Re: [PATCH] gnu: Add ghc-haddock-api.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (synopsis
>> +     "Documentation-generation tool for Haskell libraries")
>> +    (description
>> +     "Haddock is a documentation-generation tool for Haskell libraries.")
>
> Could you adjust the synopsis and description to differentiate this package
> from ghc-haddock?

Done.

Re: [PATCH] gnu: Add ghc-unix-time.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +       #:phases
>> +       (alist-cons-before
>> +        'configure 'fix-/bin/sh
>> +        (lambda _
>> +          ;; Use `sh', not `/bin/sh'.
>> +          (substitute* (find-files "." "Makefile|configure")
>> +            (("/bin/sh")
>> +             "sh")))
>> +        %standard-phases)))
>
> See the ghc-x11 package for a, IMHO, more elegant solution.

Ah!  Indeed.

> This appears to be a more general issue however.  Any package that declares in
> its *.cabal file "build-type: Configure" is going to need CONFIG_SHELL and/or
> SHELL in the environment.  See additionally the proposed ghc-sdl,
> ghc-sdl-image, ghc-sdl-mixer, and ghc-old-time patches.
>
> Perhaps we could patch haskell-build-system to export appropriate CONFIG_SHELL
> and SHELL variables if it sees a "configure" file in the top-level source
> directory.  WDYT?  Would you like to send a patch?

Right, i see what you mean.  I agree that it'd probably be the right
thing to do.  However, to expedite the merge of wip-haskell-… i propose
that i take the solution of ghc-x11 and apply it to the relevant
packages, and then look at fixing the haskell-build-system.  At that
point we can simply remove the phases introduced to work around this
deficiency.

Do you think that's acceptable, or is it imperative* that we first solve
the problem in the build system?

I prefer the incremental approach (but i am not an objective outside
observer).

King regards,
p.

Re: [PATCH] gnu: Add ghc-sdl-mixer.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +     `(#:configure-flags
>> +       (let* ((sdl-mixer (assoc-ref %build-inputs "sdl-mixer"))
>> +              (sdl-mixer-lib (string-append sdl-mixer "/lib"))
>> +              (sdl-mixer-include (string-append sdl-mixer "/include/SDL")))
>> +         (list (string-append "--extra-include-dirs=" sdl-mixer-include)
>> +               (string-append "--extra-lib-dirs=" sdl-mixer-lib)))
>
> Is the --extra-lib-dirs argument really necessary?  I think
> haskell-build-system already passes flags for every "lib" directory it
> sees in inputs.

Indeed, that was a troubleshooting remnant.  Thanks!  Removed.

>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-before
>> +          'configure 'fix-/bin/sh
>> +          (lambda _
>> +            ;; Use `sh', not `/bin/sh'.
>> +            (substitute* (find-files "." "Makefile|configure")
>> +              (("/bin/sh") "sh")))))))
>
> See comments about ghc-doctest package.

I assume you mean the more elegant CONFIG_SHELL environment variable
patch?  If so, it's been fixed.

>> +    (propagated-inputs
>> +     `(("sdl-mixer" ,sdl-mixer)
>
> I can understand propagating ghc-sdl, but is it necessary to propagate the
> sdl-mixer library too?

You're right, it's not.  Removed.

>> +       ("ghc-sdl" ,ghc-sdl)))
>> +    (home-page
>> +     "http://hackage.haskell.org/package/SDL-mixer")
>> +    (synopsis "Binding to libSDL_mixer")
>
> "Haskell bindings to libSDL_mixer"

Fixed.

> Similar comments for the ghc-sdl-image patch.

The same changes have been applied to ghc-sdl-image.

Thank you!
p.

Re: [PATCH] gnu: ghc-split: Update dependencies.

[Paul van der Walt]

On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before
>> +          'configure 'update-cabal
>> +          ;; the cabal file on hackage is updated, but the tar.gz does not
>> +          ;; include it.
>> +          (lambda* _
>> +            (copy-file (assoc-ref %build-inputs "ghc-split-cabal-update")
>> +                       "split.cabal"))))))
>>      (inputs
>> -     `(("ghc-quickcheck" ,ghc-quickcheck)))
>> +     `(("ghc-quickcheck" ,ghc-quickcheck)
>> +       ("ghc-split-cabal-update"
>> +        ,(origin
>> +           (method url-fetch)
>> +           (uri (string-append
>> +                 "https://hackage.haskell.org/package/split-"
>> +                 version "/revision/1.cabal"))
>> +           (sha256
>> +            (base32
>> +             "1i1h5v1zqvganhzy1wdd9r648yjpir078n0g8051njg82h2f964h"))))))
>>      (home-page "http://hackage.haskell.org/package/split")
>>      (synopsis
>>       "Combinator library for splitting lists")
>
> Similarly to the xmonad cabal patch, perhaps this could be addressed with 
>
>   #:configure-flags '("--allow-newer=base")

Nope, that option doesn't exist, i've checked.

> with an appropriate comment.  Otherwise using an origin snippet.

I've made it into a (substitute* "split.cabal" ..) which simply updates
the version number of base ("base <4.8" → "base <4.9"), in accordance
with the change on Hackage.  A comment is provided.

The patches responding to your latest batch of comments have been pushed
to the wip-haskell-… branch.

Thanks again!
p.

Re: [PATCH] gnu: Add ghc-unix-time.

[Andreas Enge]

On Thu, Oct 22, 2015 at 05:43:03PM +0200, Paul van der Walt wrote:
> Right, i see what you mean.  I agree that it'd probably be the right
> thing to do.  However, to expedite the merge of wip-haskell-… i propose
> that i take the solution of ghc-x11 and apply it to the relevant
> packages, and then look at fixing the haskell-build-system.  At that
> point we can simply remove the phases introduced to work around this
> deficiency.
> Do you think that's acceptable, or is it imperative* that we first solve
> the problem in the build system?
> I prefer the incremental approach (but i am not an objective outside
> observer).

I think it sounds reasonable, and would save us from further iterations
of 150 commits sent to the mailing list :-)  Seriously, I am impressed
by your git juggling.

Andreas

Re: [PATCH] gnu: Add ghc-hscolour.

[Eric Bavier]

On 2015-10-22 10:17, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> +(define-public ghc-hscolour
>>> +  (package
>>> +    (name "ghc-hscolour")
>> 
>> I would suggest we name this package "hscolour" because it is 
>> primarily
>> program or tool.
> 
> Indeed, i have renamed it.
> 
>> It also has libraries; perhaps those could be put in a "lib"
>> output?  WDYT?
> 
> Maybe i should be less lazy (surely we can forgive that in the context
> of Haskell), but to be perfectly frank, i'd just love to get these
> patches off my plate.  Given that the Guix behaviour mirrors the Cabal
> behaviour for this package (that is, it's installed, or not) i think
> it's fine.  But indeed i am not the most pedantic person here.
> 
> I will defer to your better judgement, but for now i've only changed 
> the
> package name.

Seems fair.  We can revisit later if need be.  Thanks for sticking out 
the review.

-- 
`~Eric

Re: [PATCH] gnu: Add ghc-unix-time.

[Paul van der Walt]

Hey Andreas,

On 2015-10-22 at 18:22, quoth Andreas Enge:
> On Thu, Oct 22, 2015 at 05:43:03PM +0200, Paul van der Walt wrote:
>> Right, i see what you mean.  I agree that it'd probably be the right
>> thing to do.  However, to expedite the merge of wip-haskell-… i propose
>> that i take the solution of ghc-x11 and apply it to the relevant
>> packages, and then look at fixing the haskell-build-system.  At that
>> point we can simply remove the phases introduced to work around this
>> deficiency.
>> Do you think that's acceptable, or is it imperative* that we first solve
>> the problem in the build system?
>> I prefer the incremental approach (but i am not an objective outside
>> observer).
>
> I think it sounds reasonable, and would save us from further iterations
> of 150 commits sent to the mailing list :-)

I'm glad i'm not the only one who thinks that way :).  I'll be happy to
have these patches off my plate.

> Seriously, I am impressed by your git juggling.

Haha, thank you :-$, i still have much to learn though.  I guess Guix is
good practice for me? :)

Kind regards,
p.

Re: [PATCH] gnu: Add ghc-hscolour.

[Paul van der Walt]

On 2015-10-22 at 18:48, quoth Eric Bavier:
>> I will defer to your better judgement, but for now i've only changed
>> the package name.
>
> Seems fair.  We can revisit later if need be.  Thanks for sticking out 
> the review.

Haha, thank you too, it's probably equally tiring :p.

p.

Re: [PATCH] gnu: Add ghc-semigroups.

[Eric Bavier]

On 2015-10-22 09:15, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> +    (inputs
>>> +     `(("ghc-text" ,ghc-text)
>>> +       ("ghc-hashable" ,ghc-hashable)))
>> 
>> Do these not need to also be propagated?
> 
> This is a comment that comes up frequently.  To be honest, i don't know
> how to check.  My packaging strategy has been,
> 
> 1) put everything in `inputs`
> 
> 2) make sure the package P1 builds
> 
> 3) use P1 as an input elsewhere, say in P2
> 
> 4) if and only if P2 cannot build because of the usual "broken package,
>    missing dependencies for P1" error, i add the missing packages to
>    `propagated-inputs` of P1.
> 
> So no, pragmatically speaking, those inputs do not need to be
> propagated, because subsequent builds work fine (up to and including
> Idris, which was the root of the dependency tree causing me to add this
> and many other packages).

Great.  Yes, we'd rather not propagate inputs unless strictly necessary. 
  The only reason I ask is for cases where a user might be using the 
library to build something we do not have packaged, but in that case 
it's trivial enough them to install the missing dependency.  Again, all 
this should be a moot point with a native-search-path for GHC.

-- 
`~Eric

Re: [PATCH] gnu: Add ghc-unix-time.

[Eric Bavier]

On 2015-10-22 10:43, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> +       #:phases
>>> +       (alist-cons-before
>>> +        'configure 'fix-/bin/sh
>>> +        (lambda _
>>> +          ;; Use `sh', not `/bin/sh'.
>>> +          (substitute* (find-files "." "Makefile|configure")
>>> +            (("/bin/sh")
>>> +             "sh")))
>>> +        %standard-phases)))
>> 
>> See the ghc-x11 package for a, IMHO, more elegant solution.
> 
> Ah!  Indeed.
> 
>> This appears to be a more general issue however.  Any package that 
>> declares in
>> its *.cabal file "build-type: Configure" is going to need CONFIG_SHELL 
>> and/or
>> SHELL in the environment.  See additionally the proposed ghc-sdl,
>> ghc-sdl-image, ghc-sdl-mixer, and ghc-old-time patches.
>> 
>> Perhaps we could patch haskell-build-system to export appropriate 
>> CONFIG_SHELL
>> and SHELL variables if it sees a "configure" file in the top-level 
>> source
>> directory.  WDYT?  Would you like to send a patch?
> 
> Right, i see what you mean.  I agree that it'd probably be the right
> thing to do.  However, to expedite the merge of wip-haskell-… i propose
> that i take the solution of ghc-x11 and apply it to the relevant
> packages, and then look at fixing the haskell-build-system.  At that
> point we can simply remove the phases introduced to work around this
> deficiency.

OK.

> Do you think that's acceptable, or is it imperative* that we first 
> solve
> the problem in the build system?

An incremental approach seems reasonable to me in this case, since there 
are not so many affected packages at this point.

-- 
`~Eric

Re: [PATCH] gnu: Add Idris, the dependently-typed language.

[Eric Bavier]

On 2015-10-22 09:45, Paul van der Walt wrote:
> Hi Eric,
> 
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> With our conventions, the subject line should be just "gnu: Add Idris"
> 
> Awww, no embellishments allowed *sniff*?  :)
> 
> Fixed though.

:)

> 
>> Try adding "--allow-newer=vector" to #:configure-flags.
> 
> I tried, this option does not exist.

Interesting.  Thanks for trying, I honestly haven't used the flag 
before, but I saw it in the Cabal documentation, so thought I make the 
suggestion.

-- 
`~Eric

Re: [PATCH] gnu: ghc-split: Update dependencies.

[Eric Bavier]

On 2015-10-22 11:16, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> +    (arguments
>>> +     `(#:phases
>>> +       (modify-phases %standard-phases
>>> +         (add-before
>>> +          'configure 'update-cabal
>>> +          ;; the cabal file on hackage is updated, but the tar.gz 
>>> does not
>>> +          ;; include it.
>>> +          (lambda* _
>>> +            (copy-file (assoc-ref %build-inputs 
>>> "ghc-split-cabal-update")
>>> +                       "split.cabal"))))))
>>>      (inputs
>>> -     `(("ghc-quickcheck" ,ghc-quickcheck)))
>>> +     `(("ghc-quickcheck" ,ghc-quickcheck)
>>> +       ("ghc-split-cabal-update"
>>> +        ,(origin
>>> +           (method url-fetch)
>>> +           (uri (string-append
>>> +                 "https://hackage.haskell.org/package/split-"
>>> +                 version "/revision/1.cabal"))
>>> +           (sha256
>>> +            (base32
>>> +             
>>> "1i1h5v1zqvganhzy1wdd9r648yjpir078n0g8051njg82h2f964h"))))))
>>>      (home-page "http://hackage.haskell.org/package/split")
>>>      (synopsis
>>>       "Combinator library for splitting lists")
>> 
>> Similarly to the xmonad cabal patch, perhaps this could be addressed 
>> with
>> 
>>   #:configure-flags '("--allow-newer=base")
> 
> Nope, that option doesn't exist, i've checked.
> 
>> with an appropriate comment.  Otherwise using an origin snippet.
> 
> I've made it into a (substitute* "split.cabal" ..) which simply updates
> the version number of base ("base <4.8" → "base <4.9"), in accordance
> with the change on Hackage.  A comment is provided.

OK

> The patches responding to your latest batch of comments have been 
> pushed
> to the wip-haskell-… branch.

Great! I'll take one last look, then I think we can merge.  WDYT?

-- 
`~Eric

Re: [PATCH] gnu: Add Idris, the dependently-typed language.

[Paul van der Walt]

On 2015-10-22 at 19:02, quoth Eric Bavier:
>>> Try adding "--allow-newer=vector" to #:configure-flags.
>> 
>> I tried, this option does not exist.
>
> Interesting.  Thanks for trying, I honestly haven't used the flag 
> before, but I saw it in the Cabal documentation, so thought I make the 
> suggestion.

Maybe i'm trying wrong.  I tried to add it to #:configure-flags, which
doesn't work.  I also tried:

1) `cabal get something`
2) cd something-…; runhaskell Setup.lhs configure --help

The option isn't mentioned there.

Re: [PATCH] gnu: ghc-split: Update dependencies.

[Paul van der Walt]

On 2015-10-22 at 19:06, quoth Eric Bavier:
> Great! I'll take one last look, then I think we can merge.  WDYT?

FYI, i've pushed the changes to wip-haskell-… now.  Only idris, xmonad,
ghc-split are affected compared to the push you were looking at.

Thanks again, where do i send the bottle of wine? :p

p.