From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul van der Walt Subject: Re: Reviews for wip-haskell-platform-7.10.2-a Date: Thu, 22 Oct 2015 12:27:16 +0200 Message-ID: <87bnbrryez.fsf@denknerd.org> References: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org> Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpD5h-0005Ai-B1 for guix-devel@gnu.org; Thu, 22 Oct 2015 06:27:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpD5d-0003CO-BX for guix-devel@gnu.org; Thu, 22 Oct 2015 06:27:25 -0400 Received: from mx01.mykolab.com ([95.128.36.1]:19203 helo=mx-out03.mykolab.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpD5d-0003CK-4v for guix-devel@gnu.org; Thu, 22 Oct 2015 06:27:21 -0400 In-reply-to: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: ericbavier@openmailbox.org Cc: guix-devel@gnu.org Hey Eric, Thank you for all the review-work! On 2015-10-22 at 05:10, quoth ericbavier@openmailbox.org: > I apologize in advance that so many of these comments pertain to the synopses > and descriptions, but I find that aspect of packaging important, and Ludo was > kind enough to write up the "Synopses and Descriptions" section in guix.info. I guess that's the way it should be. I admit that my descriptions are often shoddy simply because i wasn't sure what the library does. But of course that's no excuse to not follow the style (e.g., sentence fragments, formatting). > Along the way I gave up trying to analyse and comment on inputs vs > propagated-inputs. The builds check out, and we can adjust later if needed. Right. I tried to be conservative with propagated-inputs, but at least they all work... I'm curious to see how the library search path patch will influence things. > In the absense of comments on a patch, assume a "LGTM!" :) Okay, well, i'll deal with all the comments before merging anything. > Thank you, Paul for all the effort, Seems you went to a lot of effort too, thank you for your thorough reviews! On to a more Haskell-friendly Guix! :) Cheers, p.