From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH] gnu: ghc-split: Update dependencies.
Date: Thu, 22 Oct 2015 18:16:06 +0200
Message-ID: <87lhauq3p5.fsf@denknerd.org>
References: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-23-git-send-email-ericbavier@openmailbox.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36887)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpIXL-0006Go-1W
	for guix-devel@gnu.org; Thu, 22 Oct 2015 12:16:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpIXC-00011i-Ng
	for guix-devel@gnu.org; Thu, 22 Oct 2015 12:16:18 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:2403 helo=mx-out02.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpIXC-00010G-HW
	for guix-devel@gnu.org; Thu, 22 Oct 2015 12:16:10 -0400
In-reply-to: <1445503671-30014-23-git-send-email-ericbavier@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org


On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before
>> +          'configure 'update-cabal
>> +          ;; the cabal file on hackage is updated, but the tar.gz doe=
s not
>> +          ;; include it.
>> +          (lambda* _
>> +            (copy-file (assoc-ref %build-inputs "ghc-split-cabal-upda=
te")
>> +                       "split.cabal"))))))
>>      (inputs
>> -     `(("ghc-quickcheck" ,ghc-quickcheck)))
>> +     `(("ghc-quickcheck" ,ghc-quickcheck)
>> +       ("ghc-split-cabal-update"
>> +        ,(origin
>> +           (method url-fetch)
>> +           (uri (string-append
>> +                 "https://hackage.haskell.org/package/split-"
>> +                 version "/revision/1.cabal"))
>> +           (sha256
>> +            (base32
>> +             "1i1h5v1zqvganhzy1wdd9r648yjpir078n0g8051njg82h2f964h"))=
))))
>>      (home-page "http://hackage.haskell.org/package/split")
>>      (synopsis
>>       "Combinator library for splitting lists")
>
> Similarly to the xmonad cabal patch, perhaps this could be addressed wi=
th=20
>
>   #:configure-flags '("--allow-newer=3Dbase")

Nope, that option doesn't exist, i've checked.

> with an appropriate comment.  Otherwise using an origin snippet.

I've made it into a (substitute* "split.cabal" ..) which simply updates
the version number of base ("base <4.8" =E2=86=92 "base <4.9"), in accord=
ance
with the change on Hackage.  A comment is provided.

The patches responding to your latest batch of comments have been pushed
to the wip-haskell-=E2=80=A6 branch.

Thanks again!
p.