From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH] gnu: Add ghc-unix-time.
Date: Thu, 22 Oct 2015 11:57:49 -0500
Message-ID: <1760cc92482181f78bdc0e0cd6fabf5b@openmailbox.org>
References: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-18-git-send-email-ericbavier@openmailbox.org>
	<87oafqq588.fsf@denknerd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51583)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZpJBa-0004Ts-Bk
	for guix-devel@gnu.org; Thu, 22 Oct 2015 12:57:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZpJBW-0007CA-D2
	for guix-devel@gnu.org; Thu, 22 Oct 2015 12:57:54 -0400
Received: from smtp11.openmailbox.org ([62.4.1.45]:40769)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZpJBW-0007C2-7j
	for guix-devel@gnu.org; Thu, 22 Oct 2015 12:57:50 -0400
In-Reply-To: <87oafqq588.fsf@denknerd.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Paul van der Walt <paul@denknerd.org>
Cc: guix-devel@gnu.org

On 2015-10-22 10:43, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> +       #:phases
>>> +       (alist-cons-before
>>> +        'configure 'fix-/bin/sh
>>> +        (lambda _
>>> +          ;; Use `sh', not `/bin/sh'.
>>> +          (substitute* (find-files "." "Makefile|configure")
>>> +            (("/bin/sh")
>>> +             "sh")))
>>> +        %standard-phases)))
>>=20
>> See the ghc-x11 package for a, IMHO, more elegant solution.
>=20
> Ah!  Indeed.
>=20
>> This appears to be a more general issue however.  Any package that=20
>> declares in
>> its *.cabal file "build-type: Configure" is going to need CONFIG_SHELL=
=20
>> and/or
>> SHELL in the environment.  See additionally the proposed ghc-sdl,
>> ghc-sdl-image, ghc-sdl-mixer, and ghc-old-time patches.
>>=20
>> Perhaps we could patch haskell-build-system to export appropriate=20
>> CONFIG_SHELL
>> and SHELL variables if it sees a "configure" file in the top-level=20
>> source
>> directory.  WDYT?  Would you like to send a patch?
>=20
> Right, i see what you mean.  I agree that it'd probably be the right
> thing to do.  However, to expedite the merge of wip-haskell-=E2=80=A6 i=
 propose
> that i take the solution of ghc-x11 and apply it to the relevant
> packages, and then look at fixing the haskell-build-system.  At that
> point we can simply remove the phases introduced to work around this
> deficiency.

OK.

> Do you think that's acceptable, or is it imperative* that we first=20
> solve
> the problem in the build system?

An incremental approach seems reasonable to me in this case, since there=20
are not so many affected packages at this point.

--=20
`~Eric