From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH] gnu: Add ghc-unix-time.
Date: Thu, 22 Oct 2015 17:43:03 +0200
Message-ID: <87oafqq588.fsf@denknerd.org>
References: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-18-git-send-email-ericbavier@openmailbox.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49785)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpI1F-00087k-PQ
	for guix-devel@gnu.org; Thu, 22 Oct 2015 11:43:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpI1D-0004Fk-3W
	for guix-devel@gnu.org; Thu, 22 Oct 2015 11:43:09 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:25093 helo=mx-out03.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpI1C-0004FP-Th
	for guix-devel@gnu.org; Thu, 22 Oct 2015 11:43:07 -0400
In-reply-to: <1445503671-30014-18-git-send-email-ericbavier@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org


On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +       #:phases
>> +       (alist-cons-before
>> +        'configure 'fix-/bin/sh
>> +        (lambda _
>> +          ;; Use `sh', not `/bin/sh'.
>> +          (substitute* (find-files "." "Makefile|configure")
>> +            (("/bin/sh")
>> +             "sh")))
>> +        %standard-phases)))
>
> See the ghc-x11 package for a, IMHO, more elegant solution.

Ah!  Indeed.

> This appears to be a more general issue however.  Any package that decl=
ares in
> its *.cabal file "build-type: Configure" is going to need CONFIG_SHELL =
and/or
> SHELL in the environment.  See additionally the proposed ghc-sdl,
> ghc-sdl-image, ghc-sdl-mixer, and ghc-old-time patches.
>
> Perhaps we could patch haskell-build-system to export appropriate CONFI=
G_SHELL
> and SHELL variables if it sees a "configure" file in the top-level sour=
ce
> directory.  WDYT?  Would you like to send a patch?

Right, i see what you mean.  I agree that it'd probably be the right
thing to do.  However, to expedite the merge of wip-haskell-=E2=80=A6 i p=
ropose
that i take the solution of ghc-x11 and apply it to the relevant
packages, and then look at fixing the haskell-build-system.  At that
point we can simply remove the phases introduced to work around this
deficiency.

Do you think that's acceptable, or is it imperative* that we first solve
the problem in the build system?

I prefer the incremental approach (but i am not an objective outside
observer).

King regards,
p.