From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH] gnu: Add ghc-sdl-mixer.
Date: Thu, 22 Oct 2015 18:04:19 +0200
Message-ID: <87mvvaq48s.fsf@denknerd.org>
References: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-13-git-send-email-ericbavier@openmailbox.org>
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57264)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpIM3-00060r-32
	for guix-devel@gnu.org; Thu, 22 Oct 2015 12:04:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpILz-00044z-TV
	for guix-devel@gnu.org; Thu, 22 Oct 2015 12:04:39 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:16106 helo=mx-out01.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpILz-00043m-Me
	for guix-devel@gnu.org; Thu, 22 Oct 2015 12:04:35 -0400
In-reply-to: <1445503671-30014-13-git-send-email-ericbavier@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org


On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +     `(#:configure-flags
>> +       (let* ((sdl-mixer (assoc-ref %build-inputs "sdl-mixer"))
>> +              (sdl-mixer-lib (string-append sdl-mixer "/lib"))
>> +              (sdl-mixer-include (string-append sdl-mixer "/include/SDL")))
>> +         (list (string-append "--extra-include-dirs=" sdl-mixer-include)
>> +               (string-append "--extra-lib-dirs=" sdl-mixer-lib)))
>
> Is the --extra-lib-dirs argument really necessary?  I think
> haskell-build-system already passes flags for every "lib" directory it
> sees in inputs.

Indeed, that was a troubleshooting remnant.  Thanks!  Removed.

>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-before
>> +          'configure 'fix-/bin/sh
>> +          (lambda _
>> +            ;; Use `sh', not `/bin/sh'.
>> +            (substitute* (find-files "." "Makefile|configure")
>> +              (("/bin/sh") "sh")))))))
>
> See comments about ghc-doctest package.

I assume you mean the more elegant CONFIG_SHELL environment variable
patch?  If so, it's been fixed.

>> +    (propagated-inputs
>> +     `(("sdl-mixer" ,sdl-mixer)
>
> I can understand propagating ghc-sdl, but is it necessary to propagate the
> sdl-mixer library too?

You're right, it's not.  Removed.

>> +       ("ghc-sdl" ,ghc-sdl)))
>> +    (home-page
>> +     "http://hackage.haskell.org/package/SDL-mixer")
>> +    (synopsis "Binding to libSDL_mixer")
>
> "Haskell bindings to libSDL_mixer"

Fixed.

> Similar comments for the ghc-sdl-image patch.

The same changes have been applied to ghc-sdl-image.

Thank you!
p.