From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH] gnu: Add ghc-clock.
Date: Thu, 22 Oct 2015 15:57:53 +0200
Message-ID: <87r3knqa3i.fsf@denknerd.org>
References: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org>
	<1445484334-25558-1-git-send-email-ericbavier@openmailbox.org>
	<1445484334-25558-2-git-send-email-ericbavier@openmailbox.org>
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33760)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpGNU-0005Uv-P3
	for guix-devel@gnu.org; Thu, 22 Oct 2015 09:58:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpGNR-0006mH-Id
	for guix-devel@gnu.org; Thu, 22 Oct 2015 09:58:00 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:22891 helo=mx-out03.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpGNR-0006lu-DB
	for guix-devel@gnu.org; Thu, 22 Oct 2015 09:57:57 -0400
In-reply-to: <1445484334-25558-2-git-send-email-ericbavier@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org

Hi Eric,

On 2015-10-22 at 05:25, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-clock
>> +  (package
>> +    (name "ghc-clock")
>> +    (version "0.5.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "http://hackage.haskell.org/package/"
>> +             "clock/"
>> +             "clock-" version ".tar.gz"))
>> +       (sha256
>> +        (base32 "1ncph7vi2q6ywwc8ysxl1ibw6i5dwfvln88ssfazk8jgpj4iyykw"))))
>> +    (build-system haskell-build-system)
>> +    (arguments `(#:tests? #f)) ;; Testing suite depends on ghc-clock
>
> A trick that's used with some other packages is to define an unexported
> *-bootstrap package.  The ghc-clock-bootstrap package would have tests
> disabled, then the ghc-clock package would inherit from the
> ghc-clock-bootstrap package, declare ghc-clock-bootstrap as an input, and
> enable tests.

I see what you mean, that's a nice idea.  I've reshuffled the order of
the patches around what used to be ghc-clock a bit, turned it into
ghc-clock-bootstrap, and when the needed test packages (which were the
ones depending on ghc-clock) are defined, i add ghc-clock with tests.
This works!  Could you please tell me if i've done it properly?
Everything (including your other comments) has been pushed to the
`wip-haskell-platform-7.10.2-a` branch.

Thank you again for so much constructive criticism, i hope the patches
are finally up to scratch!

Regards,
p.