From mboxrd@z Thu Jan  1 00:00:00 1970
From: ericbavier@openmailbox.org
Subject: Re: [PATCH] gnu: Add ghc-hlint.
Date: Thu, 22 Oct 2015 03:47:32 -0500
Message-ID: <1445503671-30014-4-git-send-email-ericbavier@openmailbox.org>
References: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org>
	<1445503671-30014-1-git-send-email-ericbavier@openmailbox.org>
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51935)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZpG7w-0003jH-El
	for guix-devel@gnu.org; Thu, 22 Oct 2015 09:41:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZpG7s-0007uV-Cq
	for guix-devel@gnu.org; Thu, 22 Oct 2015 09:41:56 -0400
Received: from smtp1.openmailbox.org ([62.4.1.35]:39344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZpG7s-0007u7-7f
	for guix-devel@gnu.org; Thu, 22 Oct 2015 09:41:52 -0400
In-Reply-To: <1445503671-30014-1-git-send-email-ericbavier@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: guix-devel@gnu.org, Paul van der Walt <paul@denknerd.org>

From: Eric Bavier <ericbavier@openmailbox.org>

> * gnu/packages/haskell.scm (ghc-hlint): New variable.
> ---
>  gnu/packages/haskell.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index d56c9e2..c03848f 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -498,6 +498,36 @@ Apart from these standard extensions, it also handles regular patterns as per
>  the HaRP extension as well as HSX-style embedded XML syntax.")
>      (license bsd-3)))
>  
> +(define-public ghc-hlint
> +  (package
> +    (name "ghc-hlint")

I would suggest calling this package simple "hlint", as it is primarily a tool.

`~Eric

> +    (version "1.9.21")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/hlint/hlint-"
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "14v3rdjjlml9nimdk7d5dvir2bw78ai49yylvms9lnzmw29s3546"))))
> +    (build-system haskell-build-system)
> +    (inputs
> +     `(("ghc-cpphs" ,ghc-cpphs)
> +       ("ghc-cmdargs" ,ghc-cmdargs)
> +       ("ghc-haskell-src-exts" ,ghc-haskell-src-exts)
> +       ("ghc-uniplate" ,ghc-uniplate)
> +       ("ghc-ansi-terminal" ,ghc-ansi-terminal)
> +       ("ghc-extra" ,ghc-extra)
> +       ("ghc-hscolour" ,ghc-hscolour)))
> +    (home-page
> +     "http://community.haskell.org/~ndm/hlint/")
> +    (synopsis "Source code suggestions")

"Make suggestions for Haskell source code"

> +    (description
> +     "HLint gives suggestions on how to improve your source code.")

How about, from the home-page:

"HLint reads Haskell programs and suggests changes that hopefully make them
easier to read.  HLint also makes it easy to disable unwanted suggestions, and
to add your own custom suggestions."

> +    (license bsd-3)))
> +
>  (define-public ghc-cpphs
>    (package
>      (name "ghc-cpphs")
> -- 
> 2.5.0
>