Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.

Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.

[Ludovic Courtès]

Hello!

guix-commits@gnu.org skribis:

> commit fa358c557f130f393d8c7400ffa954f75112d09e
> Author: Mathieu Othacehe <m.othacehe@gmail.com>
> Date:   Fri Dec 7 14:03:06 2018 +0900
>
>     build: file-systems: Add luks to %partition-uuid-readers.
>     
>     * gnu/build/file-systems.scm (%partition-uuid-readers): Add luks reader.

Currently ‘find-partition-by-luks-uuid’ is separate from
‘find-partition-by-uuid’.  This is because when looking for a LUKS
mapped device, we know we’re looking specifically for that and nothing
else (this is used in the implementation of ‘luks-device-mapping’);
likewise, when looking for a “real partition”, we know we’re not looking
for a LUKS mapped device.

Thus I think it’s probably best to keep LUKS UUID lookup separate from
file system lookup.

WDYT?  Are there use cases in the installer where this is problematic?

Ludo’.

Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.

[Mathieu Othacehe]

Hey Ludo!

> Thus I think it’s probably best to keep LUKS UUID lookup separate from
> file system lookup.
>
> WDYT?  Are there use cases in the installer where this is problematic?

It makes sense and there are no particular need, so I reverted this
commit and replaced it by 488a0a8d6120ead3499ba7742c5d630ddf936476 which
exports a new read-luks-partition-uuid procedure.

What do you think of this new approach?

Thanks,

Mathieu

Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.

[Ludovic Courtès]

Hello Mathieu!

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

>> Thus I think it’s probably best to keep LUKS UUID lookup separate from
>> file system lookup.
>>
>> WDYT?  Are there use cases in the installer where this is problematic?
>
> It makes sense and there are no particular need, so I reverted this
> commit and replaced it by 488a0a8d6120ead3499ba7742c5d630ddf936476 which
> exports a new read-luks-partition-uuid procedure.
>
> What do you think of this new approach?

It LGTM.  Thank you!

Ludo’.

Re: 02/03: installer: partionment: Add encryption support.

[Ludovic Courtès]

Hi again!  :-)

guix-commits@gnu.org skribis:

> commit 14826f39e3965ddc09c0e7e6e29654e832395af4
> Author: Mathieu Othacehe <m.othacehe@gmail.com>
> Date:   Fri Dec 7 14:04:25 2018 +0900
>
>     installer: partionment: Add encryption support.
>     
>     * gnu/installer.scm (set-installer-path): Add cryptsetup.
>     * gnu/installer/newt/partition.scm (prompt-luks-passwords): New procedure,
>     (run-partioning-page): Add the possibility to set encryption to "On" on a
>     partition and choose a label, add a new partition scheme: "Guided - using the
>     entire disk with encryption", prompt for encryption passwords before
>     proceeding to formating.
>     * gnu/installer/parted.scm (<user-partition>)[crypt-label],
>     [crypt-password]: New fields,
>     (partition-description): add the encryption label,
>     (user-partition-description): add an encryption field,
>     (auto-partition): add two partitioning schemes: entire-crypted-root and
>     entire-crypted-root-home,
>     (call-with-luks-key-file): new procedure,
>     (user-partition-upper-path): new procedure,
>     (luks-format-and-open): new procedure,
>     (luks-close): new procedure,
>     (format-user-partitions): format and open luks partitions before creating
>     file-system.
>     (mount-user-partitions): use the path returned by user-partition-upper-path,
>     (umount-user-partitions): close the luks partitions,
>     (user-partition->file-system): set device field to label for luks partitions
>     and to uuid for the rest,
>     (user-partition->mapped-device): new procedure,
>     (user-partitions->configuration): add mapped-devices field.

Woow, really cool!

Nitpicking on words: s/partitionment/partitioning/,
s/crypted/encrypted/, s/path/file name/ (this one is just a GNU
convention.)

Really awesome to have a UI to deal with this.  I didn’t expect it to
land this quickly, thumbs up!

Ludo’.

Re: 02/03: installer: partionment: Add encryption support.

[Mathieu Othacehe]

Hey!

> Woow, really cool!

Thanks for all the kind words ;)

> Nitpicking on words: s/partitionment/partitioning/,
> s/crypted/encrypted/, s/path/file name/ (this one is just a GNU
> convention.)

Ok I'll do a massive renaming.

>
> Really awesome to have a UI to deal with this.  I didn’t expect it to
> land this quickly, thumbs up!

Best to strike while the iron is hot! However, this encryption part is
still not completely stable, in particular during umounting/closing. I
sent a mail earlier today about that.

I also plan to add a new partitioning scheme: "Use the largest
continuous free space". This way, we will have the same partitioning
schemes as debian installer (which I find quite handy).

Thanks for the feedback!

Mathieu