From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.
Date: Sat, 08 Dec 2018 23:42:04 +0900
Message-ID: <87r2escc77.fsf@gmail.com>
References: <20181208013857.21870.57588@vcs0.savannah.gnu.org>
	<20181208013858.08BD120EA2@vcs0.savannah.gnu.org>
	<87lg509nhm.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51398)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <m.othacehe@gmail.com>) id 1gVdoB-0002C1-SC
	for guix-devel@gnu.org; Sat, 08 Dec 2018 09:42:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <m.othacehe@gmail.com>) id 1gVdo5-0008Q4-Hm
	for guix-devel@gnu.org; Sat, 08 Dec 2018 09:42:19 -0500
In-reply-to: <87lg509nhm.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org


Hey Ludo!

> Thus I think it=E2=80=99s probably best to keep LUKS UUID lookup separate=
 from
> file system lookup.
>
> WDYT?  Are there use cases in the installer where this is problematic?

It makes sense and there are no particular need, so I reverted this
commit and replaced it by 488a0a8d6120ead3499ba7742c5d630ddf936476 which
exports a new read-luks-partition-uuid procedure.

What do you think of this new approach?

Thanks,

Mathieu