From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.
Date: Sat, 08 Dec 2018 14:06:29 +0100
Message-ID: <87lg509nhm.fsf@gnu.org>
References: <20181208013857.21870.57588@vcs0.savannah.gnu.org>
	<20181208013858.08BD120EA2@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33089)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gVcJW-0008Oe-JN
	for guix-devel@gnu.org; Sat, 08 Dec 2018 08:06:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gVcJV-0000dV-Rv
	for guix-devel@gnu.org; Sat, 08 Dec 2018 08:06:34 -0500
In-Reply-To: <20181208013858.08BD120EA2@vcs0.savannah.gnu.org> (guix-commits's
	message of "Fri, 7 Dec 2018 20:38:57 -0500 (EST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org, Mathieu Othacehe <m.othacehe@gmail.com>

Hello!

guix-commits@gnu.org skribis:

> commit fa358c557f130f393d8c7400ffa954f75112d09e
> Author: Mathieu Othacehe <m.othacehe@gmail.com>
> Date:   Fri Dec 7 14:03:06 2018 +0900
>
>     build: file-systems: Add luks to %partition-uuid-readers.
>=20=20=20=20=20
>     * gnu/build/file-systems.scm (%partition-uuid-readers): Add luks read=
er.

Currently =E2=80=98find-partition-by-luks-uuid=E2=80=99 is separate from
=E2=80=98find-partition-by-uuid=E2=80=99.  This is because when looking for=
 a LUKS
mapped device, we know we=E2=80=99re looking specifically for that and noth=
ing
else (this is used in the implementation of =E2=80=98luks-device-mapping=E2=
=80=99);
likewise, when looking for a =E2=80=9Creal partition=E2=80=9D, we know we=
=E2=80=99re not looking
for a LUKS mapped device.

Thus I think it=E2=80=99s probably best to keep LUKS UUID lookup separate f=
rom
file system lookup.

WDYT?  Are there use cases in the installer where this is problematic?

Ludo=E2=80=99.