From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers. Date: Sun, 09 Dec 2018 00:20:43 +0100 Message-ID: <87bm5v61x0.fsf@gnu.org> References: <20181208013857.21870.57588@vcs0.savannah.gnu.org> <20181208013858.08BD120EA2@vcs0.savannah.gnu.org> <87lg509nhm.fsf@gnu.org> <87r2escc77.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVltw-0000Y1-K9 for guix-devel@gnu.org; Sat, 08 Dec 2018 18:20:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVltu-0001ej-SB for guix-devel@gnu.org; Sat, 08 Dec 2018 18:20:48 -0500 In-Reply-To: <87r2escc77.fsf@gmail.com> (Mathieu Othacehe's message of "Sat, 08 Dec 2018 23:42:04 +0900") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mathieu Othacehe Cc: guix-devel@gnu.org Hello Mathieu! Mathieu Othacehe skribis: >> Thus I think it=E2=80=99s probably best to keep LUKS UUID lookup separat= e from >> file system lookup. >> >> WDYT? Are there use cases in the installer where this is problematic? > > It makes sense and there are no particular need, so I reverted this > commit and replaced it by 488a0a8d6120ead3499ba7742c5d630ddf936476 which > exports a new read-luks-partition-uuid procedure. > > What do you think of this new approach? It LGTM. Thank you! Ludo=E2=80=99.