From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.
Date: Sun, 09 Dec 2018 00:20:43 +0100 [thread overview]
Message-ID: <87bm5v61x0.fsf@gnu.org> (raw)
In-Reply-To: <87r2escc77.fsf@gmail.com> (Mathieu Othacehe's message of "Sat, 08 Dec 2018 23:42:04 +0900")
Hello Mathieu!
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
>> Thus I think it’s probably best to keep LUKS UUID lookup separate from
>> file system lookup.
>>
>> WDYT? Are there use cases in the installer where this is problematic?
>
> It makes sense and there are no particular need, so I reverted this
> commit and replaced it by 488a0a8d6120ead3499ba7742c5d630ddf936476 which
> exports a new read-luks-partition-uuid procedure.
>
> What do you think of this new approach?
It LGTM. Thank you!
Ludo’.
next prev parent reply other threads:[~2018-12-08 23:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181208013857.21870.57588@vcs0.savannah.gnu.org>
[not found] ` <20181208013858.08BD120EA2@vcs0.savannah.gnu.org>
2018-12-08 13:06 ` 01/03: build: file-systems: Add luks to %partition-uuid-readers Ludovic Courtès
2018-12-08 14:42 ` Mathieu Othacehe
2018-12-08 23:20 ` Ludovic Courtès [this message]
[not found] ` <20181208013858.38B3820E87@vcs0.savannah.gnu.org>
2018-12-08 13:10 ` 02/03: installer: partionment: Add encryption support Ludovic Courtès
2018-12-08 14:47 ` Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm5v61x0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.