From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 02/03: installer: partionment: Add encryption support.
Date: Sat, 08 Dec 2018 14:10:16 +0100
Message-ID: <87efas9nbb.fsf@gnu.org>
References: <20181208013857.21870.57588@vcs0.savannah.gnu.org>
	<20181208013858.38B3820E87@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33944)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gVcNG-0002jp-Ho
	for guix-devel@gnu.org; Sat, 08 Dec 2018 08:10:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gVcNF-0001wZ-9m
	for guix-devel@gnu.org; Sat, 08 Dec 2018 08:10:26 -0500
In-Reply-To: <20181208013858.38B3820E87@vcs0.savannah.gnu.org> (guix-commits's
	message of "Fri, 7 Dec 2018 20:38:58 -0500 (EST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org, Mathieu Othacehe <m.othacehe@gmail.com>

Hi again!  :-)

guix-commits@gnu.org skribis:

> commit 14826f39e3965ddc09c0e7e6e29654e832395af4
> Author: Mathieu Othacehe <m.othacehe@gmail.com>
> Date:   Fri Dec 7 14:04:25 2018 +0900
>
>     installer: partionment: Add encryption support.
>=20=20=20=20=20
>     * gnu/installer.scm (set-installer-path): Add cryptsetup.
>     * gnu/installer/newt/partition.scm (prompt-luks-passwords): New proce=
dure,
>     (run-partioning-page): Add the possibility to set encryption to "On" =
on a
>     partition and choose a label, add a new partition scheme: "Guided - u=
sing the
>     entire disk with encryption", prompt for encryption passwords before
>     proceeding to formating.
>     * gnu/installer/parted.scm (<user-partition>)[crypt-label],
>     [crypt-password]: New fields,
>     (partition-description): add the encryption label,
>     (user-partition-description): add an encryption field,
>     (auto-partition): add two partitioning schemes: entire-crypted-root a=
nd
>     entire-crypted-root-home,
>     (call-with-luks-key-file): new procedure,
>     (user-partition-upper-path): new procedure,
>     (luks-format-and-open): new procedure,
>     (luks-close): new procedure,
>     (format-user-partitions): format and open luks partitions before crea=
ting
>     file-system.
>     (mount-user-partitions): use the path returned by user-partition-uppe=
r-path,
>     (umount-user-partitions): close the luks partitions,
>     (user-partition->file-system): set device field to label for luks par=
titions
>     and to uuid for the rest,
>     (user-partition->mapped-device): new procedure,
>     (user-partitions->configuration): add mapped-devices field.

Woow, really cool!

Nitpicking on words: s/partitionment/partitioning/,
s/crypted/encrypted/, s/path/file name/ (this one is just a GNU
convention.)

Really awesome to have a UI to deal with this.  I didn=E2=80=99t expect it =
to
land this quickly, thumbs up!

Ludo=E2=80=99.