all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org, Mathieu Othacehe <m.othacehe@gmail.com>
Subject: Re: 01/03: build: file-systems: Add luks to %partition-uuid-readers.
Date: Sat, 08 Dec 2018 14:06:29 +0100	[thread overview]
Message-ID: <87lg509nhm.fsf@gnu.org> (raw)
In-Reply-To: <20181208013858.08BD120EA2@vcs0.savannah.gnu.org> (guix-commits's message of "Fri, 7 Dec 2018 20:38:57 -0500 (EST)")

Hello!

guix-commits@gnu.org skribis:

> commit fa358c557f130f393d8c7400ffa954f75112d09e
> Author: Mathieu Othacehe <m.othacehe@gmail.com>
> Date:   Fri Dec 7 14:03:06 2018 +0900
>
>     build: file-systems: Add luks to %partition-uuid-readers.
>     
>     * gnu/build/file-systems.scm (%partition-uuid-readers): Add luks reader.

Currently ‘find-partition-by-luks-uuid’ is separate from
‘find-partition-by-uuid’.  This is because when looking for a LUKS
mapped device, we know we’re looking specifically for that and nothing
else (this is used in the implementation of ‘luks-device-mapping’);
likewise, when looking for a “real partition”, we know we’re not looking
for a LUKS mapped device.

Thus I think it’s probably best to keep LUKS UUID lookup separate from
file system lookup.

WDYT?  Are there use cases in the installer where this is problematic?

Ludo’.

       reply	other threads:[~2018-12-08 13:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181208013857.21870.57588@vcs0.savannah.gnu.org>
     [not found] ` <20181208013858.08BD120EA2@vcs0.savannah.gnu.org>
2018-12-08 13:06   ` Ludovic Courtès [this message]
2018-12-08 14:42     ` 01/03: build: file-systems: Add luks to %partition-uuid-readers Mathieu Othacehe
2018-12-08 23:20       ` Ludovic Courtès
     [not found] ` <20181208013858.38B3820E87@vcs0.savannah.gnu.org>
2018-12-08 13:10   ` 02/03: installer: partionment: Add encryption support Ludovic Courtès
2018-12-08 14:47     ` Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg509nhm.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=m.othacehe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.