From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Laura Lazzati <laura.lazzati.15@gmail.com>
Cc: "Gábor Boskovits" <boskovits@gmail.com>,
"Ricardo Wurmus" <ricardo.wurmus@mdc-berlin.de>,
33099@debbugs.gnu.org
Subject: [bug#33099] gnu: Add r-aspi.
Date: Tue, 23 Oct 2018 14:53:30 +0200 [thread overview]
Message-ID: <20181023145330.1919e5ef@alma-ubu> (raw)
In-Reply-To: <CAPNLzUNaODPQz-AQCviTtrTPtdvET5c-EsgYeFNR39t8y2zvHw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Tue, 23 Oct 2018 07:16:00 -0300
Laura Lazzati <laura.lazzati.15@gmail.com> wrote:
>
Hi Laura,
I noted three things, sorry this wasn't mentioned before:
1) Your name in the commit is:
Author: laura <laura.lazzati.15@gmail.com> 2018-10-23 06:59:22
Is that intended or do you prefer the full name in capitals (i.e.
"Laura Lazzati", as you have set in your emails)?
If not, set the name correctly with
git config --global user.name "Laura Lazzati"
2) Add a Copyright line for yourself, just copy any other from the file:
;;; Copyright © 2018 Name <email> ...
3) Change the Homepage to use HTTPS.
Otherwise, LGTM ("Looks good to me").
If you decide on 1) then I think a committer could add/correct these for
you instead of endlessly sending out new patches.
Thanks!
Björn
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-10-23 12:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 22:53 [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Laura Lazzati
2018-10-20 8:17 ` Ricardo Wurmus
2018-10-20 8:43 ` Gábor Boskovits
2018-10-20 11:05 ` Gábor Boskovits
2018-10-20 11:48 ` Gábor Boskovits
2018-10-20 20:28 ` Laura Lazzati
2018-10-20 21:35 ` Ricardo Wurmus
2018-10-20 22:23 ` Laura Lazzati
2018-10-21 16:52 ` Laura Lazzati
2018-10-21 21:53 ` Laura Lazzati
2018-10-22 8:46 ` Gábor Boskovits
2018-10-22 12:58 ` Laura Lazzati
2018-10-22 13:39 ` Gábor Boskovits
2018-10-22 22:29 ` Laura Lazzati
2018-10-23 7:06 ` Ricardo Wurmus
2018-10-23 7:39 ` Gábor Boskovits
2018-10-23 10:16 ` [bug#33099] gnu: Add r-aspi Laura Lazzati
2018-10-23 12:53 ` Björn Höfling [this message]
2018-10-23 14:47 ` Laura Lazzati
2018-10-23 18:29 ` Gábor Boskovits
2018-10-23 19:33 ` Björn Höfling
2018-10-23 20:04 ` Laura Lazzati
2018-10-23 20:38 ` Björn Höfling
2018-10-23 21:41 ` bug#33099: " Gábor Boskovits
2018-10-24 1:08 ` [bug#33099] " Laura Lazzati
2018-10-24 2:42 ` Björn Höfling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023145330.1919e5ef@alma-ubu \
--to=bjoern.hoefling@bjoernhoefling.de \
--cc=33099@debbugs.gnu.org \
--cc=boskovits@gmail.com \
--cc=laura.lazzati.15@gmail.com \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.