From: "Gábor Boskovits" <boskovits@gmail.com>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Laura Lazzati <laura.lazzati.15@gmail.com>, 33099@debbugs.gnu.org
Subject: [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file
Date: Sat, 20 Oct 2018 10:43:48 +0200 [thread overview]
Message-ID: <CAE4v=pgM8cvy7jCGPVgewnNJ6PGL2wju=reM_uHXbDPovSPY+Q@mail.gmail.com> (raw)
In-Reply-To: <8736t12frf.fsf@mdc-berlin.de>
Hello Laura,
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> ezt írta (időpont: 2018.
okt. 20., Szo, 10:17):
>
>
> Hi Laura,
>
> congratulations on your first patch to Guix!
>
> What follows are a few comments on minor changes that I would like to
> see before applying the patch to Guix.
>
> > From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00 2001
> > From: laura <laura.lazzati.15@gmail.com>
> > Date: Fri, 19 Oct 2018 19:15:37 -0300
> > Subject: [PATCH] I add r-aspi package appended to cran.scm file
> >
> > ---
> > gnu/packages/cran.scm | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
>
> For commits to Guix, we use a somewhat strict commit message format.
> You can take a look at the commit log to get a feel for it. In the case
> of adding r-aspi to cran.scm this would be the expected commit message:
>
> --8<---------------cut here---------------start------------->8---
> gnu: Add r-aspi.
>
> * gnu/packages/cran.scm (r-aspi): New variable.
> --8<---------------cut here---------------end--------------->8---
>
> The first line is always a concise summary. This is followed by a
> change log listing modified files and how they were modified.
>
You can also see git log for examples.
> > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> > index efcc2dccb..0d8ee6a97 100644
> > --- a/gnu/packages/cran.scm
> > +++ b/gnu/packages/cran.scm
> > @@ -6256,3 +6256,22 @@ a header row or not. The dataset should contain
> > only one independent variable
> > (x) and one dependent variable (y) and can contain a weight for each
> > observation.")
> > (license license:gpl2)))
> > +
> > +(define-public r-aspi
> > + (package
> > + (name "r-aspi")
> > + (version "0.2.0")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (cran-uri "aspi" version))
> > + (sha256
> > + (base32
> > + "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> > + (build-system r-build-system)
> > + (home-page "https://cran.r-project.org/web/packages/aspi/")
> > + (synopsis "Analysis of Symmetry of Parasitic Infections")
>
> Please use lowercase for all words except for the first. CRAN synopses
> are usually in titlecase and the importer can’t automatically figure out
> which words should be converted, so this needs to be done manually.
>
> > + (description
> > + "Tools for the analysis and visualization of bilateral asymmetry in
> > + parasitic infections.")
>
> Please use a complete sentence for the description. The easiest way is
> probably to just prepend “This package provides”.
>
> > + (license license:gpl3)))
>
> I checked the source files and noticed that it’s actually GPL 3 or
> later. Here’s an except from the header of aspi.R:
>
> --8<---------------cut here---------------start------------->8---
> # Analysis of Symmetry of Parasitic Infections is free software: you can #
> # redistribute it and/or modify it under the terms of the GNU General Public #
> # License as published by the Free Software Foundation, either version 3 of #
> # the License, or (at your option) any later version. #
> --8<---------------cut here---------------end--------------->8---
>
> So this really should be “license:gpl3+”.
>
> (I haven’t tried building the package yet.)
>
I will try this and report back.
> I think it’s fine to apply the patch with these minor changes.
>
> --
> Ricardo
Thanks Ricardo for the fast review!
Best regards,
g_bor
next prev parent reply other threads:[~2018-10-20 8:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 22:53 [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Laura Lazzati
2018-10-20 8:17 ` Ricardo Wurmus
2018-10-20 8:43 ` Gábor Boskovits [this message]
2018-10-20 11:05 ` Gábor Boskovits
2018-10-20 11:48 ` Gábor Boskovits
2018-10-20 20:28 ` Laura Lazzati
2018-10-20 21:35 ` Ricardo Wurmus
2018-10-20 22:23 ` Laura Lazzati
2018-10-21 16:52 ` Laura Lazzati
2018-10-21 21:53 ` Laura Lazzati
2018-10-22 8:46 ` Gábor Boskovits
2018-10-22 12:58 ` Laura Lazzati
2018-10-22 13:39 ` Gábor Boskovits
2018-10-22 22:29 ` Laura Lazzati
2018-10-23 7:06 ` Ricardo Wurmus
2018-10-23 7:39 ` Gábor Boskovits
2018-10-23 10:16 ` [bug#33099] gnu: Add r-aspi Laura Lazzati
2018-10-23 12:53 ` Björn Höfling
2018-10-23 14:47 ` Laura Lazzati
2018-10-23 18:29 ` Gábor Boskovits
2018-10-23 19:33 ` Björn Höfling
2018-10-23 20:04 ` Laura Lazzati
2018-10-23 20:38 ` Björn Höfling
2018-10-23 21:41 ` bug#33099: " Gábor Boskovits
2018-10-24 1:08 ` [bug#33099] " Laura Lazzati
2018-10-24 2:42 ` Björn Höfling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE4v=pgM8cvy7jCGPVgewnNJ6PGL2wju=reM_uHXbDPovSPY+Q@mail.gmail.com' \
--to=boskovits@gmail.com \
--cc=33099@debbugs.gnu.org \
--cc=laura.lazzati.15@gmail.com \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.