[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

["Gábor Boskovits" <boskovits@gmail.com>]

Hello Laura,

Almost there!

Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont: 2018.
okt. 21., V, 23:54):
>
> From 3628e4d7d4814777bb748c3f0ebba133814b2b94 Mon Sep 17 00:00:00 2001
> From: laura <laura.lazzati.15@gmail.com>
> Date: Sun, 21 Oct 2018 18:38:58 -0300
> Subject: [PATCH] gnu: Add r-aspi
>
> * gnu/packages/cran.scm (r-aspi): New variable
> ---
>  gnu/packages/cran.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>

Just a bit knitpicking, could you add the periods to the commit message, like:

gnu: Add r-aspi.

* gnu/packages/patches/cran.scm (r-aspi): New variable.


> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index efcc2dccb..c219065e8 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -6256,3 +6256,24 @@ a header row or not.  The dataset should
> contain only one independent variable
>  (x) and one dependent variable (y) and can contain a weight for each
>  observation.")
>      (license license:gpl2)))
> +
> +(define-public r-aspi
> +  (package
> +    (name "r-aspi")
> +    (version "0.2.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (cran-uri "aspi" version))
> +        (sha256
> +          (base32
> +            "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> +    (build-system r-build-system)
> +    (home-page
> +      "http://cran.r-project.org/web/packages/aspi")
> +    (synopsis
> +      "Analysis of symmetry of parasitic infections")
> +    (description
> +      "This package provides tools for the analysis and visualization
> of bilateral
> + asymmetry in parasitic infections.")
> +    (license license:gpl3+)))
> --
> 2.17.1
>

This is fine now.

I still see these strange line breaks in the patch, how does that look on
you side?

Can you apply you own patches using git am?

You can send an updated patch with the corrected commit message,
or I can apply these minor changes and push it.
WDYT?

Best regards,
g_bor