From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEwCE-00045q-1i for guix-patches@gnu.org; Tue, 23 Oct 2018 08:54:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEwCA-00011g-OJ for guix-patches@gnu.org; Tue, 23 Oct 2018 08:54:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:32989) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gEwCA-00011Q-HZ for guix-patches@gnu.org; Tue, 23 Oct 2018 08:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gEwCA-0005lb-CX for guix-patches@gnu.org; Tue, 23 Oct 2018 08:54:02 -0400 Subject: [bug#33099] gnu: Add r-aspi. Resent-Message-ID: Date: Tue, 23 Oct 2018 14:53:30 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20181023145330.1919e5ef@alma-ubu> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/DIyZCEsw_secT4QM=Q5rd_j"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Laura Lazzati Cc: =?UTF-8?Q?G=C3=A1bor?= Boskovits , Ricardo Wurmus , 33099@debbugs.gnu.org --Sig_/DIyZCEsw_secT4QM=Q5rd_j Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 23 Oct 2018 07:16:00 -0300 Laura Lazzati wrote: >=20 Hi Laura, I noted three things, sorry this wasn't mentioned before: 1) Your name in the commit is: Author: laura 2018-10-23 06:59:22 Is that intended or do you prefer the full name in capitals (i.e. "Laura Lazzati", as you have set in your emails)? If not, set the name correctly with=20 git config --global user.name "Laura Lazzati" 2) Add a Copyright line for yourself, just copy any other from the file: ;;; Copyright =C2=A9 2018 Name ... 3) Change the Homepage to use HTTPS. Otherwise, LGTM ("Looks good to me"). If you decide on 1) then I think a committer could add/correct these for you instead of endlessly sending out new patches. Thanks! Bj=C3=B6rn --Sig_/DIyZCEsw_secT4QM=Q5rd_j Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlvPGcsACgkQvyhstlk+X/2CtgCgkPouX05CT6U6t/pZkJqSkLbf DwIAoIOAecRd+10uazL1fCJ/txf1U6av =93AA -----END PGP SIGNATURE----- --Sig_/DIyZCEsw_secT4QM=Q5rd_j--