all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Laura Lazzati <laura.lazzati.15@gmail.com>
Cc: "Gábor Boskovits" <boskovits@gmail.com>, 33099@debbugs.gnu.org
Subject: [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file
Date: Sat, 20 Oct 2018 23:35:39 +0200	[thread overview]
Message-ID: <87zhv81etw.fsf@mdc-berlin.de> (raw)
In-Reply-To: <CAPNLzUM-g_fwcX+xxUJs04B89_Oi-e-AvV-uqdqBkXPm8=JHnQ@mail.gmail.com>


Hi Laura,

> I will apply all the changes and send the new version.
> Shall I send the modified patch to the debbugs mail that is in the CC of
> this mail?

Yes, please.

>> > > > > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
>> > > >
>> > > > Please use lowercase for all words except for the first.  CRAN
>> synopses
>> > > > are usually in titlecase and the importer can’t automatically figure
>> out
>> > > > which words should be converted, so this needs to be done manually.
>>
> Sorry for this, I just copied the comments in cran's website, I'll change
> that.

Did you not use the CRAN importer to generate this package definition?
If you did not then you’re in for a treat as “guix import cran -r” can
*recursively* generate package definitions for packages on CRAN, even if
there are dozens of dependencies.

>> > > > > +    (license license:gpl3)))
>> > > >
>> > > > I checked the source files and noticed that it’s actually GPL 3 or
>> > > > later.  Here’s an except from the header of aspi.R:
>>
> I guess this mistake was because in one of the several times of running
> ./pre-inst-env guix build r-aspi I was getting an error about the gpl
> licence. I will change this too.

If you used the importer this is not your fault.  On CRAN the license is
listed as “GPL-3” which the importer turns into “gpl3”.  Often people
declare the license as just a single version even though their own
license headers permit later versions.

PS: please try to reduce the amount of text you quote in replies.  It’s
best to only leave the relevant parts that you’re replying to :)

--
Ricardo

  reply	other threads:[~2018-10-20 21:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19 22:53 [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Laura Lazzati
2018-10-20  8:17 ` Ricardo Wurmus
2018-10-20  8:43   ` Gábor Boskovits
2018-10-20 11:05     ` Gábor Boskovits
2018-10-20 11:48       ` Gábor Boskovits
2018-10-20 20:28         ` Laura Lazzati
2018-10-20 21:35           ` Ricardo Wurmus [this message]
2018-10-20 22:23             ` Laura Lazzati
2018-10-21 16:52             ` Laura Lazzati
2018-10-21 21:53               ` Laura Lazzati
2018-10-22  8:46                 ` Gábor Boskovits
2018-10-22 12:58                   ` Laura Lazzati
2018-10-22 13:39                     ` Gábor Boskovits
2018-10-22 22:29                       ` Laura Lazzati
2018-10-23  7:06                         ` Ricardo Wurmus
2018-10-23  7:39                           ` Gábor Boskovits
2018-10-23 10:16 ` [bug#33099] gnu: Add r-aspi Laura Lazzati
2018-10-23 12:53   ` Björn Höfling
2018-10-23 14:47     ` Laura Lazzati
2018-10-23 18:29       ` Gábor Boskovits
2018-10-23 19:33         ` Björn Höfling
2018-10-23 20:04           ` Laura Lazzati
2018-10-23 20:38             ` Björn Höfling
2018-10-23 21:41               ` bug#33099: " Gábor Boskovits
2018-10-24  1:08                 ` [bug#33099] " Laura Lazzati
2018-10-24  2:42                   ` Björn Höfling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhv81etw.fsf@mdc-berlin.de \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=33099@debbugs.gnu.org \
    --cc=boskovits@gmail.com \
    --cc=laura.lazzati.15@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.