[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Laura Lazzati <laura.lazzati.15@gmail.com>]

From 3628e4d7d4814777bb748c3f0ebba133814b2b94 Mon Sep 17 00:00:00 2001
From: laura <laura.lazzati.15@gmail.com>
Date: Sun, 21 Oct 2018 18:38:58 -0300
Subject: [PATCH] gnu: Add r-aspi

* gnu/packages/cran.scm (r-aspi): New variable
---
 gnu/packages/cran.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index efcc2dccb..c219065e8 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -6256,3 +6256,24 @@ a header row or not.  The dataset should
contain only one independent variable
 (x) and one dependent variable (y) and can contain a weight for each
 observation.")
     (license license:gpl2)))
+
+(define-public r-aspi
+  (package
+    (name "r-aspi")
+    (version "0.2.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (cran-uri "aspi" version))
+        (sha256
+          (base32
+            "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
+    (build-system r-build-system)
+    (home-page
+      "http://cran.r-project.org/web/packages/aspi")
+    (synopsis
+      "Analysis of symmetry of parasitic infections")
+    (description
+      "This package provides tools for the analysis and visualization
of bilateral
+ asymmetry in parasitic infections.")
+    (license license:gpl3+)))
-- 
2.17.1

On Sun, Oct 21, 2018 at 1:52 PM Laura Lazzati
<laura.lazzati.15@gmail.com> wrote:
>
> Hi!
>
> On Sat, Oct 20, 2018 at 6:35 PM Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>>
>>
>> Hi Laura,
>>
>> > I will apply all the changes and send the new version.
>> > Shall I send the modified patch to the debbugs mail that is in the CC of
>> > this mail?
>>
>> Yes, please.
>>
>> >> > > > > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
>> >> > > >
>> >> > > > Please use lowercase for all words except for the first.  CRAN
>> >> synopses
>> >> > > > are usually in titlecase and the importer can’t automatically figure
>> >> out
>> >> > > > which words should be converted, so this needs to be done manually.
>> >>
>> > Sorry for this, I just copied the comments in cran's website, I'll change
>> > that.
>>
>> Did you not use the CRAN importer to generate this package definition?
>> If you did not then you’re in for a treat as “guix import cran -r” can
>> *recursively* generate package definitions for packages on CRAN, even if
>> there are dozens of dependencies.
>
> I don't understand this part. I ran the commands but complains for few arguments.
> Ran guix import cran --help and read the doc.
> I can apply guix import cran -r p<SOMEPACKAGE> but not to whole r, don't know if that's OK to get the template.
> Or if it was OK running emacs cran.scm to make changes and then I should run guix import cran -r r-aspi to check everything is alright.
> As regards the other changes, I've already applied them to the r-aspi definiton.
>>
>> >> > > > > +    (license license:gpl3)))
>> >> > > >
>> >> > > > I checked the source files and noticed that it’s actually GPL 3 or
>> >> > > > later.  Here’s an except from the header of aspi.R:
>> >>
>> > I guess this mistake was because in one of the several times of running
>> > ./pre-inst-env guix build r-aspi I was getting an error about the gpl
>> > licence. I will change this too.
>>
>> If you used the importer this is not your fault.  On CRAN the license is
>> listed as “GPL-3” which the importer turns into “gpl3”.  Often people
>> declare the license as just a single version even though their own
>> license headers permit later versions.
>>
>> PS: please try to reduce the amount of text you quote in replies.  It’s
>> best to only leave the relevant parts that you’re replying to :)
>>
>> --
>> Ricardo
>
> Regards :)
> Laura