[bug#33099] gnu: Add r-aspi.

[Laura Lazzati <laura.lazzati.15@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

On Tue, Oct 23, 2018 at 9:53 AM Björn Höfling
<bjoern.hoefling@bjoernhoefling.de> wrote:
>
> On Tue, 23 Oct 2018 07:16:00 -0300
> Laura Lazzati <laura.lazzati.15@gmail.com> wrote:
>
> >
>
> Hi Laura,
>
> I noted three things, sorry this wasn't mentioned before:
>
> 1) Your name in the commit is:
>
> Author: laura <laura.lazzati.15@gmail.com>  2018-10-23 06:59:22
>
> Is that intended or do you prefer the full name in capitals (i.e.
> "Laura Lazzati", as you have set in your emails)?
>
> If not, set the name correctly with
>
> git config --global user.name "Laura Lazzati"
It was intentional, but I have already corrected it.
>
> 2) Add a Copyright line for yourself, just copy any other from the file:
>
> ;;; Copyright © 2018 Name <email> ...
>
> 3) Change the Homepage to use HTTPS.
>
> Otherwise, LGTM ("Looks good to me").
>
> If you decide on 1) then I think a committer could add/correct these for
> you instead of endlessly sending out new patches.
>
> Thanks!
>
> Björn
Here goes hope the last version. When approved I have some questions
to ask :), most of them to improve future patches
Regards,
Laura

[-- Attachment #2: 0001-gnu-Add-r-aspi.patch --]
[-- Type: text/x-patch, Size: 1189 bytes --]

From 0c5eba8ab24bb55f888d630eeccda604558cdefe Mon Sep 17 00:00:00 2001
From: Laura Lazzati <laura.lazzati.15@gmail.com>
Date: Tue, 23 Oct 2018 11:38:34 -0300
Subject: [PATCH] gnu: Add r-aspi.

* gnu/packages/cran.scm (r-aspi): New variable.
---
 gnu/packages/cran.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index b9b2f3baa..73680a745 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2018 Charlie Ritter <chewzeirta@posteo.net>
 ;;; Copyright © 2018 Konrad Hinsen <konrad.hinsen@fastmail.net>
 ;;; Copyright © 2018 Mădălin Ionel Patrașcu <madalinionel.patrascu@mdc-berlin.de>
+;;; Copyright © 2018 Laura Lazzati <laura.lazzati.15@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6269,7 +6270,7 @@ observation.")
         (base32 "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
     (build-system r-build-system)
     (home-page
-     "http://cran.r-project.org/web/packages/aspi/")
+     "https://cran.r-project.org/web/packages/aspi/")
     (synopsis
      "Analysis of symmetry of parasitic infections")
     (description
-- 
2.17.1