[PATCH v4 00/16] Add missing dependencies of Spamassassin

[PATCH v4 00/16] Add missing dependencies of Spamassassin

[Danny Milosavljevic]

This patch adds almost all of the dependencies of Spamassassin.

Danny Milosavljevic (16):
  gnu: Add perl-db-file.
  gnu: Add perl-net-dns.
  gnu: Add perl-socket6.
  gnu: Add perl-net-dns-resolver-programmable.
  gnu: Add perl-netaddr-ip.
  gnu: Add perl-net-patricia.
  gnu: Add perl-file-find-object.
  gnu: Add perl-file-find-object-rule.
  gnu: Add perl-test-trailingspace.
  gnu: Add perl-encode-detect.
  gnu: Add perl-net-cidr-lite.
  gnu: Add perl-geo-ip.
  gnu: Add perl-crypt-openssl-rsa.
  gnu: Add perl-crypt-openssl-bignum.
  gnu: Add perl-mail-spf.
  gnu: Add perl-io-socket-inet6.

 gnu/packages/databases.scm  |  32 ++++++
 gnu/packages/mail.scm       |  41 ++++++++
 gnu/packages/networking.scm | 231 ++++++++++++++++++++++++++++++++++++++++++++
 gnu/packages/perl.scm       | 119 +++++++++++++++++++++++
 gnu/packages/tls.scm        |  65 +++++++++++++
 5 files changed, 488 insertions(+)

[PATCH v4 16/16] gnu: Add perl-io-socket-inet6

[Danny Milosavljevic]

gnu: Add perl-io-socket-inet6

* gnu/packages/networking.scm (perl-io-socket-inet6): New variable.
---
 gnu/packages/networking.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 660c025..1ff3be4 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -612,3 +612,36 @@ offline emulation of DNS.")
   (description "The Perl module 'Geo::IP'. 
 It looks up location and network information by IP Address.")
   (license (package-license perl))))
+
+(define-public perl-io-socket-inet6
+ (package
+  (name "perl-io-socket-inet6")
+  (version "2.72")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/S/SH/SHLOMIF/IO-Socket-INET6-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "1fqypz6qa5rw2d5y2zq7f49frwra0aln13nhq5gi514j2zx21q45"))))
+  (build-system perl-build-system)
+  (native-inputs
+    `(("perl-module-build" ,perl-module-build)
+      ("perl-test-pod" ,perl-test-pod)
+      ("perl-test-pod-coverage" ,perl-test-pod-coverage)
+      ;; this doesn't actually work if we do add it.
+      #| ("perl-test-trailingspace" ,perl-test-trailingspace) |#))
+  (inputs `(("perl-socket6" ,perl-socket6)))
+  (arguments `(;; Need network socket API
+               #:tests? #f))
+  (home-page
+    "http://search.cpan.org/dist/IO-Socket-INET6")
+  (synopsis
+    "Perl object interface for AF_INET/AF_INET6 domain sockets")
+  (description "IO::Socket::INET6 is an interface for
+AF_INET/AF_INET6 domain sockets in Perl.")
+  (license (package-license perl))))
+

[PATCH v4 15/16] gnu: Add perl-mail-spf.

[Danny Milosavljevic]

gnu: Add perl-mail-spf.

* gnu/package/mail.scm (perl-mail-spf): New variable.
---
 gnu/packages/mail.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index f7a7623..4169464 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1262,3 +1262,44 @@ synchronizing with a remote address book, @command{vdirsyncer} is recommended.
 Khard can also be used from within the email client @command{mutt}.")
     (home-page "https://github.com/scheibler/khard")
     (license gpl3+)))
+
+(define-public perl-mail-spf
+ (package
+  (name "perl-mail-spf")
+  (version "v2.9.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/J/JM/JMEHNLE/mail-spf/Mail-SPF-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "0qk1rfgfm5drj4iyniiabrasrpqv570vzhgz66lwgb67y4amkjv1"))))
+  (build-system perl-build-system)
+  (native-inputs
+    `(("perl-module-build" ,perl-module-build)
+      ("perl-net-dns-resolver-programmable"
+       ,perl-net-dns-resolver-programmable)))
+  (arguments
+   `(#:phases (modify-phases %standard-phases
+       (add-before 'configure 'modify-Build.PL
+         (lambda* (#:key outputs #:allow-other-keys)
+           (substitute* "Build.PL"
+             (("'/usr/sbin'") (string-append "'"
+                                             (assoc-ref outputs "out")
+                                             "/sbin'")))
+             #t)))))
+  (inputs
+    `(("perl-error" ,perl-error)
+      ("perl-net-dns" ,perl-net-dns)
+      ("perl-netaddr-ip" ,perl-netaddr-ip)
+      ("perl-uri" ,perl-uri)))
+  (home-page
+    "http://search.cpan.org/dist/Mail-SPF")
+  (synopsis
+    "Perl implementation of Sender Policy Framework")
+  (description "Mail::SPF is the Sender Policy Framework implemented
+in Perl.")
+  (license bsd-3)))

Re: [PATCH v4 15/16] gnu: Add perl-mail-spf.

[ng0]

This one lacks the bsd-3 in the licenses in the header of mail.scm. I
fixed this locally for now as I'm new to reviewing 16 dependent patches.

I also got this message while running make on the root of guix checkout:
gnu/packages/tls.scm:547:4: warning: possibly unbound variable `perl-crypt-openssl-random'


Unrelated, but coming up in the dependency graph:
We need to update perl-devel-symdump to 2.17.

A general fyi which I will open as a bug later:
output ‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of
‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’
differs from previous round
@ build-failed
/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv
- 1 output
‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of
‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’
differs from previous round
cannot build derivation
`/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv':
1 dependencies couldn't be built
guix build: error: build failed: build of
`/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv'
failed

gnu/packages/mail.scm needs #:use-modules (gnu packages networking)

and then:

gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri'

Possibly caused by some other file already loading perl.scm module.

I can not comment on further changes, and I'd rather like to have
someone with more perl knowledge review this.

Danny Milosavljevic <dannym@scratchpost.org> writes:

> gnu: Add perl-mail-spf.
>
> * gnu/package/mail.scm (perl-mail-spf): New variable.
> ---
>  gnu/packages/mail.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index f7a7623..4169464 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -1262,3 +1262,44 @@ synchronizing with a remote address book, @command{vdirsyncer} is recommended.
>  Khard can also be used from within the email client @command{mutt}.")
>      (home-page "https://github.com/scheibler/khard")
>      (license gpl3+)))
> +
> +(define-public perl-mail-spf
> + (package
> +  (name "perl-mail-spf")
> +  (version "v2.9.0")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "mirror://cpan/authors/id/J/JM/JMEHNLE/mail-spf/Mail-SPF-"
> +             version
> +             ".tar.gz"))
> +      (sha256
> +        (base32
> +          "0qk1rfgfm5drj4iyniiabrasrpqv570vzhgz66lwgb67y4amkjv1"))))
> +  (build-system perl-build-system)
> +  (native-inputs
> +    `(("perl-module-build" ,perl-module-build)
> +      ("perl-net-dns-resolver-programmable"
> +       ,perl-net-dns-resolver-programmable)))
> +  (arguments
> +   `(#:phases (modify-phases %standard-phases
> +       (add-before 'configure 'modify-Build.PL
> +         (lambda* (#:key outputs #:allow-other-keys)
> +           (substitute* "Build.PL"
> +             (("'/usr/sbin'") (string-append "'"
> +                                             (assoc-ref outputs "out")
> +                                             "/sbin'")))
> +             #t)))))
> +  (inputs
> +    `(("perl-error" ,perl-error)
> +      ("perl-net-dns" ,perl-net-dns)
> +      ("perl-netaddr-ip" ,perl-netaddr-ip)
> +      ("perl-uri" ,perl-uri)))
> +  (home-page
> +    "http://search.cpan.org/dist/Mail-SPF")
> +  (synopsis
> +    "Perl implementation of Sender Policy Framework")
> +  (description "Mail::SPF is the Sender Policy Framework implemented
> +in Perl.")
> +  (license bsd-3)))
>

-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH v4 15/16] gnu: Add perl-mail-spf.

[Danny Milosavljevic]

On Thu, 28 Jul 2016 19:55:39 +0000
ng0 <ng0@we.make.ritual.n0.is> wrote:

> This one lacks the bsd-3 in the licenses in the header of mail.scm. I
> fixed this locally for now as I'm new to reviewing 16 dependent patches.
> 
> I also got this message while running make on the root of guix checkout:
> gnu/packages/tls.scm:547:4: warning: possibly unbound variable `perl-crypt-openssl-random'

Yes, I forgot to include this one (sorry). I'm new to huge patch series like this too...

I can add it in v5.

> gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri'
> 
> Possibly caused by some other file already loading perl.scm module.

No, because perl-uri is in web.scm . 
mail.scm should import web.scm . I forgot that as well.

So - to summarize - the header of mail.scm should also:
- add bsd-3 license
- import web.scm

Re: [PATCH v4 15/16] gnu: Add perl-mail-spf.

[ng0]

ng0 <ng0@we.make.ritual.n0.is> writes:

> This one lacks the bsd-3 in the licenses in the header of mail.scm. I
> fixed this locally for now as I'm new to reviewing 16 dependent patches.
>
> I also got this message while running make on the root of guix checkout:
> gnu/packages/tls.scm:547:4: warning: possibly unbound variable `perl-crypt-openssl-random'
>
>
> Unrelated, but coming up in the dependency graph:
> We need to update perl-devel-symdump to 2.17.

Done.

> A general fyi which I will open as a bug later:
> output ‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of
> ‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’
> differs from previous round
> @ build-failed
> /gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv
> - 1 output
> ‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of
> ‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’
> differs from previous round
> cannot build derivation
> `/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv':
> 1 dependencies couldn't be built
> guix build: error: build failed: build of
> `/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv'
> failed

This needs no bugreport if it was perl-devel-symdump. I just ran
`guix build rounds=2 perl-devel-symdump' and it was okay.

> gnu/packages/mail.scm needs #:use-modules (gnu packages networking)
>
> and then:
>
> gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri'
>
> Possibly caused by some other file already loading perl.scm module.
>
> I can not comment on further changes, and I'd rather like to have
> someone with more perl knowledge review this.
>
> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> gnu: Add perl-mail-spf.
>>
>> * gnu/package/mail.scm (perl-mail-spf): New variable.
>> ---


-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

[PATCH v4 14/16] gnu: Add perl-crypt-openssl-bignum.

[Danny Milosavljevic]

gnu: Add perl-crypt-openssl-bignum.

* gnu/packages/tls.scm (perl-crypt-openssl-bignum, perl-crypt-openssl-arguments): New variables.
---
 gnu/packages/tls.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
index d992c51..fba130b 100644
--- a/gnu/packages/tls.scm
+++ b/gnu/packages/tls.scm
@@ -556,3 +556,39 @@ servers or clients for more complicated applications.")
     "RSA encoding and decoding, using the openSSL libraries")
   (description "Crypt::OpenSSL::RSA does RSA encoding and decoding (using the OpenSSL libraries).")
   (license (package-license perl))))
+
+(define perl-crypt-arguments
+   `(#:phases (modify-phases %standard-phases
+      (add-before 'configure 'patch-Makefile.PL
+        (lambda* (#:key inputs #:allow-other-keys)
+          (substitute* "Makefile.PL"
+            (("'LIBS'.*=>.*") (string-append "'LIBS' => ['-L"
+                                             (assoc-ref inputs "openssl")
+                                             "/lib -lcrypto'],")))
+          #t)))))
+
+(define-public perl-crypt-openssl-bignum
+ (package
+  (name "perl-crypt-openssl-bignum")
+  (version "0.06")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/K/KM/KMX/Crypt-OpenSSL-Bignum-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "05yzrdglrrzp191krf77zrwfkmzrfwrsrx1vyskbj94522lszk67"))))
+  (build-system perl-build-system)
+  (inputs `(("openssl" ,openssl)))
+  (arguments perl-crypt-arguments)
+  (home-page
+    "http://search.cpan.org/dist/Crypt-OpenSSL-Bignum")
+  (synopsis
+    "OpenSSL's multiprecision integer arithmetic in Perl")
+  (description "Crypt::OpenSSL::Bignum provides multiprecision integer
+arithmetic in Perl.")
+  ;; At your option either gpl1+ or the Artistic License
+  (license (package-license perl))))

[PATCH v4 13/16] gnu: Add perl-crypt-openssl-rsa.

[Danny Milosavljevic]

gnu: Add perl-crypt-openssl-rsa.

* gnu/packages/tls.scm (perl-crypt-openssl-rsa): Add variable.
---
 gnu/packages/tls.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
index bdc1d7c..d992c51 100644
--- a/gnu/packages/tls.scm
+++ b/gnu/packages/tls.scm
@@ -527,3 +527,32 @@ finally access to the SSL api of the SSLeay/OpenSSL package so you can write
 servers or clients for more complicated applications.")
     (license (package-license perl))
     (home-page "http://search.cpan.org/~mikem/Net-SSLeay-1.66/")))
+
+(define-public perl-crypt-openssl-rsa
+ (package
+  (name "perl-crypt-openssl-rsa")
+  (version "0.28")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/P/PE/PERLER/Crypt-OpenSSL-RSA-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "1gnpvv09b2gpifwdzc5jnhama3d1a4c39lzj9hcaicsb8rvzjmsk"))))
+  (build-system perl-build-system)
+  (inputs
+    `(("perl-crypt-openssl-bignum"
+       ,perl-crypt-openssl-bignum)
+      ("perl-crypt-openssl-random"
+       ,perl-crypt-openssl-random)
+      ("openssl" ,openssl)))
+  (arguments perl-crypt-arguments)
+  (home-page
+    "http://search.cpan.org/dist/Crypt-OpenSSL-RSA")
+  (synopsis
+    "RSA encoding and decoding, using the openSSL libraries")
+  (description "Crypt::OpenSSL::RSA does RSA encoding and decoding (using the OpenSSL libraries).")
+  (license (package-license perl))))

[PATCH v4 12/16] gnu: Add perl-geo-ip.

[Danny Milosavljevic]

gnu: Add perl-geo-ip.

* gnu/packages/networking.scm (perl-geo-ip): Add variable.
---
 gnu/packages/networking.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 134ad5d..660c025 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -588,3 +588,27 @@ offline emulation of DNS.")
     "Perl extension for merging IPv4 or IPv6 CIDR addresses")
   (description "Net::CIDR::Lite merges IPv4 or IPv6 CIDR addresses.")
   (license license:gpl1+)))
+
+;; TODO: Use the geolite-mirror-simple.pl script from the example
+;; directory to stay current with the databases. How?
+(define-public perl-geo-ip
+ (package
+  (name "perl-geo-ip")
+  (version "1.45")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/M/MA/MAXMIND/Geo-IP-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "0qinkq2br1cjicbgqb5bvrhm73h7f9f4fgc6bjfs5r6x7316bdqf"))))
+  (build-system perl-build-system)
+  (home-page "http://search.cpan.org/dist/Geo-IP")
+  (synopsis
+    "Look up location and network information by IP Address in Perl")
+  (description "The Perl module 'Geo::IP'. 
+It looks up location and network information by IP Address.")
+  (license (package-license perl))))

[PATCH v4 11/16] gnu: Add perl-net-cidr-lite.

[Danny Milosavljevic]

gnu: Add perl-net-cidr-lite.

* gnu/packages/networking.scm (perl-net-cidr-lite): Add variable.
---
 gnu/packages/networking.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 0312fe5..134ad5d 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -566,3 +566,25 @@ offline emulation of DNS.")
   ;; The bindings are licensed under GPL2 or later.
   ;; libpatricia is licensed under 2-clause BSD.
   (license (list license:gpl2+ license:bsd-2))))
+
+(define-public perl-net-cidr-lite
+ (package
+  (name "perl-net-cidr-lite")
+  (version "0.21")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/D/DO/DOUGW/Net-CIDR-Lite-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "14shj73zbqmfjbp0qz1fs9j4p2dpvz5hfkm4qfdjbydflbl2b8fg"))))
+  (build-system perl-build-system)
+  (home-page
+    "http://search.cpan.org/dist/Net-CIDR-Lite")
+  (synopsis
+    "Perl extension for merging IPv4 or IPv6 CIDR addresses")
+  (description "Net::CIDR::Lite merges IPv4 or IPv6 CIDR addresses.")
+  (license license:gpl1+)))

[PATCH v4 10/16] gnu: Add perl-encode-detect.

[Danny Milosavljevic]

gnu: Add perl-encode-detect.

* gnu/packages/perl.scm (perl-encode-detect): Add variable.
---
 gnu/packages/perl.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 944dbf8..2ac70bd 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6724,3 +6724,28 @@ interface to File::Find::Object.")
 in Perl source files.")
   (license x11)))
 
+
+(define-public perl-encode-detect
+ (package
+  (name "perl-encode-detect")
+  (version "1.01")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/J/JG/JGMYERS/Encode-Detect-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "1wdv9ffgs4xyfh5dnh09dqkmmlbf5m1hxgdgb3qy6v6vlwx8jkc3"))))
+  (build-system perl-build-system)
+  (inputs
+    `(("perl-module-build" ,perl-module-build)))
+  (home-page
+    "http://search.cpan.org/dist/Encode-Detect")
+  (synopsis
+    "Perl Encode::Encoding subclass that detects the encoding of data")
+  (description "Encode::Detect detects the encoding of data for Perl.")
+  (license mpl1.1)))
+

[PATCH v4 09/16] gnu: Add perl-test-trailingspace.

[Danny Milosavljevic]

gnu: Add perl-test-trailingspace.

* gnu/packages/perl.scm (perl-test-trailingspace): New variable.
---
 gnu/packages/perl.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 5a867e0..944dbf8 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6689,3 +6689,38 @@ File::Find replacement in Perl.")
 interface to File::Find::Object.")
   (license (package-license perl))))
 
+
+(define-public perl-test-trailingspace
+ (package
+  (name "perl-test-trailingspace")
+  (version "0.0300")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/S/SH/SHLOMIF/Test-TrailingSpace-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "01slmrcjfq38mpdg3hlb7lnnbgsqbn26958y3hzx0zwrif40pigr"))))
+  (build-system perl-build-system)
+  (native-inputs
+    `(("perl-module-build" ,perl-module-build)
+      ("perl-file-find-object" ,perl-file-find-object)
+      ("perl-class-xsaccessor" ,perl-class-xsaccessor)))
+  (inputs
+    `(("perl-file-find-object-rule"
+       ,perl-file-find-object-rule)
+      ("perl-text-glob"
+       ,perl-text-glob)
+      ("perl-number-compare"
+       ,perl-number-compare)))
+  (home-page
+    "http://search.cpan.org/dist/Test-TrailingSpace")
+  (synopsis
+    "test for trailing space in Perl source files.")
+  (description "Test::TrailingSpace tests for trailing spaces
+in Perl source files.")
+  (license x11)))
+

[PATCH v4 08/16] gnu: Add perl-file-find-object-rule.

[Danny Milosavljevic]

gnu: Add perl-file-find-object-rule.

* gnu/packages/perl.scm (perl-file-find-object-rule): New variable.
---
 gnu/packages/perl.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 8fad274..5a867e0 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6658,3 +6658,34 @@ such that being individual extensions would be wasteful.")
 File::Find replacement in Perl.")
   (license artistic2.0)))
 
+
+(define-public perl-file-find-object-rule
+ (package
+  (name "perl-file-find-object-rule")
+  (version "0.0305")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/S/SH/SHLOMIF/File-Find-Object-Rule-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "0hs4n3w99q4ylkhg3qhzcwkxqn7zblfj1zjdgl06ca30afkk4cv6"))))
+  (build-system perl-build-system)
+  (native-inputs
+    `(("perl-module-build" ,perl-module-build)))
+  (inputs
+    `(("perl-class-xsaccessor" ,perl-class-xsaccessor)
+      ("perl-file-find-object" ,perl-file-find-object)
+      ("perl-number-compare" ,perl-number-compare)
+      ("perl-text-glob" ,perl-text-glob)))
+  (home-page
+    "http://search.cpan.org/dist/File-Find-Object-Rule")
+  (synopsis
+    "Alternative interface to File::Find::Object")
+  (description "File::Find::Object::Rule is an alternative Perl
+interface to File::Find::Object.")
+  (license (package-license perl))))
+

[PATCH v4 07/16] gnu: Add perl-file-find-object.

[Danny Milosavljevic]

gnu: Add perl-file-find-object.

* gnu/packages/perl.scm (perl-file-find-object): New variable.
---
 gnu/packages/perl.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index f42abee..8fad274 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -6630,3 +6630,31 @@ such that being individual extensions would be wasteful.")
     (license (package-license perl))))
 
 ;;; END: Core module overrides
+
+(define-public perl-file-find-object
+ (package
+  (name "perl-file-find-object")
+  (version "v0.2.13")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/S/SH/SHLOMIF/File-Find-Object-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "0gf13b76b824s73r5rp00v8xrd6dnb5yi5jjavfc394scqv6ldh4"))))
+  (build-system perl-build-system)
+  (native-inputs
+    `(("perl-module-build" ,perl-module-build)))
+  (inputs
+    `(("perl-class-xsaccessor" ,perl-class-xsaccessor)))
+  (home-page
+    "http://search.cpan.org/dist/File-Find-Object")
+  (synopsis
+    "Object-oriented File::Find replacement in Perl")
+  (description "File::Find::Object is an object-oriented
+File::Find replacement in Perl.")
+  (license artistic2.0)))
+

[PATCH v4 06/16] gnu: Add perl-net-patricia.

[Danny Milosavljevic]

gnu: Add perl-net-patricia.

* gnu/packages/networking.scm (perl-net-patricia): Add variable.
---
 gnu/packages/networking.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index b575fce..0312fe5 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -535,3 +535,34 @@ offline emulation of DNS.")
     "Manages IPv4 and IPv6 addresses and subnets")
   (description "NetAddr::IP manages IPv4 and IPv6 addresses and subsets.")
   (license (package-license perl))))
+
+;; Maybe makes sense to add patricialib dependency (it's bundled right now).
+;; See <http://www.mrtd.net/> for the original package it was extracted from.
+;; However, the site above doesn't actually work on my computer.
+(define-public perl-net-patricia
+ (package
+  (name "perl-net-patricia")
+  (version "1.22")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/G/GR/GRUBER/Net-Patricia-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "0ln5f57vc8388kyh9vhx2infrdzfhbpgyby74h1qsnhwds95m0vh"))))
+  (build-system perl-build-system)
+  (inputs
+    `(("perl-net-cidr-lite" ,perl-net-cidr-lite)
+      ("perl-socket6" ,perl-socket6)))
+  (home-page
+    "http://search.cpan.org/dist/Net-Patricia")
+  (synopsis
+    "Patricia Trie Perl module for fast IP address lookups")
+  (description
+    "Net::Patricia does IP address lookups quickly in Perl.")
+  ;; The bindings are licensed under GPL2 or later.
+  ;; libpatricia is licensed under 2-clause BSD.
+  (license (list license:gpl2+ license:bsd-2))))

[PATCH v4 05/16] gnu: Add perl-netaddr-ip.

[Danny Milosavljevic]

gnu: Add perl-netaddr-ip.

* gnu/packages/networking.scm (perl-netaddr-ip): New variable.
---
 gnu/packages/networking.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index a69ef0e..b575fce 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -502,3 +502,36 @@ emulation of DNS")
   (description "Net::DNS::Resolver::Programmable is a programmable DNS resolver for
 offline emulation of DNS.")
   (license (package-license perl))))
+
+(define-public perl-netaddr-ip
+ (package
+  (name "perl-netaddr-ip")
+  (version "4.079")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/M/MI/MIKER/NetAddr-IP-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "1rx0dinrz9fk9qcg4rwqq5n1dm3xv2arymixpclcv2q2nzgq4npc"))))
+  (build-system perl-build-system)
+  (arguments
+    `(#:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (args `("Makefile.PL"
+                            ,(string-append "PREFIX=" out)
+                            "INSTALLDIRS=site")))
+                   (setenv "CONFIG_SHELL" (which "sh"))
+                   (zero? (apply system* "perl" args))))))))
+  (home-page
+    "http://search.cpan.org/dist/NetAddr-IP")
+  (synopsis
+    "Manages IPv4 and IPv6 addresses and subnets")
+  (description "NetAddr::IP manages IPv4 and IPv6 addresses and subsets.")
+  (license (package-license perl))))

[PATCH v4 04/16] gnu: Add perl-net-dns-resolver-programmable.

[Danny Milosavljevic]

gnu: Add perl-net-dns-resolver-programmable.

* gnu/packages/networking.scm (perl-net-dns-resolver-programmable): New variable.
---
 gnu/packages/networking.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index a6318b2..a69ef0e 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -469,3 +469,36 @@ application stack itself.")
   (description "Socket6 binds the IPv6 related part of the C socket header
 definitions and structure manipulators for Perl.")
   (license license:bsd-3)))
+
+(define-public perl-net-dns-resolver-programmable
+ (package
+  (name "perl-net-dns-resolver-programmable")
+  (version "v0.003")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/J/JM/JMEHNLE/net-dns-resolver-programmable/"
+             "Net-DNS-Resolver-Programmable-" version ".tar.gz"))
+      (sha256
+        (base32
+          "1v3nl2kaj4fs55n1617n53q8sa3mir06898vpy1rq98zjih24h4d"))
+      (patches
+       (list (origin
+               (method url-fetch)
+               (uri "https://rt.cpan.org/Public/Ticket/Attachment/1575108/841078/patch.txt")
+               (sha256
+                 (base32
+                   "027fzq1dryqwhkprz4r32vj78qfdnx1mhjx6piag7p62p5npmdic")))))))
+  (build-system perl-build-system)
+  (native-inputs
+    `(("perl-module-build" ,perl-module-build)))
+  (inputs `(("perl-net-dns" ,perl-net-dns)))
+  (home-page
+    "http://search.cpan.org/dist/Net-DNS-Resolver-Programmable")
+  (synopsis
+    "programmable DNS resolver class for offline
+emulation of DNS")
+  (description "Net::DNS::Resolver::Programmable is a programmable DNS resolver for
+offline emulation of DNS.")
+  (license (package-license perl))))

[PATCH v4 03/16] gnu: Add perl-socket6.

[Danny Milosavljevic]

gnu: Add perl-socket6.

* gnu/packages/networking.scm (perl-socket6): New variable.
---
 gnu/packages/networking.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 0568836..a6318b2 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -436,3 +436,36 @@ application stack itself.")
     "Perl Interface to the Domain Name System")
   (description "Net::DNS is the Perl Interface to the Domain Name System.")
   (license license:x11)))
+
+(define-public perl-socket6
+ (package
+  (name "perl-socket6")
+  (version "0.28")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/U/UM/UMEMOTO/Socket6-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "11j5jzqbzmwlws9zals43ry2f1nw9qy6im7yhn9ck5rikywrmm5z"))))
+  (build-system perl-build-system)
+  (arguments
+   `(#:phases
+     (modify-phases %standard-phases
+         (replace 'configure
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (args `("Makefile.PL"
+                            ,(string-append "PREFIX=" out)
+                            "INSTALLDIRS=site")))
+                   (setenv "CONFIG_SHELL" (which "sh"))
+                   (zero? (apply system* "perl" args))))))))
+  (home-page "http://search.cpan.org/dist/Socket6")
+  (synopsis
+    "IPv6 related part of the C socket.h defines and structure manipulators for Perl")
+  (description "Socket6 binds the IPv6 related part of the C socket header
+definitions and structure manipulators for Perl.")
+  (license license:bsd-3)))

[PATCH v4 02/16] gnu: Add perl-net-dns.

[Danny Milosavljevic]

gnu: Add perl-net-dns.

* gnu/packages/networking.scm (perl-net-dns): New variable.
---
 gnu/packages/networking.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 1ef401f..0568836 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -24,6 +24,7 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages networking)
+  #:use-module (guix build-system perl)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
@@ -412,3 +413,26 @@ HTTP(S) request, and receive the reply headers.  It is somewhat similar to
 by firewalls or when you want to monitor the response time of the actual web
 application stack itself.")
     (license license:gpl2)))        ; with permission to link with OpenSSL
+
+(define-public perl-net-dns
+ (package
+  (name "perl-net-dns")
+  (version "1.06")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/N/NL/NLNETLABS/Net-DNS-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "07m5331132h9xkh1i6jv9d80f571yva27iqa31aq4sm31iw7nn53"))))
+  (build-system perl-build-system)
+  (inputs
+    `(("perl-digest-hmac" ,perl-digest-hmac)))
+  (home-page "http://search.cpan.org/dist/Net-DNS")
+  (synopsis
+    "Perl Interface to the Domain Name System")
+  (description "Net::DNS is the Perl Interface to the Domain Name System.")
+  (license license:x11)))

[PATCH v4 01/16] gnu: Add perl-db_file.

[Danny Milosavljevic]

gnu: Add perl-db_file.

* gnu/packages/databases.scm (perl-db_file): New variable.
---
 gnu/packages/databases.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index f088062..3bdb37b 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1046,3 +1046,35 @@ trees (LSM), for sustained throughput under random insert workloads.")
   (description
     "The DB::File module provides Perl bindings to the Berkeley DB version 1.x.")
   (license (package-license perl))))
+
+(define-public perl-db-file
+ (package
+  (name "perl-db-file")
+  (version "1.838")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (string-append
+             "mirror://cpan/authors/id/P/PM/PMQS/DB_File-"
+             version
+             ".tar.gz"))
+      (sha256
+        (base32
+          "0yp5d5zr8dk9g6xdh7ygi5bq63q7nxvhd58dk2i3ki4nb7yv2yh9"))))
+  (build-system perl-build-system)
+  (inputs `(("bdb" ,bdb)))
+  (native-inputs `(("perl-test-pod" ,perl-test-pod)))
+  (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (add-before
+                   'configure 'modify-config.in
+                   (lambda* (#:key inputs #:allow-other-keys)
+                     (substitute* "config.in"
+                       (("/usr/local/BerkeleyDB") (assoc-ref inputs "bdb")))
+                     #t)))))
+  (home-page "http://search.cpan.org/dist/DB_File")
+  (synopsis
+    "Perl5 access to Berkeley DB version 1.x")
+  (description
+    "DB::File provides Perl bindings to Berkeley DB version 1.x.")
+  (license (package-license perl))))

Re: [PATCH v4 01/16] gnu: Add perl-db_file.

[Ricardo Wurmus]

Hi Danny,

> gnu: Add perl-db_file.
>
> * gnu/packages/databases.scm (perl-db_file): New variable.

Thank you for the patches!

What follows are some stylistic comments.  As you wrote earlier you will
prepare another version of this patch set, so I thought I’d let you know
about these stylistic things.

This may seem like nitpicking, but it makes the code look more similar
to the rest, which makes future maintenance easier.

> +
> +(define-public perl-db-file
> + (package
> +  (name "perl-db-file")
> +  (version "1.838")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "mirror://cpan/authors/id/P/PM/PMQS/DB_File-"
> +             version
> +             ".tar.gz"))

I would move “version” and “".tar.gz"” to the same line.

> +      (sha256
> +        (base32
> +          "0yp5d5zr8dk9g6xdh7ygi5bq63q7nxvhd58dk2i3ki4nb7yv2yh9"))))

The indentation of this expression looks wrong.  If you are using Emacs
you can indent properly with “TAB” and “C-M-q”, which is bound to the
“indent-sexp” command.

> +  (build-system perl-build-system)
> +  (inputs `(("bdb" ,bdb)))
> +  (native-inputs `(("perl-test-pod" ,perl-test-pod)))

I know that this is how the importer writes things, but I think it’s
clearer to break the line after “inputs” and “native-inputs”, so that
the list of inputs follows on the next line.

> +  (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-before
> +                   'configure 'modify-config.in
> +                   (lambda* (#:key inputs #:allow-other-keys)
> +                     (substitute* "config.in"
> +                       (("/usr/local/BerkeleyDB") (assoc-ref inputs "bdb")))
> +                     #t)))))

The value of the “arguments” field is indented much too far.  “TAB”
should fix the indentation in Emacs.

I’d also break the line after “#:phases”.

I’d also move the phase labels “'configure” and “'modify-config.in” onto
the same line as “add-before”.

> +  (home-page "http://search.cpan.org/dist/DB_File")
> +  (synopsis
> +    "Perl5 access to Berkeley DB version 1.x")

Please move these onto the same line.

> +  (description
> +    "DB::File provides Perl bindings to Berkeley DB version 1.x.")

Please check the indentation.  Maybe wrap “DB::File” in “@code{…}”.

> +  (license (package-license perl))))

~~ Ricardo

Re: [PATCH v4 00/16] Add missing dependencies of Spamassassin

[ng0]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> This patch adds almost all of the dependencies of Spamassassin.
>
> Danny Milosavljevic (16):
>   gnu: Add perl-db-file.
>   gnu: Add perl-net-dns.
>   gnu: Add perl-socket6.
>   gnu: Add perl-net-dns-resolver-programmable.
>   gnu: Add perl-netaddr-ip.
>   gnu: Add perl-net-patricia.
>   gnu: Add perl-file-find-object.
>   gnu: Add perl-file-find-object-rule.
>   gnu: Add perl-test-trailingspace.
>   gnu: Add perl-encode-detect.
>   gnu: Add perl-net-cidr-lite.
>   gnu: Add perl-geo-ip.
>   gnu: Add perl-crypt-openssl-rsa.
>   gnu: Add perl-crypt-openssl-bignum.
>   gnu: Add perl-mail-spf.
>   gnu: Add perl-io-socket-inet6.
>
>  gnu/packages/databases.scm  |  32 ++++++
>  gnu/packages/mail.scm       |  41 ++++++++
>  gnu/packages/networking.scm | 231 ++++++++++++++++++++++++++++++++++++++++++++
>  gnu/packages/perl.scm       | 119 +++++++++++++++++++++++
>  gnu/packages/tls.scm        |  65 +++++++++++++
>  5 files changed, 488 insertions(+)
>

Should I review v3 or v4? It would be easier if the patches would have
references in one single thread, but I can work this way too. If this
makes all the packages before obsolete I'll mark them as such and review
only these versions.
-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH v4 00/16] Add missing dependencies of Spamassassin

[Danny Milosavljevic]

> Should I review v3 or v4? 

v4. I made a mistake in v3 - that's why it has a hole in the series - I didn't send it.

> It would be easier if the patches would have references in one single thread, but I can work this way too. 

Huh, they should be a tree with the cover letter at the root now.

>If this
> makes all the packages before obsolete I'll mark them as such and review
> only these versions.

It does make all the "perl" packages (only perl) by me from before obsolete.

Re: [PATCH v4 00/16] Add missing dependencies of Spamassassin

[ng0]

Danny Milosavljevic <dannym@scratchpost.org> writes:

>> Should I review v3 or v4? 
>
> v4. I made a mistake in v3 - that's why it has a hole in the series - I didn't send it.
>
>> It would be easier if the patches would have references in one single thread, but I can work this way too. 
>
> Huh, they should be a tree with the cover letter at the root now.

Sorry, my mistake this should have been more precise:

I meant to say:
It can lead to confusion when there are several threads with different
versions of the patches, including singles ones, not bundled, and
bundled ones.

I will start looking into these patches now, thanks.

>>If this
>> makes all the packages before obsolete I'll mark them as such and review
>> only these versions.
>
> It does make all the "perl" packages (only perl) by me from before obsolete.

-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH v4 00/16] Add missing dependencies of Spamassassin

[ng0]

Update: I am not sure how to handle more than 1 inlined patch with my
new email application.  There will be some delay… I extracted them
manually and introduced formating errors this way, so there has to be
something notmuch or emacs can do.
-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH v4 00/16] Add missing dependencies of Spamassassin

[Danny Milosavljevic]

On Thu, 28 Jul 2016 17:20:22 +0000
ng0 <ng0@we.make.ritual.n0.is> wrote:

> Update: I am not sure how to handle more than 1 inlined patch with my
> new email application.  There will be some delay… I extracted them
> manually and introduced formating errors this way, so there has to be
> something notmuch or emacs can do.

Yeah, Ludo asked me to attach (not inline) patches as well. I'm trying to but I'm still trying to find out what incantation I have to use.

Right now I'm at 

  git config --global format.attach <boundary>

.

No idea what value <boundary> should have. The manpage of git-format-patch makes it sound as if it's optional. But how do I specify I want to attach but not specify a value using git config?