From: Danny Milosavljevic <dannym@scratchpost.org>
To: ng0 <ng0@we.make.ritual.n0.is>, guix-devel@gnu.org
Subject: Re: [PATCH v4 15/16] gnu: Add perl-mail-spf.
Date: Thu, 28 Jul 2016 22:54:30 +0200 [thread overview]
Message-ID: <20160728225430.34b65e33@scratchpost.org> (raw)
In-Reply-To: <87fuqtbkqs.fsf@we.make.ritual.n0.is>
On Thu, 28 Jul 2016 19:55:39 +0000
ng0 <ng0@we.make.ritual.n0.is> wrote:
> This one lacks the bsd-3 in the licenses in the header of mail.scm. I
> fixed this locally for now as I'm new to reviewing 16 dependent patches.
>
> I also got this message while running make on the root of guix checkout:
> gnu/packages/tls.scm:547:4: warning: possibly unbound variable `perl-crypt-openssl-random'
Yes, I forgot to include this one (sorry). I'm new to huge patch series like this too...
I can add it in v5.
> gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri'
>
> Possibly caused by some other file already loading perl.scm module.
No, because perl-uri is in web.scm .
mail.scm should import web.scm . I forgot that as well.
So - to summarize - the header of mail.scm should also:
- add bsd-3 license
- import web.scm
next prev parent reply other threads:[~2016-07-28 20:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 11:19 [PATCH v4 00/16] Add missing dependencies of Spamassassin Danny Milosavljevic
2016-07-28 11:21 ` [PATCH v4 16/16] gnu: Add perl-io-socket-inet6 Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 15/16] gnu: Add perl-mail-spf Danny Milosavljevic
2016-07-28 19:55 ` ng0
2016-07-28 20:54 ` Danny Milosavljevic [this message]
2016-07-29 11:03 ` ng0
2016-07-28 11:22 ` [PATCH v4 14/16] gnu: Add perl-crypt-openssl-bignum Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 13/16] gnu: Add perl-crypt-openssl-rsa Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 12/16] gnu: Add perl-geo-ip Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 11/16] gnu: Add perl-net-cidr-lite Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 10/16] gnu: Add perl-encode-detect Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 09/16] gnu: Add perl-test-trailingspace Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 08/16] gnu: Add perl-file-find-object-rule Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 07/16] gnu: Add perl-file-find-object Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 06/16] gnu: Add perl-net-patricia Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 05/16] gnu: Add perl-netaddr-ip Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 04/16] gnu: Add perl-net-dns-resolver-programmable Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 03/16] gnu: Add perl-socket6 Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 02/16] gnu: Add perl-net-dns Danny Milosavljevic
2016-07-28 11:23 ` [PATCH v4 01/16] gnu: Add perl-db_file Danny Milosavljevic
2016-07-29 5:02 ` Ricardo Wurmus
2016-07-28 11:55 ` [PATCH v4 00/16] Add missing dependencies of Spamassassin ng0
2016-07-28 12:02 ` Danny Milosavljevic
2016-07-28 15:53 ` ng0
2016-07-28 17:20 ` ng0
2016-07-28 18:36 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728225430.34b65e33@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.