From: Ricardo Wurmus <rekado@elephly.net>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v4 01/16] gnu: Add perl-db_file.
Date: Fri, 29 Jul 2016 07:02:58 +0200 [thread overview]
Message-ID: <87k2g5f33x.fsf@elephly.net> (raw)
In-Reply-To: <20160728132302.3b8efe37@scratchpost.org>
Hi Danny,
> gnu: Add perl-db_file.
>
> * gnu/packages/databases.scm (perl-db_file): New variable.
Thank you for the patches!
What follows are some stylistic comments. As you wrote earlier you will
prepare another version of this patch set, so I thought I’d let you know
about these stylistic things.
This may seem like nitpicking, but it makes the code look more similar
to the rest, which makes future maintenance easier.
> +
> +(define-public perl-db-file
> + (package
> + (name "perl-db-file")
> + (version "1.838")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://cpan/authors/id/P/PM/PMQS/DB_File-"
> + version
> + ".tar.gz"))
I would move “version” and “".tar.gz"” to the same line.
> + (sha256
> + (base32
> + "0yp5d5zr8dk9g6xdh7ygi5bq63q7nxvhd58dk2i3ki4nb7yv2yh9"))))
The indentation of this expression looks wrong. If you are using Emacs
you can indent properly with “TAB” and “C-M-q”, which is bound to the
“indent-sexp” command.
> + (build-system perl-build-system)
> + (inputs `(("bdb" ,bdb)))
> + (native-inputs `(("perl-test-pod" ,perl-test-pod)))
I know that this is how the importer writes things, but I think it’s
clearer to break the line after “inputs” and “native-inputs”, so that
the list of inputs follows on the next line.
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-before
> + 'configure 'modify-config.in
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "config.in"
> + (("/usr/local/BerkeleyDB") (assoc-ref inputs "bdb")))
> + #t)))))
The value of the “arguments” field is indented much too far. “TAB”
should fix the indentation in Emacs.
I’d also break the line after “#:phases”.
I’d also move the phase labels “'configure” and “'modify-config.in” onto
the same line as “add-before”.
> + (home-page "http://search.cpan.org/dist/DB_File")
> + (synopsis
> + "Perl5 access to Berkeley DB version 1.x")
Please move these onto the same line.
> + (description
> + "DB::File provides Perl bindings to Berkeley DB version 1.x.")
Please check the indentation. Maybe wrap “DB::File” in “@code{…}”.
> + (license (package-license perl))))
~~ Ricardo
next prev parent reply other threads:[~2016-07-29 5:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 11:19 [PATCH v4 00/16] Add missing dependencies of Spamassassin Danny Milosavljevic
2016-07-28 11:21 ` [PATCH v4 16/16] gnu: Add perl-io-socket-inet6 Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 15/16] gnu: Add perl-mail-spf Danny Milosavljevic
2016-07-28 19:55 ` ng0
2016-07-28 20:54 ` Danny Milosavljevic
2016-07-29 11:03 ` ng0
2016-07-28 11:22 ` [PATCH v4 14/16] gnu: Add perl-crypt-openssl-bignum Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 13/16] gnu: Add perl-crypt-openssl-rsa Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 12/16] gnu: Add perl-geo-ip Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 11/16] gnu: Add perl-net-cidr-lite Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 10/16] gnu: Add perl-encode-detect Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 09/16] gnu: Add perl-test-trailingspace Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 08/16] gnu: Add perl-file-find-object-rule Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 07/16] gnu: Add perl-file-find-object Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 06/16] gnu: Add perl-net-patricia Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 05/16] gnu: Add perl-netaddr-ip Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 04/16] gnu: Add perl-net-dns-resolver-programmable Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 03/16] gnu: Add perl-socket6 Danny Milosavljevic
2016-07-28 11:22 ` [PATCH v4 02/16] gnu: Add perl-net-dns Danny Milosavljevic
2016-07-28 11:23 ` [PATCH v4 01/16] gnu: Add perl-db_file Danny Milosavljevic
2016-07-29 5:02 ` Ricardo Wurmus [this message]
2016-07-28 11:55 ` [PATCH v4 00/16] Add missing dependencies of Spamassassin ng0
2016-07-28 12:02 ` Danny Milosavljevic
2016-07-28 15:53 ` ng0
2016-07-28 17:20 ` ng0
2016-07-28 18:36 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2g5f33x.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.