From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH v4 15/16] gnu: Add perl-mail-spf.
Date: Thu, 28 Jul 2016 22:54:30 +0200
Message-ID: <20160728225430.34b65e33@scratchpost.org>
References: <20160728132203.130a99da@scratchpost.org>
	<87fuqtbkqs.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bSsKD-0007bS-WE
	for guix-devel@gnu.org; Thu, 28 Jul 2016 16:54:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bSsK9-0002rp-P8
	for guix-devel@gnu.org; Thu, 28 Jul 2016 16:54:36 -0400
Received: from dd1012.kasserver.com ([85.13.128.8]:53270)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bSsK9-0002re-IJ
	for guix-devel@gnu.org; Thu, 28 Jul 2016 16:54:33 -0400
In-Reply-To: <87fuqtbkqs.fsf@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>, guix-devel@gnu.org

On Thu, 28 Jul 2016 19:55:39 +0000
ng0 <ng0@we.make.ritual.n0.is> wrote:

> This one lacks the bsd-3 in the licenses in the header of mail.scm. I
> fixed this locally for now as I'm new to reviewing 16 dependent patches.
> 
> I also got this message while running make on the root of guix checkout:
> gnu/packages/tls.scm:547:4: warning: possibly unbound variable `perl-crypt-openssl-random'

Yes, I forgot to include this one (sorry). I'm new to huge patch series like this too...

I can add it in v5.

> gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri'
> 
> Possibly caused by some other file already loading perl.scm module.

No, because perl-uri is in web.scm . 
mail.scm should import web.scm . I forgot that as well.

So - to summarize - the header of mail.scm should also:
- add bsd-3 license
- import web.scm