From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH v4 15/16] gnu: Add perl-mail-spf. Date: Thu, 28 Jul 2016 19:55:39 +0000 Message-ID: <87fuqtbkqs.fsf@we.make.ritual.n0.is> References: <20160728132203.130a99da@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSrPH-00036C-QF for guix-devel@gnu.org; Thu, 28 Jul 2016 15:55:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSrPG-0004qp-Bl for guix-devel@gnu.org; Thu, 28 Jul 2016 15:55:47 -0400 Received: from mithlond.libertad.in-berlin.de ([2001:67c:1400:2490::1]:57706 helo=beleriand.n0.is) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSrPG-0004qI-1Z for guix-devel@gnu.org; Thu, 28 Jul 2016 15:55:46 -0400 Received: by beleriand.n0.is (OpenSMTPD) with ESMTPSA id 9b80f16d TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO for ; Thu, 28 Jul 2016 19:55:42 +0000 (UTC) In-Reply-To: <20160728132203.130a99da@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org This one lacks the bsd-3 in the licenses in the header of mail.scm. I fixed this locally for now as I'm new to reviewing 16 dependent patches. I also got this message while running make on the root of guix checkout: gnu/packages/tls.scm:547:4: warning: possibly unbound variable `perl-crypt-openssl-random' Unrelated, but coming up in the dependency graph: We need to update perl-devel-symdump to 2.17. A general fyi which I will open as a bug later: output ‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of ‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’ differs from previous round @ build-failed /gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv - 1 output ‘/gnu/store/afbyqf4xqp09mc16y2a7yvfnlkdnrpjz-perl-devel-symdump-2.14’ of ‘/gnu/store/pjlp1zl2iiqiy4n28drxskh81yb39qrs-perl-devel-symdump-2.14.drv’ differs from previous round cannot build derivation `/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv': 1 dependencies couldn't be built guix build: error: build failed: build of `/gnu/store/bmzccfn9605nigh44gmcd67vjfm5yz2v-perl-io-socket-inet6-2.72.drv' failed gnu/packages/mail.scm needs #:use-modules (gnu packages networking) and then: gnu/packages/mail.scm:1296:4: warning: possibly unbound variable `perl-uri' Possibly caused by some other file already loading perl.scm module. I can not comment on further changes, and I'd rather like to have someone with more perl knowledge review this. Danny Milosavljevic writes: > gnu: Add perl-mail-spf. > > * gnu/package/mail.scm (perl-mail-spf): New variable. > --- > gnu/packages/mail.scm | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm > index f7a7623..4169464 100644 > --- a/gnu/packages/mail.scm > +++ b/gnu/packages/mail.scm > @@ -1262,3 +1262,44 @@ synchronizing with a remote address book, @command{vdirsyncer} is recommended. > Khard can also be used from within the email client @command{mutt}.") > (home-page "https://github.com/scheibler/khard") > (license gpl3+))) > + > +(define-public perl-mail-spf > + (package > + (name "perl-mail-spf") > + (version "v2.9.0") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "mirror://cpan/authors/id/J/JM/JMEHNLE/mail-spf/Mail-SPF-" > + version > + ".tar.gz")) > + (sha256 > + (base32 > + "0qk1rfgfm5drj4iyniiabrasrpqv570vzhgz66lwgb67y4amkjv1")))) > + (build-system perl-build-system) > + (native-inputs > + `(("perl-module-build" ,perl-module-build) > + ("perl-net-dns-resolver-programmable" > + ,perl-net-dns-resolver-programmable))) > + (arguments > + `(#:phases (modify-phases %standard-phases > + (add-before 'configure 'modify-Build.PL > + (lambda* (#:key outputs #:allow-other-keys) > + (substitute* "Build.PL" > + (("'/usr/sbin'") (string-append "'" > + (assoc-ref outputs "out") > + "/sbin'"))) > + #t))))) > + (inputs > + `(("perl-error" ,perl-error) > + ("perl-net-dns" ,perl-net-dns) > + ("perl-netaddr-ip" ,perl-netaddr-ip) > + ("perl-uri" ,perl-uri))) > + (home-page > + "http://search.cpan.org/dist/Mail-SPF") > + (synopsis > + "Perl implementation of Sender Policy Framework") > + (description "Mail::SPF is the Sender Policy Framework implemented > +in Perl.") > + (license bsd-3))) > -- ♥Ⓐ ng0 Current Keys: https://we.make.ritual.n0.is/ng0.txt For non-prism friendly talk find me on http://www.psyced.org