[NonGNU ELPA] New package: flymake-guile

[NonGNU ELPA] New package: flymake-guile

[Distopico]

[-- Attachment #1.1: Type: text/plain, Size: 478 bytes --]

Hi all!

I'm the author of a new package `flymake-guile` and I
would like to include it in Nongnu ELPA.

Here the repo: https://framagit.org/flymake-backends/flymake-guile

--8<---------------cut here---------------start------------->8---
;;; Commentary:

;; Flymake backend for GNU Guile using `guild' compile.
;;
;; Usage:
;;   (require 'flymake-guile)
;;   (add-hook 'scheme-mode-hook 'flymake-guile)
--8<---------------cut here---------------end--------------->8---

Best!


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-elpa-packages-flymake-quickdef-New-package.patch --]
[-- Type: text/x-patch, Size: 821 bytes --]

From c6a3d53bb56d3e0d8638fe069a49fc4d364e0e84 Mon Sep 17 00:00:00 2001
From: Distopico <distopico@riseup.net>
Date: Wed, 30 Aug 2023 20:41:28 -0500
Subject: [PATCH 1/2] * elpa-packages (flymake-quickdef): New package

---
 elpa-packages | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 0d9da00c84..93e7c38600 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -220,6 +220,9 @@
   :ignored-files (".travis.yml" "Cask" "LICENSE" "tests" "Makefile"
                   "flx.el" "misc/flx-helm-demo.el" "misc/flx-test-list.el"))
 
+ (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
+  :readme "README.md")
+
  (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
   :ignored-files ("COPYING.txt"))
 
-- 
2.41.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: 0002-elpa-packages-flymake-guile-New-package.patch --]
[-- Type: text/x-patch, Size: 776 bytes --]

From 50674f93285692a4e7ca1c9b22d13bbffa89eabe Mon Sep 17 00:00:00 2001
From: Distopico <distopico@riseup.net>
Date: Wed, 30 Aug 2023 20:53:27 -0500
Subject: [PATCH 2/2] * elpa-packages (flymake-guile): New package

---
 elpa-packages | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 93e7c38600..b07894fe1a 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -223,6 +223,9 @@
  (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
   :readme "README.md")
 
+ (flymake-guile		:url "https://framagit.org/flymake-backends/flymake-guile.git"
+  :readme "README.md")
+
  (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
   :ignored-files ("COPYING.txt"))
 
-- 
2.41.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 515 bytes --]

Re: [NonGNU ELPA] New package: flymake-guile

[Stefan Kangas]

Hi!

Distopico <distopico@riseup.net> writes:

> Hi all!
>
> I'm the author of a new package `flymake-guile` and I
> would like to include it in Nongnu ELPA.
>
> Here the repo: https://framagit.org/flymake-backends/flymake-guile

Thanks.

Since you're the only author, how would you feel about adding it to
GNU ELPA instead?

One important difference between GNU ELPA and NonGNU ELPA is that any
significant contribution (typically more than 15 lines) would need its
copyright assigned to the FSF.  See:
https://www.gnu.org/licenses/why-assign.html

On the other hand, GNU ELPA is more tightly integrated with the rest of Emacs.

> --8<---------------cut here---------------start------------->8---
> ;;; Commentary:
>
> ;; Flymake backend for GNU Guile using `guild' compile.
> ;;
> ;; Usage:
> ;;   (require 'flymake-guile)

I don't think there is any need to require it, as the `flymake-guile'
function is autoloaded.  So the `require' will just slow down starting
Emacs, if a user adds it to their init file.

> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)

You could also consider including this form:

(use-package flymake-guile
   :ensure t
   :hook (scheme-mode-hook . flymake-guile))

Re: [NonGNU ELPA] New package: flymake-guile

[Distopico]

[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]


On 2023-08-31, Stefan Kangas <stefankangas@gmail.com> wrote:

> Hi!
>
> Distopico <distopico@riseup.net> writes:
>
>> Hi all!
>>
>> I'm the author of a new package `flymake-guile` and I
>> would like to include it in Nongnu ELPA.
>>
>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>
> Thanks.
>
> Since you're the only author, how would you feel about adding it to
> GNU ELPA instead?
>
> One important difference between GNU ELPA and NonGNU ELPA is that any
> significant contribution (typically more than 15 lines) would need its
> copyright assigned to the FSF.  See:
> https://www.gnu.org/licenses/why-assign.html
>
> On the other hand, GNU ELPA is more tightly integrated with the rest of Emacs.
>

Thank you for your feedback, for now I'm fine having it in NonGNU ELPA


>> --8<---------------cut here---------------start------------->8---
>> ;;; Commentary:
>>
>> ;; Flymake backend for GNU Guile using `guild' compile.
>> ;;
>> ;; Usage:
>> ;;   (require 'flymake-guile)
>
> I don't think there is any need to require it, as the `flymake-guile'
> function is autoloaded.  So the `require' will just slow down starting
> Emacs, if a user adds it to their init file.
>
>> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
>
> You could also consider including this form:
>
> (use-package flymake-guile
>    :ensure t
>    :hook (scheme-mode-hook . flymake-guile))
I apply that recommendation, not you can see the change in the repo

thank you.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 515 bytes --]

Re: [NonGNU ELPA] New package: flymake-guile

[Philip Kaludercic]

Distopico <distopico@riseup.net> writes:

> Hi all!
>
> I'm the author of a new package `flymake-guile` and I
> would like to include it in Nongnu ELPA.

Just to be sure, you are sure you don't want to include your package in
GNU ELPA?

> Here the repo: https://framagit.org/flymake-backends/flymake-guile

I am not familiar with the "flymake-quickdef" package, but it doesn't
seem to be much shorter than just defining a regular flymake backend.
As there have been some discussions wrt providing a kind of DSL for
Flymake backends, I am not sure if adding flymake-quickdef would be that
constructive at this point.  Would you consider updating your package to
not use the dependency?  You can check out other flymake-... modes in
GNU and NonGNU ELPA for inspiration.

> ;;; Commentary:
>
> ;; Flymake backend for GNU Guile using `guild' compile.
> ;;
> ;; Usage:
> ;;   (require 'flymake-guile)
> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)

It would probably make sense to autoload the `flymake-guile' function,
so that it is not necessary to require it in a user configuration.

> Best!
>
> From c6a3d53bb56d3e0d8638fe069a49fc4d364e0e84 Mon Sep 17 00:00:00 2001
> From: Distopico <distopico@riseup.net>
> Date: Wed, 30 Aug 2023 20:41:28 -0500
> Subject: [PATCH 1/2] * elpa-packages (flymake-quickdef): New package
>
> ---
>  elpa-packages | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index 0d9da00c84..93e7c38600 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -220,6 +220,9 @@
>    :ignored-files (".travis.yml" "Cask" "LICENSE" "tests" "Makefile"
>                    "flx.el" "misc/flx-helm-demo.el" "misc/flx-test-list.el"))
>  
> + (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
> +  :readme "README.md")
> +
>   (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
>    :ignored-files ("COPYING.txt"))
>  
> -- 
> 2.41.0
>
>
> From 50674f93285692a4e7ca1c9b22d13bbffa89eabe Mon Sep 17 00:00:00 2001
> From: Distopico <distopico@riseup.net>
> Date: Wed, 30 Aug 2023 20:53:27 -0500
> Subject: [PATCH 2/2] * elpa-packages (flymake-guile): New package
>
> ---
>  elpa-packages | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index 93e7c38600..b07894fe1a 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -223,6 +223,9 @@
>   (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
>    :readme "README.md")
>  
> + (flymake-guile		:url "https://framagit.org/flymake-backends/flymake-guile.git"
> +  :readme "README.md")

Are you sure the README.md is right thing to include here?  It includes
installation instructions, that are usually redundant when you install
the package using package.el.  I would recommend writing out the
"Commentary" section in flymake-guile.el with a brief description of
what package and its entry points.

Also, the package appears to include files that needn't be distributed
in the release tarball, such as .envrc and guix.scm.  It would be nice
if you could track these and future files of this type in a .elpaignore
file, to instruct the build server that they should be removed before
packaging.

> > +
>   (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
>    :ignored-files ("COPYING.txt"))

Re: [NonGNU ELPA] New package: flymake-guile

[Distopico]

[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]


On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:

> Distopico <distopico@riseup.net> writes:
>
>> Hi all!
>>
>> I'm the author of a new package `flymake-guile` and I
>> would like to include it in Nongnu ELPA.
>
> Just to be sure, you are sure you don't want to include your package in
> GNU ELPA?
>
>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>
> I am not familiar with the "flymake-quickdef" package, but it doesn't
> seem to be much shorter than just defining a regular flymake backend.
> As there have been some discussions wrt providing a kind of DSL for
> Flymake backends, I am not sure if adding flymake-quickdef would be that
> constructive at this point.  Would you consider updating your package to
> not use the dependency?  You can check out other flymake-... modes in
> GNU and NonGNU ELPA for inspiration.
>
Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
and for now I would like to keep `flymake-quickdef`, I have plans to
write other backend and I don't wanna repeat the same validations and
code over and over, I'll switch to the DLS when it is implemented.

>> ;;; Commentary:
>>
>> ;; Flymake backend for GNU Guile using `guild' compile.
>> ;;
>> ;; Usage:
>> ;;   (require 'flymake-guile)
>> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
>
> It would probably make sense to autoload the `flymake-guile' function,
> so that it is not necessary to require it in a user configuration.
>
It already have autoload, I just update the commentary there.

>
> Are you sure the README.md is right thing to include here?  It includes
> installation instructions, that are usually redundant when you install
> the package using package.el.  I would recommend writing out the
> "Commentary" section in flymake-guile.el with a brief description of
> what package and its entry points.
>
> Also, the package appears to include files that needn't be distributed
> in the release tarball, such as .envrc and guix.scm.  It would be nice
> if you could track these and future files of this type in a .elpaignore
> file, to instruct the build server that they should be removed before
> packaging.
>
Updated in the last version ignoring those file and removing the README
declaration.

Thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 515 bytes --]

Re: [NonGNU ELPA] New package: flymake-guile

[Philip Kaludercic]

Distopico <distopico@riseup.net> writes:

> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>
>> Distopico <distopico@riseup.net> writes:
>>
>>> Hi all!
>>>
>>> I'm the author of a new package `flymake-guile` and I
>>> would like to include it in Nongnu ELPA.
>>
>> Just to be sure, you are sure you don't want to include your package in
>> GNU ELPA?
>>
>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>
>> I am not familiar with the "flymake-quickdef" package, but it doesn't
>> seem to be much shorter than just defining a regular flymake backend.
>> As there have been some discussions wrt providing a kind of DSL for
>> Flymake backends, I am not sure if adding flymake-quickdef would be that
>> constructive at this point.  Would you consider updating your package to
>> not use the dependency?  You can check out other flymake-... modes in
>> GNU and NonGNU ELPA for inspiration.
>>
> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
> and for now I would like to keep `flymake-quickdef`, I have plans to
> write other backend and I don't wanna repeat the same validations and
> code over and over, I'll switch to the DLS when it is implemented.

FWIW it already exists in this form https://github.com/mohkale/flymake-collection.

And just to make sure, you are certain you want to implement this on top
of a DSL?  I have to admit that I am really not a fan of the way that
flymake-quickdef is implemented, but one redeeming feature appears to be
that you could macroexpand it away, then clean the code up.

>>> ;;; Commentary:
>>>
>>> ;; Flymake backend for GNU Guile using `guild' compile.
>>> ;;
>>> ;; Usage:
>>> ;;   (require 'flymake-guile)
>>> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
>>
>> It would probably make sense to autoload the `flymake-guile' function,
>> so that it is not necessary to require it in a user configuration.
>>
> It already have autoload, I just update the commentary there.

1+

>>
>> Are you sure the README.md is right thing to include here?  It includes
>> installation instructions, that are usually redundant when you install
>> the package using package.el.  I would recommend writing out the
>> "Commentary" section in flymake-guile.el with a brief description of
>> what package and its entry points.
>>
>> Also, the package appears to include files that needn't be distributed
>> in the release tarball, such as .envrc and guix.scm.  It would be nice
>> if you could track these and future files of this type in a .elpaignore
>> file, to instruct the build server that they should be removed before
>> packaging.
>>
> Updated in the last version ignoring those file and removing the README
> declaration.
>
> Thank you!

Distopico <distopico@riseup.net> writes:

> v1 -> v2: Remove unnecesary README and ignore files.
>
>
> From 1f683e46e59f5ebff923b493aa911e489ecd7bb0 Mon Sep 17 00:00:00 2001
> From: Distopico <distopico@riseup.net>
> Date: Wed, 30 Aug 2023 20:53:27 -0500
> Subject: [PATCH v2 2/2] * elpa-packages (flymake-guile): New package
>
> ---
>  elpa-packages | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index 93e7c38600..e80486aec6 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -223,6 +223,9 @@
>   (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
>    :readme "README.md")
>  
> + (flymake-guile		:url "https://framagit.org/flymake-backends/flymake-guile.git"
> +  :ignored-files (".envrc" "guix.scm"))

It would be preferable to track this information in your own repository,
instead of having to update the info in the future in elpa-packages.

Also, it is totally fine to add both packages in a single patch.

Re: [NonGNU ELPA] New package: flymake-guile

[Distopico]

[-- Attachment #1: Type: text/plain, Size: 4428 bytes --]


On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:

> Distopico <distopico@riseup.net> writes:
>
>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>
>>> Distopico <distopico@riseup.net> writes:
>>>
>>>> Hi all!
>>>>
>>>> I'm the author of a new package `flymake-guile` and I
>>>> would like to include it in Nongnu ELPA.
>>>
>>> Just to be sure, you are sure you don't want to include your package in
>>> GNU ELPA?
>>>
>>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>>
>>> I am not familiar with the "flymake-quickdef" package, but it doesn't
>>> seem to be much shorter than just defining a regular flymake backend.
>>> As there have been some discussions wrt providing a kind of DSL for
>>> Flymake backends, I am not sure if adding flymake-quickdef would be that
>>> constructive at this point.  Would you consider updating your package to
>>> not use the dependency?  You can check out other flymake-... modes in
>>> GNU and NonGNU ELPA for inspiration.
>>>
>> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
>> and for now I would like to keep `flymake-quickdef`, I have plans to
>> write other backend and I don't wanna repeat the same validations and
>> code over and over, I'll switch to the DLS when it is implemented.
>
> FWIW it already exists in this form https://github.com/mohkale/flymake-collection.
>
> And just to make sure, you are certain you want to implement this on top
> of a DSL?  I have to admit that I am really not a fan of the way that
> flymake-quickdef is implemented, but one redeeming feature appears to be
> that you could macroexpand it away, then clean the code up.
>

flymake-collection use an adaptation of flymake-quickdef[1], that is
a macro similar to the quickdef one[2], could be use quickdef a blocker
to add the package on NonGNU ELPA?

>>>> ;;; Commentary:
>>>>
>>>> ;; Flymake backend for GNU Guile using `guild' compile.
>>>> ;;
>>>> ;; Usage:
>>>> ;;   (require 'flymake-guile)
>>>> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
>>>
>>> It would probably make sense to autoload the `flymake-guile' function,
>>> so that it is not necessary to require it in a user configuration.
>>>
>> It already have autoload, I just update the commentary there.
>
> 1+
>
>>>
>>> Are you sure the README.md is right thing to include here?  It includes
>>> installation instructions, that are usually redundant when you install
>>> the package using package.el.  I would recommend writing out the
>>> "Commentary" section in flymake-guile.el with a brief description of
>>> what package and its entry points.
>>>
>>> Also, the package appears to include files that needn't be distributed
>>> in the release tarball, such as .envrc and guix.scm.  It would be nice
>>> if you could track these and future files of this type in a .elpaignore
>>> file, to instruct the build server that they should be removed before
>>> packaging.
>>>
>> Updated in the last version ignoring those file and removing the README
>> declaration.
>>
>> Thank you!
>
> Distopico <distopico@riseup.net> writes:
>
>> v1 -> v2: Remove unnecesary README and ignore files.
>>
>>
>> From 1f683e46e59f5ebff923b493aa911e489ecd7bb0 Mon Sep 17 00:00:00 2001
>> From: Distopico <distopico@riseup.net>
>> Date: Wed, 30 Aug 2023 20:53:27 -0500
>> Subject: [PATCH v2 2/2] * elpa-packages (flymake-guile): New package
>>
>> ---
>>  elpa-packages | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/elpa-packages b/elpa-packages
>> index 93e7c38600..e80486aec6 100644
>> --- a/elpa-packages
>> +++ b/elpa-packages
>> @@ -223,6 +223,9 @@
>>   (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
>>    :readme "README.md")
>>  
>> + (flymake-guile		:url "https://framagit.org/flymake-backends/flymake-guile.git"
>> +  :ignored-files (".envrc" "guix.scm"))
>
> It would be preferable to track this information in your own repository,
> instead of having to update the info in the future in elpa-packages.
>
> Also, it is totally fine to add both packages in a single patch.
I will keep it in mind in the future., thank you

Footnotes:
[1]  https://github.com/mohkale/flymake-collection#flymake-quickdef

[2]  https://github.com/mohkale/flymake-collection/blob/release/src/flymake-collection-define.el#L134


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 515 bytes --]

Re: [NonGNU ELPA] New package: flymake-guile

[Philip Kaludercic]

Distopico <distopico@riseup.net> writes:

> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>
>> Distopico <distopico@riseup.net> writes:
>>
>>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>>
>>>> Distopico <distopico@riseup.net> writes:
>>>>
>>>>> Hi all!
>>>>>
>>>>> I'm the author of a new package `flymake-guile` and I
>>>>> would like to include it in Nongnu ELPA.
>>>>
>>>> Just to be sure, you are sure you don't want to include your package in
>>>> GNU ELPA?
>>>>
>>>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>>>
>>>> I am not familiar with the "flymake-quickdef" package, but it doesn't
>>>> seem to be much shorter than just defining a regular flymake backend.
>>>> As there have been some discussions wrt providing a kind of DSL for
>>>> Flymake backends, I am not sure if adding flymake-quickdef would be that
>>>> constructive at this point.  Would you consider updating your package to
>>>> not use the dependency?  You can check out other flymake-... modes in
>>>> GNU and NonGNU ELPA for inspiration.
>>>>
>>> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
>>> and for now I would like to keep `flymake-quickdef`, I have plans to
>>> write other backend and I don't wanna repeat the same validations and
>>> code over and over, I'll switch to the DLS when it is implemented.
>>
>> FWIW it already exists in this form https://github.com/mohkale/flymake-collection.
>>
>> And just to make sure, you are certain you want to implement this on top
>> of a DSL?  I have to admit that I am really not a fan of the way that
>> flymake-quickdef is implemented, but one redeeming feature appears to be
>> that you could macroexpand it away, then clean the code up.
>>
>
> flymake-collection use an adaptation of flymake-quickdef[1], that is
> a macro similar to the quickdef one[2], could be use quickdef a blocker
> to add the package on NonGNU ELPA?

I am afraid I don't understand your question.

Re: [NonGNU ELPA] New package: flymake-guile

[Dr. Arne Babenhauserheide]

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]


Philip Kaludercic <philipk@posteo.net> writes:

>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>> to add the package on NonGNU ELPA?
>
> I am afraid I don't understand your question.

I think it means: "do I have to or can I stick to the plans I have?"

Basically: is this a requirement to be added, or is it a suggestion that
Distopico can decide not to take.

Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1125 bytes --]

Re: [NonGNU ELPA] New package: flymake-guile

[Philip Kaludercic]

"Dr. Arne Babenhauserheide" <arne_bab@web.de> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>>> to add the package on NonGNU ELPA?
>>
>> I am afraid I don't understand your question.
>
> I think it means: "do I have to or can I stick to the plans I have?"
>
> Basically: is this a requirement to be added, or is it a suggestion that
> Distopico can decide not to take.

If Distopico insists on having the `flymake-quickdef' added to NonGNU
ELPA, I will do so, but I advise against it.

> Best wishes,
> Arne

Re: [NonGNU ELPA] New package: flymake-guile

[Distopico]

[-- Attachment #1: Type: text/plain, Size: 2311 bytes --]


On 2023-09-01, Philip Kaludercic <philipk@posteo.net> wrote:

> Distopico <distopico@riseup.net> writes:
>
>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>
>>> Distopico <distopico@riseup.net> writes:
>>>
>>>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>>>
>>>>> Distopico <distopico@riseup.net> writes:
>>>>>
>>>>>> Hi all!
>>>>>>
>>>>>> I'm the author of a new package `flymake-guile` and I
>>>>>> would like to include it in Nongnu ELPA.
>>>>>
>>>>> Just to be sure, you are sure you don't want to include your package in
>>>>> GNU ELPA?
>>>>>
>>>>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>>>>
>>>>> I am not familiar with the "flymake-quickdef" package, but it doesn't
>>>>> seem to be much shorter than just defining a regular flymake backend.
>>>>> As there have been some discussions wrt providing a kind of DSL for
>>>>> Flymake backends, I am not sure if adding flymake-quickdef would be that
>>>>> constructive at this point.  Would you consider updating your package to
>>>>> not use the dependency?  You can check out other flymake-... modes in
>>>>> GNU and NonGNU ELPA for inspiration.
>>>>>
>>>> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
>>>> and for now I would like to keep `flymake-quickdef`, I have plans to
>>>> write other backend and I don't wanna repeat the same validations and
>>>> code over and over, I'll switch to the DLS when it is implemented.
>>>
>>> FWIW it already exists in this form https://github.com/mohkale/flymake-collection.
>>>
>>> And just to make sure, you are certain you want to implement this on top
>>> of a DSL?  I have to admit that I am really not a fan of the way that
>>> flymake-quickdef is implemented, but one redeeming feature appears to be
>>> that you could macroexpand it away, then clean the code up.
>>>
>>
>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>> to add the package on NonGNU ELPA?
>
> I am afraid I don't understand your question.

My Question is if remove flymake-quickdef as dependency is a requirement
to merge flymake-guile package into NonGNU ELPA or it's just a
recommendation?   

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 515 bytes --]

Re: [NonGNU ELPA] New package: flymake-guile

[Philip Kaludercic]

[-- Attachment #1: Type: text/plain, Size: 2552 bytes --]

Distopico <distopico@riseup.net> writes:

> On 2023-09-01, Philip Kaludercic <philipk@posteo.net> wrote:
>
>> Distopico <distopico@riseup.net> writes:
>>
>>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>>
>>>> Distopico <distopico@riseup.net> writes:
>>>>
>>>>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>>>>
>>>>>> Distopico <distopico@riseup.net> writes:
>>>>>>
>>>>>>> Hi all!
>>>>>>>
>>>>>>> I'm the author of a new package `flymake-guile` and I
>>>>>>> would like to include it in Nongnu ELPA.
>>>>>>
>>>>>> Just to be sure, you are sure you don't want to include your package in
>>>>>> GNU ELPA?
>>>>>>
>>>>>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>>>>>
>>>>>> I am not familiar with the "flymake-quickdef" package, but it doesn't
>>>>>> seem to be much shorter than just defining a regular flymake backend.
>>>>>> As there have been some discussions wrt providing a kind of DSL for
>>>>>> Flymake backends, I am not sure if adding flymake-quickdef would be that
>>>>>> constructive at this point.  Would you consider updating your package to
>>>>>> not use the dependency?  You can check out other flymake-... modes in
>>>>>> GNU and NonGNU ELPA for inspiration.
>>>>>>
>>>>> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
>>>>> and for now I would like to keep `flymake-quickdef`, I have plans to
>>>>> write other backend and I don't wanna repeat the same validations and
>>>>> code over and over, I'll switch to the DLS when it is implemented.
>>>>
>>>> FWIW it already exists in this form https://github.com/mohkale/flymake-collection.
>>>>
>>>> And just to make sure, you are certain you want to implement this on top
>>>> of a DSL?  I have to admit that I am really not a fan of the way that
>>>> flymake-quickdef is implemented, but one redeeming feature appears to be
>>>> that you could macroexpand it away, then clean the code up.
>>>>
>>>
>>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>>> to add the package on NonGNU ELPA?
>>
>> I am afraid I don't understand your question.
>
> My Question is if remove flymake-quickdef as dependency is a requirement
> to merge flymake-guile package into NonGNU ELPA or it's just a
> recommendation?   

It is a strong recommendation.  FWIW I have done the work of
macroexpanding and cleaning the resulting code up (but there is still
some more work to be done), and you can see what I had in mind:


[-- Attachment #2: Type: text/plain, Size: 6091 bytes --]

diff --git a/flymake-guile.el b/flymake-guile.el
index d4b17b6..da64903 100644
--- a/flymake-guile.el
+++ b/flymake-guile.el
@@ -3,7 +3,7 @@
 ;; Copyright (c) 2023 Camilo Q.S. (Distopico) <distopico@riseup.net>
 
 ;; Author: Distopico <distopico@riseup.net>
-;; Package-Requires: ((emacs "26.1") (flymake "1.2.1") (flymake-quickdef "1.0.0"))
+;; Package-Requires: ((emacs "26.1") (flymake "1.2.1"))
 ;; Keywords: language, tools
 ;; Version: 0.3
 
@@ -35,14 +35,12 @@
 
 ;;; Code:
 
-(require 'flymake-quickdef)
-
 (defgroup flycheck-guile nil
   "GNU Guile Flymake backend."
   :prefix "flymake-guile-"
   :group 'flymake)
 
-(defcustom flymake-guile-guild-binary "guild"
+(defcustom flymake-guile-guild-executable "guild"
   "Name of the Guile `guild' executable."
   :type 'string
   :group 'flymake-guile)
@@ -142,47 +140,122 @@ Also verify if the `STACK-FILE' and the source file are te same."
 		    (- col 1))))
 	  text)))
 
-(flymake-quickdef-backend flymake-guile-backend
-  :pre-let ((guild-exec (executable-find flymake-guile-guild-binary)))
-  :pre-check (unless guild-exec (error "Cannot find guild executable"))
-  :write-type 'file
-  :proc-form (append
-	      (list guild-exec
-		"compile"
-		"-O0")
-	      (flymake-guile--warning-level-args)
-	      (flymake-guile--load-path-args)
-	      flymake-guile-guild-args
-	      (list fmqd-temp-file))
-  :search-regexp (concat
-		  "\\(.*\\)"
-		  flymake-guile--diag-lnum-rx
-		  "\\(.*\\):[[:space:]]?"
-		  "\\(Syntax error:[[:space:]].*\\|.*\\)$")
-  :prep-diagnostic
-  (let* ((stack_file (match-string 1))
-	 (stack_lnum (match-string 2))
-	 (stack_cnum (match-string 3))
-	 (severity (match-string 4))
-	 (stack_msg (match-string 5))
-	 (report (flymake-guile--get-diagnostic
-		  stack_msg
-		  stack_lnum
-		  stack_cnum
-		  stack_file
-		  fmqd-source))
-	 (lnum (car (car report)))
-	 (cnum (cdr (car report)))
-	 (text (cdr report))
-	 (pos (flymake-diag-region fmqd-source lnum cnum))
-	 (beg (car pos))
-	 (end (cdr pos))
-	 (type (cond
-		((string= severity "warning") :warning)
-		((string= severity "In procedure raise-exception") :error)
-		(t :note)))
-	 (msg (string-trim text)))
-    (list fmqd-source beg end type msg)))
+(defvar-local flymake-guile-process nil)
+
+(defun flymake-make-guile-sentinel (report-fn source temp-dir)
+  "Generate a process sentinel reporting to REPORT-FN.
+The argument SOURCE and TEMP-DIR are respectively used to pass
+the buffer containing the source code being checked and the
+temporary director generated for the checking."
+  (lambda (proc _event)
+    (unless (process-live-p proc)
+      (unwind-protect
+	  (if (eq proc (buffer-local-value 'flymake-guile-process source))
+	      (with-current-buffer source
+		(save-restriction
+		  (widen)
+		  (with-current-buffer (process-buffer proc)
+		    (goto-char (point-min))
+		    (save-match-data
+		      (let ((diags nil))
+			(while (search-forward-regexp
+				(concat
+				 "\\(.*\\)"
+				 flymake-guile--diag-lnum-rx
+				 "\\(.*\\):[[:space:]]?"
+				 "\\(Syntax error:[[:space:]].*\\|.*\\)$")
+				nil t)
+			  (save-match-data
+			    (save-excursion
+			      (let* ((diag-vals
+				      (let* ((stack_file
+					      (match-string 1))
+					     (stack_lnum
+					      (match-string 2))
+					     (stack_cnum
+					      (match-string 3))
+					     (severity
+					      (match-string 4))
+					     (stack_msg
+					      (match-string 5))
+					     (report
+					      (flymake-guile--get-diagnostic
+					       stack_msg
+					       stack_lnum
+					       stack_cnum
+					       stack_file
+					       source))
+					     (lnum (caar report))
+					     (cnum (cdar report))
+					     (text (cdr report))
+					     (pos
+					      (flymake-diag-region
+					       source
+					       lnum
+					       cnum))
+					     (beg (car pos))
+					     (end (cdr pos))
+					     (type
+					      (cond
+					       ((string= severity "warning") :warning)
+					       ((string= severity "In procedure raise-exception")
+						:error)
+					       (t :note)))
+					     (msg (string-trim text)))
+					(list source beg end type msg)))
+				     (diag-beg (nth 1 diag-vals))
+				     (diag-end (nth 2 diag-vals))
+				     (diag-type (nth 3 diag-vals)))
+				(if (and
+				     (integer-or-marker-p diag-beg)
+				     (integer-or-marker-p diag-end))
+				    (when diag-type
+				      (push (apply #'flymake-make-diagnostic diag-vals)
+					    diags))
+				  (with-current-buffer source
+				    (flymake-log
+				     :error
+				     "Got invalid buffer position %s or %s in %s"
+				     diag-beg
+				     diag-end
+				     proc)))))))
+			(funcall
+			 report-fn
+			 (nreverse
+			  diags)))))))
+	    (flymake-log :warning
+			 "Canceling obsolete check %s"
+			 proc))
+	(delete-directory temp-dir t)
+	(kill-buffer (process-buffer proc))))))
+
+(defun flymake-guile-backend (report-fn &rest _args)
+  "Flymake backend for Scheme buffers using GNU Guile.
+For the interpretation of REPORT-FN, consult the Info
+node `(flymake) Backend functions'."
+  (let* ((guild-exec (or (executable-find flymake-guile-guild-executable)
+			 (error "Cannot find guild executable")))
+	 (temp-dir (make-temp-file "flymake-guile-" t))
+	 (temp-file (expand-file-name
+		     (file-name-nondirectory (or (buffer-file-name) (buffer-name)))
+		     temp-dir)))
+    (when (process-live-p flymake-guile-process)
+      (kill-process flymake-guile-process))
+    (save-restriction
+      (widen)
+      (write-region nil nil temp-file nil 'silent)
+      (setq flymake-guile-process
+	    (make-process
+	     :name "flymake-guile-backend-flymake"
+	     :noquery t :connection-type 'pipe
+	     :buffer (generate-new-buffer " *flymake-guile-backend-flymake*")
+	     :sentinel (flymake-make-guile-sentinel report-fn (current-buffer) temp-dir)
+	     :command
+	     (append (list guild-exec "compile" "-O0")
+		     (flymake-guile--warning-level-args)
+		     (flymake-guile--load-path-args)
+		     flymake-guile-guild-args
+		     (list temp-file)))))))
 
 ;;;###autoload
 (defun flymake-guile ()

Re: [NonGNU ELPA] New package: flymake-guile

[Distopico]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]


Hi Philip,

On 2023-09-01, Philip Kaludercic <philipk@posteo.net> wrote:

>>>>
>>>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>>>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>>>> to add the package on NonGNU ELPA?
>>>
>>> I am afraid I don't understand your question.
>>
>> My Question is if remove flymake-quickdef as dependency is a requirement
>> to merge flymake-guile package into NonGNU ELPA or it's just a
>> recommendation?   
>
> It is a strong recommendation.  FWIW I have done the work of
> macroexpanding and cleaning the resulting code up (but there is still
> some more work to be done), and you can see what I had in mind:
>

I just made those change in the repo, you can check those now:
https://framagit.org/flymake-backends/flymake-guile, and BTW I added
`.elpaignore`, attache the patch adding just `flymake-guile`.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v3-0001-elpa-packages-flymake-guile-New-package.patch --]
[-- Type: text/x-patch, Size: 741 bytes --]

From 741836952dde52a17b55e013d73447830f97a5c1 Mon Sep 17 00:00:00 2001
From: Distopico <distopico@riseup.net>
Date: Mon, 4 Sep 2023 21:22:12 -0500
Subject: [PATCH v3] * elpa-packages (flymake-guile): New package

---
 elpa-packages | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index b57fcd061f..7564fe65eb 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -225,6 +225,8 @@
  (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
   :ignored-files ("COPYING.txt"))
 
+ (flymake-guile		:url "https://framagit.org/flymake-backends/flymake-guile.git")
+
  (flymake-popon		:url "https://codeberg.org/akib/emacs-flymake-popon")
 
  (focus			:url "https://github.com/larstvei/Focus"
-- 
2.41.0


[-- Attachment #3: Type: text/plain, Size: 7 bytes --]


Best!

Re: [NonGNU ELPA] New package: flymake-guile

[Philip Kaludercic]

Distopico <distopico@riseup.net> writes:

> Hi Philip,
>
> On 2023-09-01, Philip Kaludercic <philipk@posteo.net> wrote:
>
>>>>>
>>>>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>>>>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>>>>> to add the package on NonGNU ELPA?
>>>>
>>>> I am afraid I don't understand your question.
>>>
>>> My Question is if remove flymake-quickdef as dependency is a requirement
>>> to merge flymake-guile package into NonGNU ELPA or it's just a
>>> recommendation?   
>>
>> It is a strong recommendation.  FWIW I have done the work of
>> macroexpanding and cleaning the resulting code up (but there is still
>> some more work to be done), and you can see what I had in mind:
>>
>
> I just made those change in the repo, you can check those now:
> https://framagit.org/flymake-backends/flymake-guile, and BTW I added
> `.elpaignore`, attache the patch adding just `flymake-guile`.

Great, thank you very much.  I'll push the changes to nongnu.git.  Are
you otherwise familiar with the process of how ELPAs work?

Re: [NonGNU ELPA] New package: flymake-guile

[Distopico]

[-- Attachment #1: Type: text/plain, Size: 1395 bytes --]


On 2023-09-05, Philip Kaludercic <philipk@posteo.net> wrote:

> Distopico <distopico@riseup.net> writes:
>
>> Hi Philip,
>>
>> On 2023-09-01, Philip Kaludercic <philipk@posteo.net> wrote:
>>
>>>>>>
>>>>>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>>>>>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>>>>>> to add the package on NonGNU ELPA?
>>>>>
>>>>> I am afraid I don't understand your question.
>>>>
>>>> My Question is if remove flymake-quickdef as dependency is a requirement
>>>> to merge flymake-guile package into NonGNU ELPA or it's just a
>>>> recommendation?   
>>>
>>> It is a strong recommendation.  FWIW I have done the work of
>>> macroexpanding and cleaning the resulting code up (but there is still
>>> some more work to be done), and you can see what I had in mind:
>>>
>>
>> I just made those change in the repo, you can check those now:
>> https://framagit.org/flymake-backends/flymake-guile, and BTW I added
>> `.elpaignore`, attache the patch adding just `flymake-guile`.
>
> Great, thank you very much.  I'll push the changes to nongnu.git.  Are
> you otherwise familiar with the process of how ELPAs work?

Thank you,

About the process I'm not sure about it, how I publish a
new version? I guess is just update version in the repo but not sure
if I need to do something more  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 515 bytes --]

Re: [NonGNU ELPA] New package: flymake-guile

[Philip Kaludercic]

Distopico <distopico@riseup.net> writes:

> On 2023-09-05, Philip Kaludercic <philipk@posteo.net> wrote:
>
>> Distopico <distopico@riseup.net> writes:
>>
>>> Hi Philip,
>>>
>>> On 2023-09-01, Philip Kaludercic <philipk@posteo.net> wrote:
>>>
>>>>>>>
>>>>>>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>>>>>>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>>>>>>> to add the package on NonGNU ELPA?
>>>>>>
>>>>>> I am afraid I don't understand your question.
>>>>>
>>>>> My Question is if remove flymake-quickdef as dependency is a requirement
>>>>> to merge flymake-guile package into NonGNU ELPA or it's just a
>>>>> recommendation?   
>>>>
>>>> It is a strong recommendation.  FWIW I have done the work of
>>>> macroexpanding and cleaning the resulting code up (but there is still
>>>> some more work to be done), and you can see what I had in mind:
>>>>
>>>
>>> I just made those change in the repo, you can check those now:
>>> https://framagit.org/flymake-backends/flymake-guile, and BTW I added
>>> `.elpaignore`, attache the patch adding just `flymake-guile`.
>>
>> Great, thank you very much.  I'll push the changes to nongnu.git.  Are
>> you otherwise familiar with the process of how ELPAs work?
>
> Thank you,

No problem :)

> About the process I'm not sure about it, how I publish a
> new version? I guess is just update version in the repo but not sure
> if I need to do something more  

No, all you need to do is to bump the version tag in the package header,
and that commit will be used to create a new release tarball.  You can
also check out the NonGNU ELPA package guidelines[0], but I don't assume
there should be any issues here wrt non-free dependencies, since Guile
is firmly free software.

If you change anything and want to see how the ELPA build server handled
the change without triggering a release, you can check the "NonGNU
ELPA-devel" repository, that creates a new release for each individual
commit: https://elpa.nongnu.org/nongnu-devel/.

[0] https://git.savannah.gnu.org/cgit/emacs/nongnu.git/tree/README.org#n118

Re: [NonGNU ELPA] New package: flymake-guile

[Distopico]

[-- Attachment #1: Type: text/plain, Size: 2307 bytes --]


On 2023-09-05, Philip Kaludercic <philipk@posteo.net> wrote:

> Distopico <distopico@riseup.net> writes:
>
>> On 2023-09-05, Philip Kaludercic <philipk@posteo.net> wrote:
>>
>>> Distopico <distopico@riseup.net> writes:
>>>
>>>> Hi Philip,
>>>>
>>>> On 2023-09-01, Philip Kaludercic <philipk@posteo.net> wrote:
>>>>
>>>>>>>>
>>>>>>>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>>>>>>>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>>>>>>>> to add the package on NonGNU ELPA?
>>>>>>>
>>>>>>> I am afraid I don't understand your question.
>>>>>>
>>>>>> My Question is if remove flymake-quickdef as dependency is a requirement
>>>>>> to merge flymake-guile package into NonGNU ELPA or it's just a
>>>>>> recommendation?   
>>>>>
>>>>> It is a strong recommendation.  FWIW I have done the work of
>>>>> macroexpanding and cleaning the resulting code up (but there is still
>>>>> some more work to be done), and you can see what I had in mind:
>>>>>
>>>>
>>>> I just made those change in the repo, you can check those now:
>>>> https://framagit.org/flymake-backends/flymake-guile, and BTW I added
>>>> `.elpaignore`, attache the patch adding just `flymake-guile`.
>>>
>>> Great, thank you very much.  I'll push the changes to nongnu.git.  Are
>>> you otherwise familiar with the process of how ELPAs work?
>>
>> Thank you,
>
> No problem :)
>
>> About the process I'm not sure about it, how I publish a
>> new version? I guess is just update version in the repo but not sure
>> if I need to do something more  
>
> No, all you need to do is to bump the version tag in the package header,
> and that commit will be used to create a new release tarball.  You can
> also check out the NonGNU ELPA package guidelines[0], but I don't assume
> there should be any issues here wrt non-free dependencies, since Guile
> is firmly free software.
>
> If you change anything and want to see how the ELPA build server handled
> the change without triggering a release, you can check the "NonGNU
> ELPA-devel" repository, that creates a new release for each individual
> commit: https://elpa.nongnu.org/nongnu-devel/.
>
> [0] https://git.savannah.gnu.org/cgit/emacs/nongnu.git/tree/README.org#n118

Cool, thank you

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 515 bytes --]

Re: [NonGNU ELPA] New package: flymake-guile

[Mauro Aranda]

On 30/8/23 23:23, Distopico wrote:
 > Hi all!
 >
 > I'm the author of a new package `flymake-guile` and I
 > would like to include it in Nongnu ELPA.
 >
 > Here the repo: https://framagit.org/flymake-backends/flymake-guile
 >
 > --8<---------------cut here---------------start------------->8---
 > ;;; Commentary:
 >
 > ;; Flymake backend for GNU Guile using `guild' compile.
 > ;;
 > ;; Usage:
 > ;;   (require 'flymake-guile)
 > ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
 > --8<---------------cut here---------------end--------------->8---
 >
 > Best!
 >

Hi,

I've got a couple of comments about the defcustoms:

(defcustom flymake-guile-guild-args nil
   "Additional arguments for `guild' compile command."
   :type 'string
   :group 'flymake-guile)

Looks like either type should allow the nil value, or the default value
should be changed to a string.


(defcustom flymake-guile-warnings '("3")
   "A list of warnings to enable for `guild compile'.

The value of this variable could be an list string of warning types
or an warning level.

The list of supported warning types/levels can be found by running
`guild compile -W help'."
   :type  '(string)
   :group 'flymake-guile)

It looks like you want the :type to be a list of strings.  In that case
you should use (repeat string) as the :type.

Re: [NonGNU ELPA] New package: flymake-guile

[Distopico]

[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]


Hi Mauro, thank for your feedback.

On 2023-08-31, Mauro Aranda <maurooaranda@gmail.com> wrote:

> On 30/8/23 23:23, Distopico wrote:
>> Hi all!
>>
>> I'm the author of a new package `flymake-guile` and I
>> would like to include it in Nongnu ELPA.
>>
>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>
>> --8<---------------cut here---------------start------------->8---
>> ;;; Commentary:
>>
>> ;; Flymake backend for GNU Guile using `guild' compile.
>> ;;
>> ;; Usage:
>> ;;   (require 'flymake-guile)
>> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
>> --8<---------------cut here---------------end--------------->8---
>>
>> Best!
>>
>
> Hi,
>
> I've got a couple of comments about the defcustoms:
>
> (defcustom flymake-guile-guild-args nil
>   "Additional arguments for `guild' compile command."
>   :type 'string
>   :group 'flymake-guile)
>
> Looks like either type should allow the nil value, or the default value
> should be changed to a string.
>
>
> (defcustom flymake-guile-warnings '("3")
>   "A list of warnings to enable for `guild compile'.
>
> The value of this variable could be an list string of warning types
> or an warning level.
>
> The list of supported warning types/levels can be found by running
> `guild compile -W help'."
>   :type  '(string)
>   :group 'flymake-guile)
>
> It looks like you want the :type to be a list of strings.  In that case
> you should use (repeat string) as the :type.

I updated the code changing these, you can check the repo again and will
contain these changes.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 515 bytes --]

Re: [NonGNU ELPA] New package: flymake-guile

[Distopico]

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]


v1 -> v2: Remove unnecesary README and ignore files.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v2-0001-elpa-packages-flymake-quickdef-New-package.patch --]
[-- Type: text/x-patch, Size: 853 bytes --]

From c6a3d53bb56d3e0d8638fe069a49fc4d364e0e84 Mon Sep 17 00:00:00 2001
From: Distopico <distopico@riseup.net>
Date: Wed, 30 Aug 2023 20:41:28 -0500
Subject: [PATCH v2 1/2] * elpa-packages (flymake-quickdef): New package

---
 elpa-packages | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 0d9da00c84..93e7c38600 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -220,6 +220,9 @@
   :ignored-files (".travis.yml" "Cask" "LICENSE" "tests" "Makefile"
                   "flx.el" "misc/flx-helm-demo.el" "misc/flx-test-list.el"))
 
+ (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
+  :readme "README.md")
+
  (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
   :ignored-files ("COPYING.txt"))
 

base-commit: aba50eda61cc6083f7cd0b87bee5dcd21fbb40bc
-- 
2.41.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: v2-0002-elpa-packages-flymake-guile-New-package.patch --]
[-- Type: text/x-patch, Size: 770 bytes --]

From 1f683e46e59f5ebff923b493aa911e489ecd7bb0 Mon Sep 17 00:00:00 2001
From: Distopico <distopico@riseup.net>
Date: Wed, 30 Aug 2023 20:53:27 -0500
Subject: [PATCH v2 2/2] * elpa-packages (flymake-guile): New package

---
 elpa-packages | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 93e7c38600..e80486aec6 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -223,6 +223,9 @@
  (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
   :readme "README.md")
 
+ (flymake-guile		:url "https://framagit.org/flymake-backends/flymake-guile.git"
+  :ignored-files (".envrc" "guix.scm"))
+
  (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
   :ignored-files ("COPYING.txt"))
 
-- 
2.41.0