From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package: flymake-guile Date: Thu, 31 Aug 2023 06:52:44 +0000 Message-ID: <87y1hrr9dv.fsf@posteo.net> References: <87a5u7j55e.fsf@riseup.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37608"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Distopico Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 08:53:35 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbbYc-0009W5-Ma for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 08:53:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbbXw-0005OY-G7; Thu, 31 Aug 2023 02:52:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbXv-0005Ip-60 for emacs-devel@gnu.org; Thu, 31 Aug 2023 02:52:51 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbXr-0005dn-Dz for emacs-devel@gnu.org; Thu, 31 Aug 2023 02:52:50 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7FC7A240101 for ; Thu, 31 Aug 2023 08:52:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693464765; bh=YXowBd5uh13EUVia/k1y9jwIFiuZKj7tgG2v9ld+ZMw=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=lXCxSdm0r08Wr4fesWGK655guRPSy/nnYO85wAndAmmz//Wq1mHzE94YiMVaQktOn HHR2p2TeqfVMaEf3EUV0qWKYtcZ5OscUysyy9Gv6l9BWSalYYM4EUmVqDN7y4kh7J5 u1no/hOSfsFpMBYEzRzASOHskNN9eHt2DAtBryTOuqTubvb82vO6C/0NNk/BM71FEx VR84LJXDw1McpqU4qMR/0vJBNA1qHgRVJ1AAmtfIuHBJKNAszKZWXxNewpe7g9xt1B u4CKoJZntfvWdnZ9pmuwoEq63ySUfHlS8DueRe9+FUfeD3oJ6T7moUbNhHhzc76qWX 7gA+vaQTDxRlA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RbsL51Dkwz9rxG; Thu, 31 Aug 2023 08:52:45 +0200 (CEST) In-Reply-To: <87a5u7j55e.fsf@riseup.net> (distopico@riseup.net's message of "Wed, 30 Aug 2023 21:23:09 -0500") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309597 Archived-At: Distopico writes: > Hi all! > > I'm the author of a new package `flymake-guile` and I > would like to include it in Nongnu ELPA. Just to be sure, you are sure you don't want to include your package in GNU ELPA? > Here the repo: https://framagit.org/flymake-backends/flymake-guile I am not familiar with the "flymake-quickdef" package, but it doesn't seem to be much shorter than just defining a regular flymake backend. As there have been some discussions wrt providing a kind of DSL for Flymake backends, I am not sure if adding flymake-quickdef would be that constructive at this point. Would you consider updating your package to not use the dependency? You can check out other flymake-... modes in GNU and NonGNU ELPA for inspiration. > ;;; Commentary: > > ;; Flymake backend for GNU Guile using `guild' compile. > ;; > ;; Usage: > ;; (require 'flymake-guile) > ;; (add-hook 'scheme-mode-hook 'flymake-guile) It would probably make sense to autoload the `flymake-guile' function, so that it is not necessary to require it in a user configuration. > Best! > > From c6a3d53bb56d3e0d8638fe069a49fc4d364e0e84 Mon Sep 17 00:00:00 2001 > From: Distopico > Date: Wed, 30 Aug 2023 20:41:28 -0500 > Subject: [PATCH 1/2] * elpa-packages (flymake-quickdef): New package > > --- > elpa-packages | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/elpa-packages b/elpa-packages > index 0d9da00c84..93e7c38600 100644 > --- a/elpa-packages > +++ b/elpa-packages > @@ -220,6 +220,9 @@ > :ignored-files (".travis.yml" "Cask" "LICENSE" "tests" "Makefile" > "flx.el" "misc/flx-helm-demo.el" "misc/flx-test-list.el")) > > + (flymake-quickdef :url "https://github.com/karlotness/flymake-quickdef.git" > + :readme "README.md") > + > (flymake-kondor :url "https://github.com/turbo-cafe/flymake-kondor" > :ignored-files ("COPYING.txt")) > > -- > 2.41.0 > > > From 50674f93285692a4e7ca1c9b22d13bbffa89eabe Mon Sep 17 00:00:00 2001 > From: Distopico > Date: Wed, 30 Aug 2023 20:53:27 -0500 > Subject: [PATCH 2/2] * elpa-packages (flymake-guile): New package > > --- > elpa-packages | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/elpa-packages b/elpa-packages > index 93e7c38600..b07894fe1a 100644 > --- a/elpa-packages > +++ b/elpa-packages > @@ -223,6 +223,9 @@ > (flymake-quickdef :url "https://github.com/karlotness/flymake-quickdef.git" > :readme "README.md") > > + (flymake-guile :url "https://framagit.org/flymake-backends/flymake-guile.git" > + :readme "README.md") Are you sure the README.md is right thing to include here? It includes installation instructions, that are usually redundant when you install the package using package.el. I would recommend writing out the "Commentary" section in flymake-guile.el with a brief description of what package and its entry points. Also, the package appears to include files that needn't be distributed in the release tarball, such as .envrc and guix.scm. It would be nice if you could track these and future files of this type in a .elpaignore file, to instruct the build server that they should be removed before packaging. > > + > (flymake-kondor :url "https://github.com/turbo-cafe/flymake-kondor" > :ignored-files ("COPYING.txt"))