From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package: flymake-guile Date: Thu, 31 Aug 2023 08:03:53 -0300 Message-ID: <4ce3eb06-31b7-02c9-c624-6b5b30070f66@gmail.com> References: <87a5u7j55e.fsf@riseup.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7890"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Distopico , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 13:04:20 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbfTI-0001p4-7N for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 13:04:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbfTD-0001FQ-9a; Thu, 31 Aug 2023 07:04:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbfT5-00015D-0N for emacs-devel@gnu.org; Thu, 31 Aug 2023 07:04:07 -0400 Original-Received: from mail-oo1-xc2d.google.com ([2607:f8b0:4864:20::c2d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbfSy-0008A8-6X for emacs-devel@gnu.org; Thu, 31 Aug 2023 07:04:03 -0400 Original-Received: by mail-oo1-xc2d.google.com with SMTP id 006d021491bc7-565f2567422so423598eaf.2 for ; Thu, 31 Aug 2023 04:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693479839; x=1694084639; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=csOQANo9+465Ct04NW+9qobITC79QVpgA2juJxUs8oE=; b=PuQmQj4Do3gE3EbzaheixbjKHHEPkzzrJGEZtdwOVqiOvFrEvC/3hpCs/Whc4PUJqC /Hkz+x3QXR+gf/kjguNkfgTtvsZ6KOHTAefoLmze75FFlsdtQOljnOCH1olm+QkVtKZa Jo4f17roRUSXD5QnkHjwAyKFvfPZVclWII2jnX12jrqMBBCZmZ6oksJIHiFdhFISFA9Q YWMf0Bsm4K3l7ujVAc+5TT5p0xFzNgP3swWkl7nh9zRqNqESIcm32NebvLFpXFu1SmUy BwTSMbOMTYRuYITxDcRju+5tNW4rGhGPUYxMnTaGTlqoZc8Bk6wi7CN8kWW97k/A2Er7 Oylg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693479839; x=1694084639; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=csOQANo9+465Ct04NW+9qobITC79QVpgA2juJxUs8oE=; b=XBQ2WF2G5PRrLC2dAwmt5XEkK/3YJ6zdND/RiX1mVbHsz5/NONugV5USMZylfyI9Ev q2iGt5T9wOJn9nvKLr1eq4JDYCJO6quzS4cVG2MhRWZPyKGvpY8IFFw36Bsp8X+DR8JO HFs6uYd8itxKfV//mTCHc3kI7MExtCR3kZ0gyeNrAs5AnA+BEIoaIz4tD9Qi8QRNHMIL qIx5e+4NWqIqyS5FBCtmjnfFiQCw01zCC+68d1fQ0lJdBe0JJsLSKiyoxHhmt42qulhJ dYYBDWwS18clVYhmWLhUJSOqa8EvZVsyncLBT02wqxFkE0Bs/WFa3N2oKwSvHGXIqD6z TBbg== X-Gm-Message-State: AOJu0YwraNoY3agvOkhqg46IO94jF3j+31gEopyS8sO0hPBVWjgfqgkW 6GiCY67EHEbDdwUKI6DgWZ+xoowtPHs= X-Google-Smtp-Source: AGHT+IH19DGV/LUSuwUs1iz4G7GAb+4ZGtLey43Z1TgfbMHmsWbdw7g/+piPzbj1eGcqfJsuyTRcog== X-Received: by 2002:a4a:919c:0:b0:56e:4921:deb0 with SMTP id d28-20020a4a919c000000b0056e4921deb0mr4461664ooh.8.1693479838886; Thu, 31 Aug 2023 04:03:58 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id c127-20020a4a4f85000000b0056e9ffefee9sm564382oob.3.2023.08.31.04.03.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Aug 2023 04:03:57 -0700 (PDT) Content-Language: en-US Original-Newsgroups: gmane.emacs.devel In-Reply-To: <87a5u7j55e.fsf@riseup.net> Received-SPF: pass client-ip=2607:f8b0:4864:20::c2d; envelope-from=maurooaranda@gmail.com; helo=mail-oo1-xc2d.google.com X-Spam_score_int: -55 X-Spam_score: -5.6 X-Spam_bar: ----- X-Spam_report: (-5.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-3.478, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309626 Archived-At: On 30/8/23 23:23, Distopico wrote: > Hi all! > > I'm the author of a new package `flymake-guile` and I > would like to include it in Nongnu ELPA. > > Here the repo: https://framagit.org/flymake-backends/flymake-guile > > --8<---------------cut here---------------start------------->8--- > ;;; Commentary: > > ;; Flymake backend for GNU Guile using `guild' compile. > ;; > ;; Usage: > ;; (require 'flymake-guile) > ;; (add-hook 'scheme-mode-hook 'flymake-guile) > --8<---------------cut here---------------end--------------->8--- > > Best! > Hi, I've got a couple of comments about the defcustoms: (defcustom flymake-guile-guild-args nil "Additional arguments for `guild' compile command." :type 'string :group 'flymake-guile) Looks like either type should allow the nil value, or the default value should be changed to a string. (defcustom flymake-guile-warnings '("3") "A list of warnings to enable for `guild compile'. The value of this variable could be an list string of warning types or an warning level. The list of supported warning types/levels can be found by running `guild compile -W help'." :type '(string) :group 'flymake-guile) It looks like you want the :type to be a list of strings. In that case you should use (repeat string) as the :type.