Re: [NonGNU ELPA] New package: flymake-guile

[Mauro Aranda <maurooaranda@gmail.com>]

On 30/8/23 23:23, Distopico wrote:
 > Hi all!
 >
 > I'm the author of a new package `flymake-guile` and I
 > would like to include it in Nongnu ELPA.
 >
 > Here the repo: https://framagit.org/flymake-backends/flymake-guile
 >
 > --8<---------------cut here---------------start------------->8---
 > ;;; Commentary:
 >
 > ;; Flymake backend for GNU Guile using `guild' compile.
 > ;;
 > ;; Usage:
 > ;;   (require 'flymake-guile)
 > ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
 > --8<---------------cut here---------------end--------------->8---
 >
 > Best!
 >

Hi,

I've got a couple of comments about the defcustoms:

(defcustom flymake-guile-guild-args nil
   "Additional arguments for `guild' compile command."
   :type 'string
   :group 'flymake-guile)

Looks like either type should allow the nil value, or the default value
should be changed to a string.


(defcustom flymake-guile-warnings '("3")
   "A list of warnings to enable for `guild compile'.

The value of this variable could be an list string of warning types
or an warning level.

The list of supported warning types/levels can be found by running
`guild compile -W help'."
   :type  '(string)
   :group 'flymake-guile)

It looks like you want the :type to be a list of strings.  In that case
you should use (repeat string) as the :type.