From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package: flymake-guile Date: Thu, 31 Aug 2023 18:02:28 +0000 Message-ID: <8734zzqedn.fsf@posteo.net> References: <87a5u7j55e.fsf@riseup.net> <87y1hrr9dv.fsf@posteo.net> <871qfji40h.fsf@riseup.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27608"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Distopico Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 20:03:39 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbm15-0006xi-6i for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 20:03:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbm07-0005Sg-9h; Thu, 31 Aug 2023 14:02:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbm04-0005SP-SF for emacs-devel@gnu.org; Thu, 31 Aug 2023 14:02:36 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbm01-0008Nt-51 for emacs-devel@gnu.org; Thu, 31 Aug 2023 14:02:36 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 86E9924002A for ; Thu, 31 Aug 2023 20:02:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693504949; bh=xPycbalngtsop4tugMqVY0c1YD3xfHjNd7XFcOMVEoY=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=N8sq7yxoGximNqd5ISwBNpVz5reL29DZM0USoahMguFbbza82YV7kZ8394+EDohTy PMXAK6gVvWv8LfOZnZbN7rBW3po96uz30RDpN5QHkeB1VE1J6UU24IB8ClL0M1Rdsr vyEd//Xmbtjzyo2RDh7ohEFRqcnaF1H0j66xyVsLxftFdAtstSJAB1tnrB9HJA8/Kx muvkxSQ4hbiebxSYHVM5vI4ce699hW+1aLr3gYsNCpBFi/GuE9F+ykbrzhkBvSaiv3 mZFdAL741hU94OzIGvpoxmkvMTD9h3t6kh5B+2fCOQnGJzWabRJdbkUPujuRLMQpr1 dQLqoYc6kNU2g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rc8Br5hSSz9rxD; Thu, 31 Aug 2023 20:02:28 +0200 (CEST) In-Reply-To: <871qfji40h.fsf@riseup.net> (distopico@riseup.net's message of "Thu, 31 Aug 2023 11:08:02 -0500") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309689 Archived-At: Distopico writes: > On 2023-08-31, Philip Kaludercic wrote: > >> Distopico writes: >> >>> Hi all! >>> >>> I'm the author of a new package `flymake-guile` and I >>> would like to include it in Nongnu ELPA. >> >> Just to be sure, you are sure you don't want to include your package in >> GNU ELPA? >> >>> Here the repo: https://framagit.org/flymake-backends/flymake-guile >> >> I am not familiar with the "flymake-quickdef" package, but it doesn't >> seem to be much shorter than just defining a regular flymake backend. >> As there have been some discussions wrt providing a kind of DSL for >> Flymake backends, I am not sure if adding flymake-quickdef would be that >> constructive at this point. Would you consider updating your package to >> not use the dependency? You can check out other flymake-... modes in >> GNU and NonGNU ELPA for inspiration. >> > Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA, > and for now I would like to keep `flymake-quickdef`, I have plans to > write other backend and I don't wanna repeat the same validations and > code over and over, I'll switch to the DLS when it is implemented. FWIW it already exists in this form https://github.com/mohkale/flymake-collection. And just to make sure, you are certain you want to implement this on top of a DSL? I have to admit that I am really not a fan of the way that flymake-quickdef is implemented, but one redeeming feature appears to be that you could macroexpand it away, then clean the code up. >>> ;;; Commentary: >>> >>> ;; Flymake backend for GNU Guile using `guild' compile. >>> ;; >>> ;; Usage: >>> ;; (require 'flymake-guile) >>> ;; (add-hook 'scheme-mode-hook 'flymake-guile) >> >> It would probably make sense to autoload the `flymake-guile' function, >> so that it is not necessary to require it in a user configuration. >> > It already have autoload, I just update the commentary there. 1+ >> >> Are you sure the README.md is right thing to include here? It includes >> installation instructions, that are usually redundant when you install >> the package using package.el. I would recommend writing out the >> "Commentary" section in flymake-guile.el with a brief description of >> what package and its entry points. >> >> Also, the package appears to include files that needn't be distributed >> in the release tarball, such as .envrc and guix.scm. It would be nice >> if you could track these and future files of this type in a .elpaignore >> file, to instruct the build server that they should be removed before >> packaging. >> > Updated in the last version ignoring those file and removing the README > declaration. > > Thank you! Distopico writes: > v1 -> v2: Remove unnecesary README and ignore files. > > > From 1f683e46e59f5ebff923b493aa911e489ecd7bb0 Mon Sep 17 00:00:00 2001 > From: Distopico > Date: Wed, 30 Aug 2023 20:53:27 -0500 > Subject: [PATCH v2 2/2] * elpa-packages (flymake-guile): New package > > --- > elpa-packages | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/elpa-packages b/elpa-packages > index 93e7c38600..e80486aec6 100644 > --- a/elpa-packages > +++ b/elpa-packages > @@ -223,6 +223,9 @@ > (flymake-quickdef :url "https://github.com/karlotness/flymake-quickdef.git" > :readme "README.md") > > + (flymake-guile :url "https://framagit.org/flymake-backends/flymake-guile.git" > + :ignored-files (".envrc" "guix.scm")) It would be preferable to track this information in your own repository, instead of having to update the info in the future in elpa-packages. Also, it is totally fine to add both packages in a single patch.