From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Distopico Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package: flymake-guile Date: Thu, 31 Aug 2023 14:22:37 -0500 Message-ID: <87jztbgg8o.fsf@riseup.net> References: <87a5u7j55e.fsf@riseup.net> <87y1hrr9dv.fsf@posteo.net> <871qfji40h.fsf@riseup.net> <8734zzqedn.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40538"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 21:33:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbnPq-000AJW-BO for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 21:33:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbnP8-0002gI-0O; Thu, 31 Aug 2023 15:32:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbnP6-0002Yb-Bi for emacs-devel@gnu.org; Thu, 31 Aug 2023 15:32:32 -0400 Original-Received: from mx0.riseup.net ([198.252.153.6]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbnP2-0005Oo-Ub for emacs-devel@gnu.org; Thu, 31 Aug 2023 15:32:32 -0400 Original-Received: from fews01-sea.riseup.net (fews01-sea-pn.riseup.net [10.0.1.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx0.riseup.net (Postfix) with ESMTPS id 4RcBBf396Dz9t9Z; Thu, 31 Aug 2023 19:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1693510346; bh=F02iVd9EMv6HRa7+S5/GIOfFrSiTmBaYb+9COYP9ZHQ=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=LaSPpi4zDBlqWGzfpqAA5MWFtk+InFO/IMfqgVy4G6D1YlfNSXlc9DMnE9cbkYgHv BccV1ntymAY+Jmj8CPEJBLwMDEDdVOMNEReiciaWQKIdx9uFigJ0gTvVKnik8pHzP+ pXWqKzT3eCHaj/tFnnauPgwFJD5RajS8AhL656bY= X-Riseup-User-ID: CDB4757827002DF3C40980392F36C2E3824B73BC82EF26BCD95780F079ED61DD Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews01-sea.riseup.net (Postfix) with ESMTPSA id 4RcBBd5MBzzJq81; Thu, 31 Aug 2023 19:32:25 +0000 (UTC) In-reply-to: <8734zzqedn.fsf@posteo.net> Received-SPF: pass client-ip=198.252.153.6; envelope-from=distopico@riseup.net; helo=mx0.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309694 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-08-31, Philip Kaludercic wrote: > Distopico writes: > >> On 2023-08-31, Philip Kaludercic wrote: >> >>> Distopico writes: >>> >>>> Hi all! >>>> >>>> I'm the author of a new package `flymake-guile` and I >>>> would like to include it in Nongnu ELPA. >>> >>> Just to be sure, you are sure you don't want to include your package in >>> GNU ELPA? >>> >>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile >>> >>> I am not familiar with the "flymake-quickdef" package, but it doesn't >>> seem to be much shorter than just defining a regular flymake backend. >>> As there have been some discussions wrt providing a kind of DSL for >>> Flymake backends, I am not sure if adding flymake-quickdef would be that >>> constructive at this point. Would you consider updating your package to >>> not use the dependency? You can check out other flymake-... modes in >>> GNU and NonGNU ELPA for inspiration. >>> >> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA, >> and for now I would like to keep `flymake-quickdef`, I have plans to >> write other backend and I don't wanna repeat the same validations and >> code over and over, I'll switch to the DLS when it is implemented. > > FWIW it already exists in this form https://github.com/mohkale/flymake-co= llection. > > And just to make sure, you are certain you want to implement this on top > of a DSL? I have to admit that I am really not a fan of the way that > flymake-quickdef is implemented, but one redeeming feature appears to be > that you could macroexpand it away, then clean the code up. > flymake-collection use an adaptation of flymake-quickdef[1], that is a macro similar to the quickdef one[2], could be use quickdef a blocker to add the package on NonGNU ELPA? >>>> ;;; Commentary: >>>> >>>> ;; Flymake backend for GNU Guile using `guild' compile. >>>> ;; >>>> ;; Usage: >>>> ;; (require 'flymake-guile) >>>> ;; (add-hook 'scheme-mode-hook 'flymake-guile) >>> >>> It would probably make sense to autoload the `flymake-guile' function, >>> so that it is not necessary to require it in a user configuration. >>> >> It already have autoload, I just update the commentary there. > > 1+ > >>> >>> Are you sure the README.md is right thing to include here? It includes >>> installation instructions, that are usually redundant when you install >>> the package using package.el. I would recommend writing out the >>> "Commentary" section in flymake-guile.el with a brief description of >>> what package and its entry points. >>> >>> Also, the package appears to include files that needn't be distributed >>> in the release tarball, such as .envrc and guix.scm. It would be nice >>> if you could track these and future files of this type in a .elpaignore >>> file, to instruct the build server that they should be removed before >>> packaging. >>> >> Updated in the last version ignoring those file and removing the README >> declaration. >> >> Thank you! > > Distopico writes: > >> v1 -> v2: Remove unnecesary README and ignore files. >> >> >> From 1f683e46e59f5ebff923b493aa911e489ecd7bb0 Mon Sep 17 00:00:00 2001 >> From: Distopico >> Date: Wed, 30 Aug 2023 20:53:27 -0500 >> Subject: [PATCH v2 2/2] * elpa-packages (flymake-guile): New package >> >> --- >> elpa-packages | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/elpa-packages b/elpa-packages >> index 93e7c38600..e80486aec6 100644 >> --- a/elpa-packages >> +++ b/elpa-packages >> @@ -223,6 +223,9 @@ >> (flymake-quickdef :url "https://github.com/karlotness/flymake-qui= ckdef.git" >> :readme "README.md") >>=20=20 >> + (flymake-guile :url "https://framagit.org/flymake-backends/flymake-gu= ile.git" >> + :ignored-files (".envrc" "guix.scm")) > > It would be preferable to track this information in your own repository, > instead of having to update the info in the future in elpa-packages. > > Also, it is totally fine to add both packages in a single patch. I will keep it in mind in the future., thank you Footnotes: [1] https://github.com/mohkale/flymake-collection#flymake-quickdef [2] https://github.com/mohkale/flymake-collection/blob/release/src/flymake= -collection-define.el#L134 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFJBAEBCAAzFiEEvYwofabWO6y953lVmAk6gHJUa/MFAmTw6scVHGRpc3RvcGlj b0ByaXNldXAubmV0AAoJEJgJOoByVGvzUcYH/3LeTYHVtjL+G/aOY23tGZm3Nhyj BTWc35TRgE51/fwhC0sTEoPByBG8/ZFqwZCGH2lSxqnWXwI0dgAociJPGdUKV0dF suMUEA9mch3Fti1rNtNbOP+6pPst877yk9/DF9LCl/9BAbap6aT4S0kGfi6L9XXJ u42OaAJ5rUwqkzoutiBQb8uPq/rE7NvK0MnDeoCrfISFHTzIXG90KXOKsKu82p2Q y6GeFgvkafBSuJatChMZ8rQ0R0su8B2ZXYnEnhpI8qEm/JzRgyIq+9fo0w38anSA X88E4dSIBqNK7g1unT8+lYgYQ+q+7Q0EdTQ5T59m8Vez8JadmDuOef/e9e0= =w8vo -----END PGP SIGNATURE----- --=-=-=--