* (no subject)
@ 2014-10-03 21:18 David Bremner
2014-10-03 21:18 ` [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures David Bremner
` (6 more replies)
0 siblings, 7 replies; 35+ messages in thread
From: David Bremner @ 2014-10-03 21:18 UTC (permalink / raw)
To: notmuch
This is in some sense a successor to
id:cover.1411914914.git.jani@nikula.org
It includes the first two patches of that series verbatim, and adds
some tests.
^ permalink raw reply [flat|nested] 35+ messages in thread
* [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures
2014-10-03 21:18 David Bremner
@ 2014-10-03 21:18 ` David Bremner
2014-10-17 8:34 ` Jani Nikula
2014-10-03 21:18 ` [Patch v2.5 2/4] cli/insert: add fail path to add_file_to_database David Bremner
` (5 subsequent siblings)
6 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2014-10-03 21:18 UTC (permalink / raw)
To: notmuch
These tests are written with the assumption that we want all indexing
failures to be considered as failures by notmuch insert.
---
test/T070-insert.sh | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/test/T070-insert.sh b/test/T070-insert.sh
index ea9db07..40a7636 100755
--- a/test/T070-insert.sh
+++ b/test/T070-insert.sh
@@ -183,4 +183,26 @@ test_expect_code 1 "Invalid tags set exit code" \
notmuch config set new.tags $OLDCONFIG
+# DUPLICATE_MESSAGE_ID is not tested here, because it should actually pass.
+
+for code in OUT_OF_MEMORY XAPIAN_EXCEPTION FILE_NOT_EMAIL \
+ READ_ONLY_DATABASE UPGRADE_REQUIRED; do
+gen_insert_msg
+cat <<EOF > index-file-$code.gdb
+file notmuch
+set breakpoint pending on
+break notmuch_database_add_message
+commands
+return NOTMUCH_STATUS_$code
+continue
+end
+run
+EOF
+test_begin_subtest "error exit when add_message returns $code"
+test_subtest_known_broken
+gdb --batch-silent --return-child-result -x index-file-$code.gdb \
+ --args notmuch insert < $gen_msg_filename
+test_expect_equal $? 1
+done
+
test_done
--
2.1.0
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures
2014-10-03 21:18 ` [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures David Bremner
@ 2014-10-17 8:34 ` Jani Nikula
2014-10-18 6:02 ` David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: Jani Nikula @ 2014-10-17 8:34 UTC (permalink / raw)
To: David Bremner, notmuch
On Sat, 04 Oct 2014, David Bremner <david@tethera.net> wrote:
> These tests are written with the assumption that we want all indexing
> failures to be considered as failures by notmuch insert.
Just realized this needs a missing prereq test for gdb.
BR,
Jani.
> ---
> test/T070-insert.sh | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/test/T070-insert.sh b/test/T070-insert.sh
> index ea9db07..40a7636 100755
> --- a/test/T070-insert.sh
> +++ b/test/T070-insert.sh
> @@ -183,4 +183,26 @@ test_expect_code 1 "Invalid tags set exit code" \
>
> notmuch config set new.tags $OLDCONFIG
>
> +# DUPLICATE_MESSAGE_ID is not tested here, because it should actually pass.
> +
> +for code in OUT_OF_MEMORY XAPIAN_EXCEPTION FILE_NOT_EMAIL \
> + READ_ONLY_DATABASE UPGRADE_REQUIRED; do
> +gen_insert_msg
> +cat <<EOF > index-file-$code.gdb
> +file notmuch
> +set breakpoint pending on
> +break notmuch_database_add_message
> +commands
> +return NOTMUCH_STATUS_$code
> +continue
> +end
> +run
> +EOF
> +test_begin_subtest "error exit when add_message returns $code"
> +test_subtest_known_broken
> +gdb --batch-silent --return-child-result -x index-file-$code.gdb \
> + --args notmuch insert < $gen_msg_filename
> +test_expect_equal $? 1
> +done
> +
> test_done
> --
> 2.1.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures
2014-10-17 8:34 ` Jani Nikula
@ 2014-10-18 6:02 ` David Bremner
2014-10-18 6:30 ` David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2014-10-18 6:02 UTC (permalink / raw)
To: Jani Nikula, notmuch
Jani Nikula <jani@nikula.org> writes:
> On Sat, 04 Oct 2014, David Bremner <david@tethera.net> wrote:
>> These tests are written with the assumption that we want all indexing
>> failures to be considered as failures by notmuch insert.
>
> Just realized this needs a missing prereq test for gdb.
>
> BR,
> Jani.
oops. missed this until after I pushed. I'll look into it ASAP.
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures
2014-10-18 6:02 ` David Bremner
@ 2014-10-18 6:30 ` David Bremner
0 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2014-10-18 6:30 UTC (permalink / raw)
To: Jani Nikula, notmuch
David Bremner <david@tethera.net> writes:
> Jani Nikula <jani@nikula.org> writes:
>
>> On Sat, 04 Oct 2014, David Bremner <david@tethera.net> wrote:
>>> These tests are written with the assumption that we want all indexing
>>> failures to be considered as failures by notmuch insert.
>>
>> Just realized this needs a missing prereq test for gdb.
>>
>> BR,
>> Jani.
>
> oops. missed this until after I pushed. I'll look into it ASAP.
I took the liberty of pushing a one-line build fix. I'm not 100%
certain, but I think the usage of "test_require_external_prereq" in
T380-atomicity.sh could be simplified in a similary way.
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* [Patch v2.5 2/4] cli/insert: add fail path to add_file_to_database
2014-10-03 21:18 David Bremner
2014-10-03 21:18 ` [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures David Bremner
@ 2014-10-03 21:18 ` David Bremner
2014-10-03 21:18 ` [Patch v2.5 3/4] cli/insert: require succesful message indexing for success status David Bremner
` (4 subsequent siblings)
6 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2014-10-03 21:18 UTC (permalink / raw)
To: notmuch
From: Jani Nikula <jani@nikula.org>
Handle failures gracefully in add_file_to_database, renamed simply
add_file while at it. Add keep option to not remove the message from
database if tagging or tag syncing to maildir flags fails. Expand the
function documentation to cover the changes.
---
notmuch-insert.c | 99 ++++++++++++++++++++++++++++++++++++--------------------
1 file changed, 64 insertions(+), 35 deletions(-)
diff --git a/notmuch-insert.c b/notmuch-insert.c
index 5ef6e66..0ea4380 100644
--- a/notmuch-insert.c
+++ b/notmuch-insert.c
@@ -364,50 +364,80 @@ FAIL:
return NULL;
}
-/* Add the specified message file to the notmuch database, applying tags.
- * The file is renamed to encode notmuch tags as maildir flags. */
-static void
-add_file_to_database (notmuch_database_t *notmuch, const char *path,
- tag_op_list_t *tag_ops, notmuch_bool_t synchronize_flags)
+/*
+ * Add the specified message file to the notmuch database, applying
+ * tags in tag_ops. If synchronize_flags is TRUE, the tags are
+ * synchronized to maildir flags (which may result in message file
+ * rename).
+ *
+ * Return NOTMUCH_STATUS_SUCCESS on success, errors otherwise. If keep
+ * is TRUE, errors in tag changes and flag syncing are ignored and
+ * success status is returned; otherwise such errors cause the message
+ * to be removed from the database. Failure to add the message to the
+ * database results in error status regardless of keep.
+ */
+static notmuch_status_t
+add_file (notmuch_database_t *notmuch, const char *path, tag_op_list_t *tag_ops,
+ notmuch_bool_t synchronize_flags, notmuch_bool_t keep)
{
notmuch_message_t *message;
notmuch_status_t status;
status = notmuch_database_add_message (notmuch, path, &message);
- switch (status) {
- case NOTMUCH_STATUS_SUCCESS:
- case NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID:
- break;
- default:
- case NOTMUCH_STATUS_FILE_NOT_EMAIL:
- case NOTMUCH_STATUS_READ_ONLY_DATABASE:
- case NOTMUCH_STATUS_XAPIAN_EXCEPTION:
- case NOTMUCH_STATUS_OUT_OF_MEMORY:
- case NOTMUCH_STATUS_FILE_ERROR:
- case NOTMUCH_STATUS_NULL_POINTER:
- case NOTMUCH_STATUS_TAG_TOO_LONG:
- case NOTMUCH_STATUS_UNBALANCED_FREEZE_THAW:
- case NOTMUCH_STATUS_UNBALANCED_ATOMIC:
- case NOTMUCH_STATUS_LAST_STATUS:
- fprintf (stderr, "Error: failed to add `%s' to notmuch database: %s\n",
- path, notmuch_status_to_string (status));
- return;
- }
-
- if (status == NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID) {
- /* Don't change tags of an existing message. */
- if (synchronize_flags) {
- status = notmuch_message_tags_to_maildir_flags (message);
- if (status != NOTMUCH_STATUS_SUCCESS)
- fprintf (stderr, "Error: failed to sync tags to maildir flags\n");
+ if (status == NOTMUCH_STATUS_SUCCESS) {
+ status = tag_op_list_apply (message, tag_ops, 0);
+ if (status) {
+ fprintf (stderr, "%s: failed to apply tags to file '%s': %s\n",
+ keep ? "Warning" : "Error",
+ path, notmuch_status_to_string (status));
+ goto DONE;
}
+ } else if (status == NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID) {
+ status = NOTMUCH_STATUS_SUCCESS;
+ } else if (status == NOTMUCH_STATUS_FILE_NOT_EMAIL) {
+ fprintf (stderr, "Error: delivery of non-mail file: '%s'\n", path);
+ goto FAIL;
} else {
- tag_op_flag_t flags = synchronize_flags ? TAG_FLAG_MAILDIR_SYNC : 0;
+ fprintf (stderr, "Error: failed to add '%s' to notmuch database: %s\n",
+ path, notmuch_status_to_string (status));
+ goto FAIL;
+ }
- tag_op_list_apply (message, tag_ops, flags);
+ if (synchronize_flags) {
+ status = notmuch_message_tags_to_maildir_flags (message);
+ if (status != NOTMUCH_STATUS_SUCCESS)
+ fprintf (stderr, "%s: failed to sync tags to maildir flags for '%s': %s\n",
+ keep ? "Warning" : "Error",
+ path, notmuch_status_to_string (status));
+
+ /*
+ * Note: Unfortunately a failed maildir flag sync might
+ * already have renamed the file, in which case the cleanup
+ * path may fail.
+ */
}
+ DONE:
notmuch_message_destroy (message);
+
+ if (status) {
+ if (keep) {
+ status = NOTMUCH_STATUS_SUCCESS;
+ } else {
+ notmuch_status_t cleanup_status;
+
+ cleanup_status = notmuch_database_remove_message (notmuch, path);
+ if (cleanup_status != NOTMUCH_STATUS_SUCCESS &&
+ cleanup_status != NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID) {
+ fprintf (stderr, "Warning: failed to remove '%s' from database "
+ "after errors: %s. Please run 'notmuch new' to fix.\n",
+ path, notmuch_status_to_string (cleanup_status));
+ }
+ }
+ }
+
+ FAIL:
+ return status;
}
int
@@ -508,8 +538,7 @@ notmuch_insert_command (notmuch_config_t *config, int argc, char *argv[])
/* Add the message to the index.
* Even if adding the message to the notmuch database fails,
* the message is on disk and we consider the delivery completed. */
- add_file_to_database (notmuch, newpath, tag_ops,
- synchronize_flags);
+ add_file (notmuch, newpath, tag_ops, synchronize_flags, TRUE);
notmuch_database_destroy (notmuch);
return EXIT_SUCCESS;
--
2.1.0
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [Patch v2.5 3/4] cli/insert: require succesful message indexing for success status
2014-10-03 21:18 David Bremner
2014-10-03 21:18 ` [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures David Bremner
2014-10-03 21:18 ` [Patch v2.5 2/4] cli/insert: add fail path to add_file_to_database David Bremner
@ 2014-10-03 21:18 ` David Bremner
2014-10-03 21:19 ` [Patch v2.5 4/4] test/insert: check that indexing errors are accepted with --keep David Bremner
` (3 subsequent siblings)
6 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2014-10-03 21:18 UTC (permalink / raw)
To: notmuch
From: Jani Nikula <jani@nikula.org>
Add --keep option to keep any remaining stuff in index or file. We
could distinguish between failures to index and failures to apply tags
or maildir sync, but for simplicity just have one.
---
doc/man1/notmuch-insert.rst | 19 ++++++++++++-------
notmuch-insert.c | 36 ++++++++++++++++++++++++++++++------
test/T070-insert.sh | 3 +--
3 files changed, 43 insertions(+), 15 deletions(-)
diff --git a/doc/man1/notmuch-insert.rst b/doc/man1/notmuch-insert.rst
index 2be1a7b..e396f6c 100644
--- a/doc/man1/notmuch-insert.rst
+++ b/doc/man1/notmuch-insert.rst
@@ -38,16 +38,21 @@ Supported options for **insert** include
does not exist. Otherwise the folder must already exist for mail
delivery to succeed.
+ ``--keep``
+ Keep the message file if indexing fails, and keep the message
+ indexed if applying tags or maildir flag synchronization
+ fails. Ignore these errors and return exit status 0 to
+ indicate succesful mail delivery.
+
EXIT STATUS
===========
-This command returns exit status 0 if the message was successfully added
-to the mail directory, even if the message could not be indexed and
-added to the notmuch database. In the latter case, a warning will be
-printed to standard error but the message file will be left on disk.
-
-If the message could not be written to disk then a non-zero exit status
-is returned.
+This command returns exit status 0 on succesful mail delivery,
+non-zero otherwise. The default is to indicate failed mail delivery on
+any errors, including message file delivery to the filesystem, message
+indexing to Notmuch database, changing tags, and synchronizing tags to
+maildir flags. The ``--keep`` option may be used to settle for
+successful message file delivery.
SEE ALSO
========
diff --git a/notmuch-insert.c b/notmuch-insert.c
index 0ea4380..7074077 100644
--- a/notmuch-insert.c
+++ b/notmuch-insert.c
@@ -443,6 +443,7 @@ add_file (notmuch_database_t *notmuch, const char *path, tag_op_list_t *tag_ops,
int
notmuch_insert_command (notmuch_config_t *config, int argc, char *argv[])
{
+ notmuch_status_t status, close_status;
notmuch_database_t *notmuch;
struct sigaction action;
const char *db_path;
@@ -452,6 +453,7 @@ notmuch_insert_command (notmuch_config_t *config, int argc, char *argv[])
char *query_string = NULL;
const char *folder = NULL;
notmuch_bool_t create_folder = FALSE;
+ notmuch_bool_t keep = FALSE;
notmuch_bool_t synchronize_flags;
const char *maildir;
char *newpath;
@@ -461,6 +463,7 @@ notmuch_insert_command (notmuch_config_t *config, int argc, char *argv[])
notmuch_opt_desc_t options[] = {
{ NOTMUCH_OPT_STRING, &folder, "folder", 0, 0 },
{ NOTMUCH_OPT_BOOLEAN, &create_folder, "create-folder", 0, 0 },
+ { NOTMUCH_OPT_BOOLEAN, &keep, "keep", 0, 0 },
{ NOTMUCH_OPT_END, 0, 0, 0, 0 }
};
@@ -535,11 +538,32 @@ notmuch_insert_command (notmuch_config_t *config, int argc, char *argv[])
return EXIT_FAILURE;
}
- /* Add the message to the index.
- * Even if adding the message to the notmuch database fails,
- * the message is on disk and we consider the delivery completed. */
- add_file (notmuch, newpath, tag_ops, synchronize_flags, TRUE);
+ /* Index the message. */
+ status = add_file (notmuch, newpath, tag_ops, synchronize_flags, keep);
+
+ /* Commit changes. */
+ close_status = notmuch_database_destroy (notmuch);
+ if (close_status) {
+ /* Hold on to the first error, if any. */
+ if (! status)
+ status = close_status;
+ fprintf (stderr, "%s: failed to commit database changes: %s\n",
+ keep ? "Warning" : "Error",
+ notmuch_status_to_string (close_status));
+ }
+
+ if (status) {
+ if (keep) {
+ status = NOTMUCH_STATUS_SUCCESS;
+ } else {
+ /* If maildir flag sync failed, this might fail. */
+ if (unlink (newpath)) {
+ fprintf (stderr, "Warning: failed to remove '%s' from maildir "
+ "after errors: %s. Please run 'notmuch new' to fix.\n",
+ newpath, strerror (errno));
+ }
+ }
+ }
- notmuch_database_destroy (notmuch);
- return EXIT_SUCCESS;
+ return status ? EXIT_FAILURE : EXIT_SUCCESS;
}
diff --git a/test/T070-insert.sh b/test/T070-insert.sh
index 40a7636..be8060e 100755
--- a/test/T070-insert.sh
+++ b/test/T070-insert.sh
@@ -23,7 +23,7 @@ test_expect_code 1 "Insert zero-length file" \
# This test is a proxy for other errors that may occur while trying to
# add a message to the notmuch database, e.g. database locked.
-test_expect_code 0 "Insert non-message" \
+test_expect_code 1 "Insert non-message" \
"echo bad_message | notmuch insert"
test_begin_subtest "Database empty so far"
@@ -199,7 +199,6 @@ end
run
EOF
test_begin_subtest "error exit when add_message returns $code"
-test_subtest_known_broken
gdb --batch-silent --return-child-result -x index-file-$code.gdb \
--args notmuch insert < $gen_msg_filename
test_expect_equal $? 1
--
2.1.0
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [Patch v2.5 4/4] test/insert: check that indexing errors are accepted with --keep
2014-10-03 21:18 David Bremner
` (2 preceding siblings ...)
2014-10-03 21:18 ` [Patch v2.5 3/4] cli/insert: require succesful message indexing for success status David Bremner
@ 2014-10-03 21:19 ` David Bremner
2014-10-03 21:22 ` David Bremner
` (2 subsequent siblings)
6 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2014-10-03 21:19 UTC (permalink / raw)
To: notmuch
This is overkill for the current code path, but should provide some
robustness for future changes in error handling.
---
test/T070-insert.sh | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/test/T070-insert.sh b/test/T070-insert.sh
index be8060e..80a22c1 100755
--- a/test/T070-insert.sh
+++ b/test/T070-insert.sh
@@ -202,6 +202,11 @@ test_begin_subtest "error exit when add_message returns $code"
gdb --batch-silent --return-child-result -x index-file-$code.gdb \
--args notmuch insert < $gen_msg_filename
test_expect_equal $? 1
+
+test_begin_subtest "success exit with --keep when add_message returns $code"
+gdb --batch-silent --return-child-result -x index-file-$code.gdb \
+ --args notmuch insert --keep < $gen_msg_filename
+test_expect_equal $? 0
done
test_done
--
2.1.0
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re:
2014-10-03 21:18 David Bremner
` (3 preceding siblings ...)
2014-10-03 21:19 ` [Patch v2.5 4/4] test/insert: check that indexing errors are accepted with --keep David Bremner
@ 2014-10-03 21:22 ` David Bremner
2014-10-04 6:56 ` tests for notmuch-insert David Bremner
2014-10-16 21:14 ` Jani Nikula
6 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2014-10-03 21:22 UTC (permalink / raw)
To: notmuch
David Bremner <david@tethera.net> writes:
> This is in some sense a successor to
>
> id:cover.1411914914.git.jani@nikula.org
>
> It includes the first two patches of that series verbatim, and adds
> some tests.
I should have said _almost_ verbatim; it marks some tests non-broken.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: tests for notmuch-insert
2014-10-03 21:18 David Bremner
` (4 preceding siblings ...)
2014-10-03 21:22 ` David Bremner
@ 2014-10-04 6:56 ` David Bremner
2014-10-16 21:14 ` Jani Nikula
6 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2014-10-04 6:56 UTC (permalink / raw)
To: notmuch
David Bremner <david@tethera.net> writes:
> This is in some sense a successor to
>
> id:cover.1411914914.git.jani@nikula.org
>
> It includes the first two patches of that series verbatim, and adds
> some tests.
>
This series depends on the enabling of debug symbols in
id:1412367730-25890-1-git-send-email-david@tethera.net
I did (just now) test it with gdb 7.8, and it seems OK.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2014-10-03 21:18 David Bremner
` (5 preceding siblings ...)
2014-10-04 6:56 ` tests for notmuch-insert David Bremner
@ 2014-10-16 21:14 ` Jani Nikula
6 siblings, 0 replies; 35+ messages in thread
From: Jani Nikula @ 2014-10-16 21:14 UTC (permalink / raw)
To: David Bremner, notmuch
On Sat, 04 Oct 2014, David Bremner <david@tethera.net> wrote:
> This is in some sense a successor to
>
> id:cover.1411914914.git.jani@nikula.org
>
> It includes the first two patches of that series verbatim, and adds
> some tests.
I like it, very nice. Start pushing and add the post-insert hook patch
from my series on top? ;)
BR,
Jani.
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
@ 2018-02-01 20:53 Matthew Lear
2018-02-03 22:38 ` Jani Nikula
0 siblings, 1 reply; 35+ messages in thread
From: Matthew Lear @ 2018-02-01 20:53 UTC (permalink / raw)
To: notmuch, matt
From: Matthew Lear <matt@bubblegen.co.uk>
To: notmuch@notmuchmail.org
Cc: Matthew Lear <matt@bubblegen.co.uk>
Subject: [PATCH] Update date search syntax.
Date: Thu, 1 Feb 2018 20:52:18 +0000
Message-Id: <20180201205218.4368-1-matt@bubblegen.co.uk>
X-Mailer: git-send-email 2.14.1
If searching using the date prefix and timestamps, each timestamp
is required to be prefixed with an @
Legacy syntax of <initial-timestamp>..<final-timestamp> without the
date prefix is still honoured, only without the @ specifiers.
---
doc/man7/notmuch-search-terms.rst | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/doc/man7/notmuch-search-terms.rst b/doc/man7/notmuch-search-terms.rst
index 6d2bf62a..b6e7079a 100644
--- a/doc/man7/notmuch-search-terms.rst
+++ b/doc/man7/notmuch-search-terms.rst
@@ -124,10 +124,13 @@ date:<since>..<until> or date:<date>
The time range can also be specified using timestamps with a
syntax of:
- <initial-timestamp>..<final-timestamp>
+ @<initial-timestamp>..@<final-timestamp>
Each timestamp is a number representing the number of seconds
- since 1970-01-01 00:00:00 UTC.
+ since 1970-01-01 00:00:00 UTC. A date range search using
+ timestamps is also permitted without using the date prefix and
+ @ specifiers, although this is considered legacy and pre-dates
+ the date prefix.
lastmod:<initial-revision>..<final-revision>
The **lastmod:** prefix can be used to restrict the result by the
--
2.14.1
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re:
2018-02-01 20:53 Matthew Lear
@ 2018-02-03 22:38 ` Jani Nikula
0 siblings, 0 replies; 35+ messages in thread
From: Jani Nikula @ 2018-02-03 22:38 UTC (permalink / raw)
To: Matthew Lear, notmuch, matt
On Thu, 01 Feb 2018, Matthew Lear <matt@bubblegen.co.uk> wrote:
> From: Matthew Lear <matt@bubblegen.co.uk>
> To: notmuch@notmuchmail.org
> Cc: Matthew Lear <matt@bubblegen.co.uk>
> Subject: [PATCH] Update date search syntax.
> Date: Thu, 1 Feb 2018 20:52:18 +0000
> Message-Id: <20180201205218.4368-1-matt@bubblegen.co.uk>
> X-Mailer: git-send-email 2.14.1
>
> If searching using the date prefix and timestamps, each timestamp
> is required to be prefixed with an @
> Legacy syntax of <initial-timestamp>..<final-timestamp> without the
> date prefix is still honoured, only without the @ specifiers.
> ---
> doc/man7/notmuch-search-terms.rst | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/doc/man7/notmuch-search-terms.rst b/doc/man7/notmuch-search-terms.rst
> index 6d2bf62a..b6e7079a 100644
> --- a/doc/man7/notmuch-search-terms.rst
> +++ b/doc/man7/notmuch-search-terms.rst
> @@ -124,10 +124,13 @@ date:<since>..<until> or date:<date>
> The time range can also be specified using timestamps with a
> syntax of:
>
> - <initial-timestamp>..<final-timestamp>
> + @<initial-timestamp>..@<final-timestamp>
So I think I'd add the @ syntax in the DATE AND TIME SEARCH section,
maybe under a separate new heading, and just emphasize this here is
about the non-date prefixed thing.
BR,
Jani.
> Each timestamp is a number representing the number of seconds
> - since 1970-01-01 00:00:00 UTC.
> + since 1970-01-01 00:00:00 UTC. A date range search using
> + timestamps is also permitted without using the date prefix and
> + @ specifiers, although this is considered legacy and pre-dates
> + the date prefix.
>
> lastmod:<initial-revision>..<final-revision>
> The **lastmod:** prefix can be used to restrict the result by the
> --
> 2.14.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] Add Emacs' imenu support in notmuch-show and notmuch-search
@ 2017-06-11 11:00 David Bremner
2017-06-12 13:30 ` Damien Cassou
0 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2017-06-11 11:00 UTC (permalink / raw)
To: Damien Cassou, notmuch
Damien Cassou <damien@cassou.me> writes:
> David Bremner <david@tethera.net> writes:
>> I am indeed using the default. I think you forgot the screen
>> shot.
>
>
> indeed. Attached to this email.
>
>
>>> I can still get rid of indentation if you confirm you don't
>>> want it.
>>
>> I think so, although to be honest I never tried imenu before
>> testing your patches, perhaps we should wait for other opinions.
>
>
> I advise you to install counsel at least for that (I don't use it
> for anything else).
>
OK, I see with counsel-imenu the current indexing by header lines is
reasonable. It might be improvable by adding the subject, but I'm not
sure about line lengths.
- maybe the docstrings should recomment counsel-imenu?
- I think the indentation should probably go to make it more
usable with the builtin imenu
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
2017-06-11 11:00 [PATCH] Add Emacs' imenu support in notmuch-show and notmuch-search David Bremner
@ 2017-06-12 13:30 ` Damien Cassou
2017-06-14 1:22 ` David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: Damien Cassou @ 2017-06-12 13:30 UTC (permalink / raw)
To: David Bremner, Damien Cassou, notmuch
> OK, I see with counsel-imenu the current indexing by header lines is
> reasonable. It might be improvable by adding the subject, but I'm
> not sure about line lengths.
> - maybe the docstrings should recomment counsel-imenu?
I'm not sure as the function
`notmuch-show-imenu-extract-index-name-function` is private and there
are other imenu frontends available. What about a NEWS entry instead
along those lines:
* Add Emacs' imenu support in notmuch-show and notmuch-search
Emacs' major modes can facilitate navigation in their buffers by
supporting Imenu. In such major modes, launching Imenu (M-x imenu)
makes Emacs display a list of items (e.g., function definitions in
a code buffer). Selecting an item from this list moves point to
this item.
This release adds Imenu support to both notmuch-show and
notmuch-search buffers:
* in notmuch-show, Imenu will present a list of all messages in
the currently visible thread;
* in notmuch-search, Imenu will present a list of all messages in the
search buffer.
We recommand an external imenu frontend, such as counsel-imenu,
which will make the experience much better that the default `M-x
imenu`.
> I think the indentation should probably go to make it more usable
> with the builtin imenu
I did that in the patch even though I liked it with indentation better.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2017-06-12 13:30 ` Damien Cassou
@ 2017-06-14 1:22 ` David Bremner
2017-06-14 9:44 ` Re: David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2017-06-14 1:22 UTC (permalink / raw)
To: Damien Cassou, Damien Cassou, notmuch
Damien Cassou <damien@cassou.me> writes:
>> OK, I see with counsel-imenu the current indexing by header lines is
>> reasonable. It might be improvable by adding the subject, but I'm
>> not sure about line lengths.
>> - maybe the docstrings should recomment counsel-imenu?
>
> I'm not sure as the function
> `notmuch-show-imenu-extract-index-name-function` is private and there
> are other imenu frontends available. What about a NEWS entry instead
> along those lines:
>
> * Add Emacs' imenu support in notmuch-show and notmuch-search
>
> Emacs' major modes can facilitate navigation in their buffers by
> supporting Imenu. In such major modes, launching Imenu (M-x imenu)
> makes Emacs display a list of items (e.g., function definitions in
> a code buffer). Selecting an item from this list moves point to
> this item.
>
> This release adds Imenu support to both notmuch-show and
> notmuch-search buffers:
>
> * in notmuch-show, Imenu will present a list of all messages in
> the currently visible thread;
>
> * in notmuch-search, Imenu will present a list of all messages in the
> search buffer.
>
> We recommand an external imenu frontend, such as counsel-imenu,
> which will make the experience much better that the default `M-x
> imenu`.
That sounds fine.
>> I think the indentation should probably go to make it more usable
>> with the builtin imenu
>
> I did that in the patch even though I liked it with indentation better.
I haven't had a chance to test the new version yet, but I think I know
what you mean from testing counsel-imenu. Is it worth adding a
customization variable so that the user can choose indentation if they
have a more sophisticated imenu front end?
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2017-06-14 1:22 ` David Bremner
@ 2017-06-14 9:44 ` David Bremner
2017-06-14 9:54 ` Re: Damien Cassou
0 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2017-06-14 9:44 UTC (permalink / raw)
To: Damien Cassou, Damien Cassou, notmuch
David Bremner <david@tethera.net> writes:
>> I did that in the patch even though I liked it with indentation better.
>
> I haven't had a chance to test the new version yet, but I think I know
> what you mean from testing counsel-imenu. Is it worth adding a
> customization variable so that the user can choose indentation if they
> have a more sophisticated imenu front end?
So this version is ok with both builtin and counsel imenu front
ends. It's up to you. Do you want to leave the question of controllable
indentation for a later commit or add it now?
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2017-06-14 9:44 ` Re: David Bremner
@ 2017-06-14 9:54 ` Damien Cassou
0 siblings, 0 replies; 35+ messages in thread
From: Damien Cassou @ 2017-06-14 9:54 UTC (permalink / raw)
To: David Bremner, notmuch
David Bremner <david@tethera.net> writes:
> David Bremner <david@tethera.net> writes:
>
>>> I did that in the patch even though I liked it with
>>> indentation better.
>>
>> I haven't had a chance to test the new version yet, but I think
>> I know what you mean from testing counsel-imenu. Is it worth
>> adding a customization variable so that the user can choose
>> indentation if they have a more sophisticated imenu front end?
>
> So this version is ok with both builtin and counsel imenu front
> ends. It's up to you. Do you want to leave the question of
> controllable indentation for a later commit or add it now?
if you are ok to merge that right now, that would be perfect for
me. Thanks.
--
Damien Cassou
http://damiencassou.seasidehosting.st
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
@ 2017-05-23 18:54 Tomi Ollila
2017-05-26 10:40 ` David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: Tomi Ollila @ 2017-05-23 18:54 UTC (permalink / raw)
To: notmuch; +Cc: tomi.ollila
This implementation adds add_exit_function (and rm_exit_function)
which can also be used for other things in the future.
Now that I did this simpler way would be to just check for
existence of $GNUPGHOME for indication to exit gpg processes.
If that path is taken this series can be used for future reference
if need for atexit functionality arises.
From Tomi Ollila <tomi.ollila@iki.fi> # This line is ignored.
From: Tomi Ollila <tomi.ollila@iki.fi>
Subject: stop gpg-agent (among other) processes at test module exit
In-Reply-To:
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
@ 2016-10-15 8:44 Matthew Lear
0 siblings, 0 replies; 35+ messages in thread
From: Matthew Lear @ 2016-10-15 8:44 UTC (permalink / raw)
To: Mark Walters, notmuch
[-- Attachment #1: Type: text/plain, Size: 2594 bytes --]
Hi Mark. Excellent :-) I'll look out for it in the repository at some point soon. Cheers, Matt
-------- Original message --------From: Mark Walters <markwalters1009@gmail.com> Date: 15/10/2016 08:09 (GMT+00:00) To: matt@bubblegen.co.uk, notmuch@notmuchmail.org, matt@bubblegen.co.uk Subject: Re:
On Wed, 12 Oct 2016, Mark Walters <markwalters1009@gmail.com> wrote:
> On Tue, 11 Oct 2016, matt@bubblegen.co.uk wrote:
>> From: Matthew Lear <matt@bubblegen.co.uk>
>> To: notmuch@notmuchmail.org
>> Cc: Matthew Lear <matt@bubblegen.co.uk>
>> Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text.
>> Date: Tue, 11 Oct 2016 22:24:18 +0100
>> Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk>
>> X-Mailer: git-send-email 2.4.10
>>
>> If an encrypted multipart message is received which contains html and
>> notmuch-multipart/alternative-discouraged is set to discourage "text/plain",
>> any encrypted parts are not decrypted during generation of the reply
>> text. This fixes that problem by making sure notmuch-mua-reply does
>> that.
>
> Hi
>
> I haven't tested this but it looks correct: more broadly I think this is
> needed whenever notmuch-show has to get a part directly rather than just
> from the sexp reply.
Hi
Just to confirm I have now tested this -- it compiles and test suite
passes. (Note I don't have suitable encrypted messages to test).
Anyway LGTM +1
Best wishes
Mark
>
> Best wishes
>
> Mark
>
>
>> ---
>> emacs/notmuch-mua.el | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
>> index c567173..f333655 100644
>> --- a/emacs/notmuch-mua.el
>> +++ b/emacs/notmuch-mua.el
>> @@ -251,6 +251,10 @@ mutiple parts get a header."
>> (notmuch-show-max-text-part-size 0)
>> ;; Insert headers for parts as appropriate for replying.
>> (notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function)
>> + ;; Ensure that any encrypted parts are
>> + ;; decrypted during the generation of the reply
>> + ;; text.
>> + (notmuch-show-process-crypto process-crypto)
>> ;; Don't indent multipart sub-parts.
>> (notmuch-show-indent-multipart nil))
>> ;; We don't want sigstatus buttons (an information leak and usually wrong anyway).
>> --
>> 2.4.10
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch
[-- Attachment #2: Type: text/html, Size: 3660 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
@ 2016-10-13 19:37 Matt Armstrong
2016-10-13 19:42 ` Matt Armstrong
0 siblings, 1 reply; 35+ messages in thread
From: Matt Armstrong @ 2016-10-13 19:37 UTC (permalink / raw)
To: notmuch
This supercedes
id:1476207707-21827-1-git-send-email-marmstrong@google.com with
changes steming from Mark's helpful feedback.
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
@ 2016-10-11 21:24 matt
2016-10-12 7:51 ` Mark Walters
2016-10-17 12:01 ` Re: David Bremner
0 siblings, 2 replies; 35+ messages in thread
From: matt @ 2016-10-11 21:24 UTC (permalink / raw)
To: notmuch, matt
From: Matthew Lear <matt@bubblegen.co.uk>
To: notmuch@notmuchmail.org
Cc: Matthew Lear <matt@bubblegen.co.uk>
Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text.
Date: Tue, 11 Oct 2016 22:24:18 +0100
Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk>
X-Mailer: git-send-email 2.4.10
If an encrypted multipart message is received which contains html and
notmuch-multipart/alternative-discouraged is set to discourage "text/plain",
any encrypted parts are not decrypted during generation of the reply
text. This fixes that problem by making sure notmuch-mua-reply does
that.
---
emacs/notmuch-mua.el | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index c567173..f333655 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -251,6 +251,10 @@ mutiple parts get a header."
(notmuch-show-max-text-part-size 0)
;; Insert headers for parts as appropriate for replying.
(notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function)
+ ;; Ensure that any encrypted parts are
+ ;; decrypted during the generation of the reply
+ ;; text.
+ (notmuch-show-process-crypto process-crypto)
;; Don't indent multipart sub-parts.
(notmuch-show-indent-multipart nil))
;; We don't want sigstatus buttons (an information leak and usually wrong anyway).
--
2.4.10
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re:
2016-10-11 21:24 matt
@ 2016-10-12 7:51 ` Mark Walters
2016-10-15 7:09 ` Re: Mark Walters
2016-10-17 12:01 ` Re: David Bremner
1 sibling, 1 reply; 35+ messages in thread
From: Mark Walters @ 2016-10-12 7:51 UTC (permalink / raw)
To: matt, notmuch, matt
On Tue, 11 Oct 2016, matt@bubblegen.co.uk wrote:
> From: Matthew Lear <matt@bubblegen.co.uk>
> To: notmuch@notmuchmail.org
> Cc: Matthew Lear <matt@bubblegen.co.uk>
> Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text.
> Date: Tue, 11 Oct 2016 22:24:18 +0100
> Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk>
> X-Mailer: git-send-email 2.4.10
>
> If an encrypted multipart message is received which contains html and
> notmuch-multipart/alternative-discouraged is set to discourage "text/plain",
> any encrypted parts are not decrypted during generation of the reply
> text. This fixes that problem by making sure notmuch-mua-reply does
> that.
Hi
I haven't tested this but it looks correct: more broadly I think this is
needed whenever notmuch-show has to get a part directly rather than just
from the sexp reply.
Best wishes
Mark
> ---
> emacs/notmuch-mua.el | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index c567173..f333655 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -251,6 +251,10 @@ mutiple parts get a header."
> (notmuch-show-max-text-part-size 0)
> ;; Insert headers for parts as appropriate for replying.
> (notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function)
> + ;; Ensure that any encrypted parts are
> + ;; decrypted during the generation of the reply
> + ;; text.
> + (notmuch-show-process-crypto process-crypto)
> ;; Don't indent multipart sub-parts.
> (notmuch-show-indent-multipart nil))
> ;; We don't want sigstatus buttons (an information leak and usually wrong anyway).
> --
> 2.4.10
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2016-10-12 7:51 ` Mark Walters
@ 2016-10-15 7:09 ` Mark Walters
0 siblings, 0 replies; 35+ messages in thread
From: Mark Walters @ 2016-10-15 7:09 UTC (permalink / raw)
To: matt, notmuch, matt
On Wed, 12 Oct 2016, Mark Walters <markwalters1009@gmail.com> wrote:
> On Tue, 11 Oct 2016, matt@bubblegen.co.uk wrote:
>> From: Matthew Lear <matt@bubblegen.co.uk>
>> To: notmuch@notmuchmail.org
>> Cc: Matthew Lear <matt@bubblegen.co.uk>
>> Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text.
>> Date: Tue, 11 Oct 2016 22:24:18 +0100
>> Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk>
>> X-Mailer: git-send-email 2.4.10
>>
>> If an encrypted multipart message is received which contains html and
>> notmuch-multipart/alternative-discouraged is set to discourage "text/plain",
>> any encrypted parts are not decrypted during generation of the reply
>> text. This fixes that problem by making sure notmuch-mua-reply does
>> that.
>
> Hi
>
> I haven't tested this but it looks correct: more broadly I think this is
> needed whenever notmuch-show has to get a part directly rather than just
> from the sexp reply.
Hi
Just to confirm I have now tested this -- it compiles and test suite
passes. (Note I don't have suitable encrypted messages to test).
Anyway LGTM +1
Best wishes
Mark
>
> Best wishes
>
> Mark
>
>
>> ---
>> emacs/notmuch-mua.el | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
>> index c567173..f333655 100644
>> --- a/emacs/notmuch-mua.el
>> +++ b/emacs/notmuch-mua.el
>> @@ -251,6 +251,10 @@ mutiple parts get a header."
>> (notmuch-show-max-text-part-size 0)
>> ;; Insert headers for parts as appropriate for replying.
>> (notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function)
>> + ;; Ensure that any encrypted parts are
>> + ;; decrypted during the generation of the reply
>> + ;; text.
>> + (notmuch-show-process-crypto process-crypto)
>> ;; Don't indent multipart sub-parts.
>> (notmuch-show-indent-multipart nil))
>> ;; We don't want sigstatus buttons (an information leak and usually wrong anyway).
>> --
>> 2.4.10
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2016-10-11 21:24 matt
2016-10-12 7:51 ` Mark Walters
@ 2016-10-17 12:01 ` David Bremner
1 sibling, 0 replies; 35+ messages in thread
From: David Bremner @ 2016-10-17 12:01 UTC (permalink / raw)
To: matt, notmuch, matt
matt@bubblegen.co.uk writes:
> From: Matthew Lear <matt@bubblegen.co.uk>
> To: notmuch@notmuchmail.org
> Cc: Matthew Lear <matt@bubblegen.co.uk>
> Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text.
> Date: Tue, 11 Oct 2016 22:24:18 +0100
> Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk>
> X-Mailer: git-send-email 2.4.10
Pushed to master. For future reference it would be nice if the actual
git send-email output made to the list, so I don't have to fix up the
commit message by hand.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/3] doc: add details about Xapian search syntax
@ 2015-01-25 17:58 David Bremner
2015-02-23 20:05 ` David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2015-01-25 17:58 UTC (permalink / raw)
To: Jani Nikula, notmuch
David Bremner <david@tethera.net> writes:
> Questions related to the way that probabilistic prefixes and phrases
> are handled come up quite often and it is nicer to have the documentation self contained. Hopefully putting it in subsections prevents it from being overwhelming.
Pushed the first patch to master.
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
@ 2014-05-06 13:06 David Bremner
2014-05-06 18:14 ` Jameson Graef Rollins
2014-05-06 18:26 ` Re: Tomi Ollila
0 siblings, 2 replies; 35+ messages in thread
From: David Bremner @ 2014-05-06 13:06 UTC (permalink / raw)
To: notmuch
The first of these fixes a build failure on Debian Linux/armhf (and
OS/X). If the patch seems ok, I'd like to roll it into a bug fix
release. The second is more of a suggestion to make that atomicity
test easier to debug, since it seems to find the dark corners of gdb.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2014-05-06 13:06 David Bremner
@ 2014-05-06 18:14 ` Jameson Graef Rollins
2014-05-06 18:26 ` Re: Tomi Ollila
1 sibling, 0 replies; 35+ messages in thread
From: Jameson Graef Rollins @ 2014-05-06 18:14 UTC (permalink / raw)
To: David Bremner, notmuch
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On Tue, May 06 2014, David Bremner <david@tethera.net> wrote:
> The first of these fixes a build failure on Debian Linux/armhf (and
> OS/X). If the patch seems ok, I'd like to roll it into a bug fix
> release. The second is more of a suggestion to make that atomicity
> test easier to debug, since it seems to find the dark corners of gdb.
Hey, David. It looks like Charles's series fixes some of these same
issues and more:
id:1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2014-05-06 13:06 David Bremner
2014-05-06 18:14 ` Jameson Graef Rollins
@ 2014-05-06 18:26 ` Tomi Ollila
1 sibling, 0 replies; 35+ messages in thread
From: Tomi Ollila @ 2014-05-06 18:26 UTC (permalink / raw)
To: David Bremner, notmuch
On Tue, May 06 2014, David Bremner <david@tethera.net> wrote:
> The first of these fixes a build failure on Debian Linux/armhf (and
> OS/X). If the patch seems ok, I'd like to roll it into a bug fix
> release. The second is more of a suggestion to make that atomicity
> test easier to debug, since it seems to find the dark corners of gdb.
Series LGTM.
Tomi
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: v2 man page build fixups
@ 2014-03-11 18:16 Tomi Ollila
2014-03-13 3:21 ` David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: Tomi Ollila @ 2014-03-11 18:16 UTC (permalink / raw)
To: David Bremner, notmuch
On Tue, Mar 11 2014, David Bremner <david@tethera.net> wrote:
> Here is an improved version of somewhat hasty series of last night.
>
> It incorporates fixups from Jani that he sent to me off list.
I played with the series trying various tricks and all seems to
work fine. Also it is nice to see that one line in prerst2man.py
is fixed to better shape :D
Also a command line, should anyone ever need it (I doubt ;)
$ make SPHINXBUILD=sphinx-1.0-build HAVE_SPHINX=1 build-man
worked fine.
+1
Tomi
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
2014-03-11 18:16 v2 man page build fixups Tomi Ollila
@ 2014-03-13 3:21 ` David Bremner
2014-03-17 10:55 ` Tomi Ollila
2014-03-18 10:52 ` Re: David Bremner
0 siblings, 2 replies; 35+ messages in thread
From: David Bremner @ 2014-03-13 3:21 UTC (permalink / raw)
To: notmuch
Several people observed a problem with the test T010-help not finding
the man pages anymore. To fix that, I had change the previous fix:
instead of flattening the rst2man output into one directory, I had to
move the sphinx output into a hierarchy.
Patches 1 and 3 should be the same as
id:1394539555-28334-1-git-send-email-david@tethera.net
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2014-03-13 3:21 ` David Bremner
@ 2014-03-17 10:55 ` Tomi Ollila
2014-03-18 10:52 ` Re: David Bremner
1 sibling, 0 replies; 35+ messages in thread
From: Tomi Ollila @ 2014-03-17 10:55 UTC (permalink / raw)
To: David Bremner, notmuch
On Thu, Mar 13 2014, David Bremner <david@tethera.net> wrote:
> Several people observed a problem with the test T010-help not finding
> the man pages anymore. To fix that, I had change the previous fix:
> instead of flattening the rst2man output into one directory, I had to
> move the sphinx output into a hierarchy.
These patches fix my build and tests pass. +1
Database upgraded (real men don't use backups or how did it go ?).
Tomi
>
> Patches 1 and 3 should be the same as
>
> id:1394539555-28334-1-git-send-email-david@tethera.net
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2014-03-13 3:21 ` David Bremner
2014-03-17 10:55 ` Tomi Ollila
@ 2014-03-18 10:52 ` David Bremner
1 sibling, 0 replies; 35+ messages in thread
From: David Bremner @ 2014-03-18 10:52 UTC (permalink / raw)
To: notmuch
David Bremner <david@tethera.net> writes:
> Several people observed a problem with the test T010-help not finding
> the man pages anymore. To fix that, I had change the previous fix:
> instead of flattening the rst2man output into one directory, I had to
> move the sphinx output into a hierarchy.
>
> Patches 1 and 3 should be the same as
>
> id:1394539555-28334-1-git-send-email-david@tethera.net
>
pushed this series
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [RFC Patch] start of sphinx based docs
@ 2014-01-19 18:57 David Bremner
2014-01-28 16:12 ` David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2014-01-19 18:57 UTC (permalink / raw)
To: Tomi Ollila, notmuch
Tomi Ollila <tomi.ollila@iki.fi> writes:
>
> This looks like a good plan, only Makefile & conf.py is a bit noisy
> (like Jani's original Doxyfile)
That should be easy to fix. Whoevery posted that patch was incredibly
lazy ;).
> Also;
> centos 6$ sudo yum install python-sphinx
> ...
> Downloading Packages:
> (1/5): python-babel-0.9.4-5.1.el6.noarch.rpm | 1.4 MB 00:07
> (2/5): python-jinja2-2.2.1-1.el6.x86_64.rpm | 464 kB 00:02
> (3/5): python-pygments-1.1.1-1.el6.noarch.rpm | 561 kB 00:02
> (4/5): python-setuptools-0.6.10-3.el6.noarch.rpm | 335 kB 00:01
> (5/5): python-sphinx-0.6.6-2.el6.noarch.rpm | 486 kB 00:02
> ---------------------------------------------------------------------------
> Total 200 kB/s | 3.2 MB 00:16
>
> (python-docutils were already installed)
> I wonder how hard it is to install these on some systems...
It's definitely a concern. We could fall back to python-docutils to
generate the manpages, since there is a standalone rst2man script there.
There are some incompatibilities about how the TH line is generated, but
I think those could be hacked around, if people thought it was worth it.
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
2014-01-19 18:57 [RFC Patch] start of sphinx based docs David Bremner
@ 2014-01-28 16:12 ` David Bremner
2014-01-28 22:54 ` Mark Walters
0 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2014-01-28 16:12 UTC (permalink / raw)
To: notmuch
Here's a second try.
- less build system cruft
- integrate into notmuch's build system
- optionally build the man pages (but not info) using just
python-docutils.
No doubt this could use polishing; I'm still looking for feedback on
the general approach.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2014-01-28 16:12 ` David Bremner
@ 2014-01-28 22:54 ` Mark Walters
2014-01-29 2:26 ` Re: David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: Mark Walters @ 2014-01-28 22:54 UTC (permalink / raw)
To: David Bremner, notmuch
Hi
I have been playing with this. One thing that is worrying me a little at
the moment is that the man page looks different from before (imo less
nice). More importantly, I can't tweak the rst to get the generated
pages to look like the current ones (this could just be my lack of skill
with rst)
I do like the general approach but would like to make sure we can get
manpages (amongst other things) that we like from it. See below for one
example which I thought looked less nice
Best wishes
Mark
The particular thing is the indentation for options (eg options in the
notmuch.1 page) In the original pages it looks like
OPTIONS
Supported global options for notmuch include
--help
Print a synopsis of available commands and exit.
and in the new ones
OPTIONS
Supported global options for notmuch include
--help
Print a synopsis of available commands and exit.
I find this makes it more difficult to scan the man page quickly.
On Tue, 28 Jan 2014, David Bremner <david@tethera.net> wrote:
> Here's a second try.
>
> - less build system cruft
>
> - integrate into notmuch's build system
>
> - optionally build the man pages (but not info) using just
> python-docutils.
>
> No doubt this could use polishing; I'm still looking for feedback on
> the general approach.
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2014-01-28 22:54 ` Mark Walters
@ 2014-01-29 2:26 ` David Bremner
0 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2014-01-29 2:26 UTC (permalink / raw)
To: Mark Walters, notmuch
Mark Walters <markwalters1009@gmail.com> writes:
>
> The particular thing is the indentation for options (eg options in the
> notmuch.1 page) In the original pages it looks like
>
> OPTIONS
> Supported global options for notmuch include
>
> --help
>
> Print a synopsis of available commands and exit.
>
> and in the new ones
>
> OPTIONS
> Supported global options for notmuch include
>
> --help
>
> Print a synopsis of available commands and exit.
>
> I find this makes it more difficult to scan the man page quickly.
This rst is mainly autogenerated, and hence a bit ugly.
This particular example doesn't seem too hard to fix; try replacing the
relevant bit of notmuch.rst with
Supported global options for \ **notmuch**\ include
\ --help
Print a synopsis of available commands and exit.
\ --version
Print the installed version of notmuch, and exit.
\ --config=FILE
Specify the configuration file to use. This overrides any
configuration file specified by ${NOTMUCH_CONFIG}.
or
Supported global options for \ **notmuch**\ include
--help Print a synopsis of available commands and exit.
--version Print the installed version of notmuch, and exit.
--config=FILE Specify the configuration file to use. This overrides any
configuration file specified by ${NOTMUCH_CONFIG}.
--help Print a synopsis of available commands and exit.
The latter is an "option list" [1], so I guess is the most official way
to do it.
The former is a more generic "definition list"
[1]
http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#option-lists
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
@ 2013-02-25 20:44 Martin Owens
2013-02-25 21:02 ` David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: Martin Owens @ 2013-02-25 20:44 UTC (permalink / raw)
To: notmuch
Dear NotMuch,
I'm getting an error from the packages in Ubuntu 13.04 (beta) version
14.1 of python-notmuch:
File "/usr/lib/python2.7/dist-packages/notmuch/database.py", line 156,
in __init__
self.create(path)
File "/usr/lib/python2.7/dist-packages/notmuch/database.py", line 191,
in create
res = Database._create(_str(path), Database.MODE.READ_WRITE)
ctypes.ArgumentError: argument 2: <type 'exceptions.TypeError'>:
expected LP_LP_NotmuchDatabaseS instance instead of int
Looking at trunk it looks like this code was rewritten completely.
Should the packages be ignored and should trunk be used instead?
Best Regards, Martin Owens
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
@ 2013-01-16 12:44 david
2013-01-17 10:36 ` David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: david @ 2013-01-16 12:44 UTC (permalink / raw)
To: notmuch
Hi Gang;
Here are some proposed changes to the debian packaging for 0.15.
Most will probably be boring to people not familiar with debian
packaging, with the excepotion of 4/5, which has a shell pipeline with
two xargs in it, and almost can certainly be improved by several
readers of this list.
[PATCH 1/5] debian: change priority to optional.
[PATCH 2/5] debian: remove Dm-Upload-Allowed field.
[PATCH 3/5] debian/compat: upgrade to compat level 9
[PATCH 4/5] debian: add python 3 bindings
[PATCH 5/5] debian: note that ical bug is fixed
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2013-01-16 12:44 david
@ 2013-01-17 10:36 ` David Bremner
0 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2013-01-17 10:36 UTC (permalink / raw)
To: notmuch
david@tethera.net writes:
> Hi Gang;
>
> Here are some proposed changes to the debian packaging for 0.15.
>
> Most will probably be boring to people not familiar with debian
> packaging, with the excepotion of 4/5, which has a shell pipeline with
> two xargs in it, and almost can certainly be improved by several
> readers of this list.
As Tomi suggested, I left this alone and pushed as is for now.
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
@ 2012-12-11 9:00 Damien Cassou
2012-12-13 11:45 ` Mark Walters
0 siblings, 1 reply; 35+ messages in thread
From: Damien Cassou @ 2012-12-11 9:00 UTC (permalink / raw)
To: notmuch
From: Damien Cassou <damien.cassou@gmail.com>
Subject: [PATCH v4] emacs: display tags in notmuch-show with links
In-Reply-To:
This patch obsoletes:
id:1355149964-27905-1-git-send-email-damien.cassou@gmail.com
[PATCH 1/4] emacs: Add a thread's tags to notmuch-show header-line
[PATCH 2/4] emacs: Make tags in notmuch-show header-line clickable
[PATCH 3/4] emacs: Make all tags in `notmuch-show' clickable
[PATCH 4/4] emacs: Add unit-tests for clickable tags
These patches make clickable all tags that appear in notmuch-show
buffers. Each tag is a link to open a new notmuch-search buffer for
this tag. Additionally, the buffer's header-line now shows the
thread's tags (clickable only if the `header-button' library is loaded
or loadable).
These patches are the first of an upcoming series whose goal is to
integrate notmuch-labeler into notmuch. See the following for more
details: https://github.com/DamienCassou/notmuch-labeler
With respect to v3, I took care of the comments you made:
- the header-line now updates when tags are changed
- the tags in the body stays clickable when tags are changed
Additionally, I added two unit tests to cover the above two comments
and fixed some others unit tests of mine.
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2012-12-11 9:00 Damien Cassou
@ 2012-12-13 11:45 ` Mark Walters
0 siblings, 0 replies; 35+ messages in thread
From: Mark Walters @ 2012-12-13 11:45 UTC (permalink / raw)
To: Damien Cassou, notmuch
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
Hi
This is looking good: I have two comments the second of which is significant.
The first is do you want to sort (alphabetically) the headerline tags?
As it stands they are in the order they appear in the thread which is
probably not what is wanted.
The second is that there is a notmuch-show-tag-all functions to tag all
messages in the thread. Your patch is quadratic for the update (as it
calculates the list of thread tags once for each message). The attached
patch would avoid this and doesn't look too bad. (Note I retained
no-headerline-update as an optional argument in case there are out of
tree callers, eg users' .emacs files)
[Note this is not purely of academic interest: on my test large thread
(178 messages) updating the display after tagging all messages took some
seconds without my patch and almost no time with it.]
Best wishes
Mark
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-mjw-tweak.patch --]
[-- Type: text/x-diff, Size: 2186 bytes --]
From ab15a4bdb50bcf6b2851806195bbe8bea3b099dc Mon Sep 17 00:00:00 2001
From: Mark Walters <markwalters1009@gmail.com>
Date: Thu, 13 Dec 2012 11:23:09 +0000
Subject: [PATCH] Avoid quadratic update
---
emacs/notmuch-show.el | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 93bce07..8dd6010 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -356,7 +356,7 @@ operation on the contents of the current buffer."
"Return a string comprised of `n' spaces."
(make-string n ? ))
-(defun notmuch-show-update-tags (tags)
+(defun notmuch-show-update-tags (tags &optional no-headerline-update)
"Update the displayed tags of the current message."
(save-excursion
(goto-char (notmuch-show-message-top))
@@ -364,7 +364,8 @@ operation on the contents of the current buffer."
(let ((inhibit-read-only t))
(replace-match (propertize (notmuch-tagger-format-tags tags)
'face 'notmuch-tag-face)))))
- (notmuch-show-update-header-line))
+ (unless no-headerline-update
+ (notmuch-show-update-header-line)))
(defun notmuch-clean-address (address)
"Try to clean a single email ADDRESS for display. Return a cons
@@ -1461,10 +1462,10 @@ current thread."
(defun notmuch-show-get-depth ()
(notmuch-show-get-prop :depth))
-(defun notmuch-show-set-tags (tags)
+(defun notmuch-show-set-tags (tags &optional no-headerline-update)
"Set the tags of the current message."
(notmuch-show-set-prop :tags tags)
- (notmuch-show-update-tags tags))
+ (notmuch-show-update-tags tags no-headerline-update))
(defun notmuch-show-get-tags ()
"Return the tags of the current message."
@@ -1778,7 +1779,8 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
(let* ((current-tags (notmuch-show-get-tags))
(new-tags (notmuch-update-tags current-tags tag-changes)))
(unless (equal current-tags new-tags)
- (notmuch-show-set-tags new-tags))))))
+ (notmuch-show-set-tags new-tags t)))))
+ (notmuch-show-update-header-line))
(defun notmuch-show-add-tag ()
"Same as `notmuch-show-tag' but sets initial input to '+'."
--
1.7.9.1
[-- Attachment #3: Type: text/plain, Size: 1489 bytes --]
On Tue, 11 Dec 2012, Damien Cassou <damien.cassou@gmail.com> wrote:
> From: Damien Cassou <damien.cassou@gmail.com>
> Subject: [PATCH v4] emacs: display tags in notmuch-show with links
> In-Reply-To:
>
> This patch obsoletes:
> id:1355149964-27905-1-git-send-email-damien.cassou@gmail.com
>
> [PATCH 1/4] emacs: Add a thread's tags to notmuch-show header-line
> [PATCH 2/4] emacs: Make tags in notmuch-show header-line clickable
> [PATCH 3/4] emacs: Make all tags in `notmuch-show' clickable
> [PATCH 4/4] emacs: Add unit-tests for clickable tags
>
> These patches make clickable all tags that appear in notmuch-show
> buffers. Each tag is a link to open a new notmuch-search buffer for
> this tag. Additionally, the buffer's header-line now shows the
> thread's tags (clickable only if the `header-button' library is loaded
> or loadable).
>
> These patches are the first of an upcoming series whose goal is to
> integrate notmuch-labeler into notmuch. See the following for more
> details: https://github.com/DamienCassou/notmuch-labeler
>
> With respect to v3, I took care of the comments you made:
> - the header-line now updates when tags are changed
> - the tags in the body stays clickable when tags are changed
>
> Additionally, I added two unit tests to cover the above two comments
> and fixed some others unit tests of mine.
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply related [flat|nested] 35+ messages in thread
* emacs: quote MML tags in replies
@ 2012-02-01 2:49 Dmitry Kurochkin
2012-02-02 4:01 ` David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: Dmitry Kurochkin @ 2012-02-01 2:49 UTC (permalink / raw)
To: notmuch
Hi Aaron.
Thanks for your work! I took the liberty to do some cleanups for your
patch. Below is a detailed list of changes.
Hope this helps.
Changes since v2:
* change patch names to be consistent with others:
- s/emacs:/test:/ for the test patch
- lower case the first word after colon in the patch title
* polish NEWS wording, move it to 0.12 section
* add comment to `mml-quote-region' call, as suggested by Tomi [1]
* fix and clean up the test:
- set `notmuch-fcc-dirs' to nil to avoid adding the Fcc header,
otherwise it breaks the test on other systems as pointed by
David [2]
- use default values for add_message parameters where possible
- use a sane subject value in add_message
- use shorter MML tag as produced by (mml-insert-part)
- indenting and other minor cleanups
Regards,
Dmitry
[1] id:"m2wr89ioos.fsf@guru.guru-group.fi"
[2] id:"87ehugzycb.fsf@zancas.localnet"
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
2012-02-01 2:49 emacs: quote MML tags in replies Dmitry Kurochkin
@ 2012-02-02 4:01 ` David Bremner
2012-02-03 10:22 ` Pieter Praet
0 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2012-02-02 4:01 UTC (permalink / raw)
To: notmuch
I rebased these against branch release (and copied a comment from
aaron's email), but the test fails there, as does the reply within emacs test.
FAIL Reply within emacs
--- emacs.24.expected 2012-02-02 03:55:14.000000000 +0000
+++ emacs.24.output 2012-02-02 03:55:14.000000000 +0000
@@ -1,8 +1,4 @@
From: Notmuch Test Suite <test_suite@notmuchmail.org>
-To: user@example.com
-Subject: Re: Testing message sent via SMTP
-In-Reply-To: <XXX>
-Fcc: /home/bremner/software/upstream/notmuch/test/tmp.emacs/mail/sent
+To:
+Subject:
--text follows this line--
-On 01 Jan 2000 12:00:00 -0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
-> This is a test that messages are sent via SMTP
*ERROR*: Wrong type argument: integer-or-marker-p, nil
FAIL Quote MML tags in reply
--- emacs.25.expected 2012-02-02 03:55:15.000000000 +0000
+++ emacs.25.output 2012-02-02 03:55:15.000000000 +0000
@@ -1,7 +1,4 @@
From: Notmuch Test Suite <test_suite@notmuchmail.org>
To:
-Subject: Re: Quote MML tags in reply
-In-Reply-To: <test-emacs-mml-quoting@message.id>
+Subject:
--text follows this line--
-On Fri, 05 Jan 2001 15:43:57 +0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
-> <#!part disposition=inline>
*ERROR*: Wrong type argument: integer-or-marker-p, nil
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2012-02-02 4:01 ` David Bremner
@ 2012-02-03 10:22 ` Pieter Praet
0 siblings, 0 replies; 35+ messages in thread
From: Pieter Praet @ 2012-02-03 10:22 UTC (permalink / raw)
To: David Bremner, notmuch
On Thu, 2 Feb 2012 00:01:31 -0400, David Bremner <david@tethera.net> wrote:
> I rebased these against branch release (and copied a comment from
> aaron's email), but the test fails there, as does the reply within emacs test.
>
Same issue here.
That mark was introduced in commit 03146f20, so isn't available in the
release branch yet. Let's just use `point-max' instead, merge 'release'
into 'master', and change it back to `mark' there. It's better to break
MML tags in the user's sig for a little while than leave this security
hole wide open.
Same issue wrt commit 66ecd906; the citation line should still be:
On Tue, 05 Jan 2001 15:43:57 -0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
instead of:
On Fri, 05 Jan 2001 15:43:57 +0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
Fixed patches follow, including a post-merge fix.
> FAIL Reply within emacs
> --- emacs.24.expected 2012-02-02 03:55:14.000000000 +0000
> +++ emacs.24.output 2012-02-02 03:55:14.000000000 +0000
> @@ -1,8 +1,4 @@
> From: Notmuch Test Suite <test_suite@notmuchmail.org>
> -To: user@example.com
> -Subject: Re: Testing message sent via SMTP
> -In-Reply-To: <XXX>
> -Fcc: /home/bremner/software/upstream/notmuch/test/tmp.emacs/mail/sent
> +To:
> +Subject:
> --text follows this line--
> -On 01 Jan 2000 12:00:00 -0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
> -> This is a test that messages are sent via SMTP
> *ERROR*: Wrong type argument: integer-or-marker-p, nil
> FAIL Quote MML tags in reply
> --- emacs.25.expected 2012-02-02 03:55:15.000000000 +0000
> +++ emacs.25.output 2012-02-02 03:55:15.000000000 +0000
> @@ -1,7 +1,4 @@
> From: Notmuch Test Suite <test_suite@notmuchmail.org>
> To:
> -Subject: Re: Quote MML tags in reply
> -In-Reply-To: <test-emacs-mml-quoting@message.id>
> +Subject:
> --text follows this line--
> -On Fri, 05 Jan 2001 15:43:57 +0000, Notmuch Test Suite <test_suite@notmuchmail.org> wrote:
> -> <#!part disposition=inline>
> *ERROR*: Wrong type argument: integer-or-marker-p, nil
>
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
Peace
--
Pieter
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: show-mode message/thread archiving improvements
@ 2012-01-23 8:33 Jameson Graef Rollins
2012-01-25 0:06 ` Jameson Graef Rollins
0 siblings, 1 reply; 35+ messages in thread
From: Jameson Graef Rollins @ 2012-01-23 8:33 UTC (permalink / raw)
To: Notmuch Mail
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
v2 of this series to follow, based on some good feedback from David and
Aaron.
Reminder:
> The last patch changes the default keybind for the 'a' key to archive
> just the current message, and not the entire thread. In my opinion this
> is a *much* more sensible binding for this key. I actually rebound to
> this immediately after I started using notmuch long ago. It also adds a
> new 'A' that performs the old function to archive the entire thread and
> move on.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: output file argument to notmuch dump.
@ 2011-10-09 16:01 David Bremner
2011-10-10 13:49 ` david
0 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2011-10-09 16:01 UTC (permalink / raw)
To: notmuch
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Thu, 06 Oct 2011 21:20:40 -0300, David Bremner <bremner@unb.ca> wrote:
>
> I'd like to add a search term argument to notmuch dump (see
> id:"87wrcijn1w.fsf@zancas.localnet" and followup for context). The
> "notmuch" way would be to have
>
> notmuch dump <search-term>
>
> do the right thing
Another option occured to me that is consistent at least with notmuch
tag and notmuch show would be to support the following transitional
syntaxes
notmuch dump file
notmuch dump file [--] search terms
notmuch dump -- search terms
the first two could then be deprecated, and eventually the syntax
notmuch dump search terms
could be enabled.
the question of whether to support
notmuch dump --file foo.txt
or something like
notmuch --stdout=foo.txt dump
could be dealt with later.
David
[-- Attachment #2: Type: application/pgp-signature, Size: 315 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* (no subject)
2011-10-09 16:01 output file argument to notmuch dump David Bremner
@ 2011-10-10 13:49 ` david
2011-10-16 20:34 ` Thomas Schwinge
0 siblings, 1 reply; 35+ messages in thread
From: david @ 2011-10-10 13:49 UTC (permalink / raw)
To: notmuch
OK, here is my proposal to add search terms to notmuch dump.
Most of the work is in argument processing. It would be nice if we
could factor some of that out.
02be821 notmuch-dump: deprecate use of output file argument.
2b7781d test: all dump-restore tests should be working now
7a203d6 notmuch-dump: treat any remaining arguments after the filename as search t
be762d9 notmuch-dump: update handling of file name argument
d6715d7 test: add tests for command line arguments to notmuch-dump
08e76cc test: update dump-restore to use redirection instead of filename args
notmuch-dump.c | 37 ++++++++++++++++++++++++++-----------
test/dump-restore | 39 ++++++++++++++++++++++++++++++++++-----
2 files changed, 60 insertions(+), 16 deletions(-)
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re:
2011-10-10 13:49 ` david
@ 2011-10-16 20:34 ` Thomas Schwinge
2011-10-16 23:25 ` Re: David Bremner
0 siblings, 1 reply; 35+ messages in thread
From: Thomas Schwinge @ 2011-10-16 20:34 UTC (permalink / raw)
To: david; +Cc: notmuch
[-- Attachment #1: Type: text/plain, Size: 2038 bytes --]
Hi!
On Mon, 10 Oct 2011 10:49:15 -0300, david@tethera.net wrote:
> OK, here is my proposal to add search terms to notmuch dump.
Having worked in the same area ;-), I felt competent to review this. And
I definitely do like David's approach. The patches look good, with the
following comments:
What's missing is adding (roughly) the same text to the notmuch manpage,
``notmuch help dump'', NEWS file. These should be added to the
respective patches, for enhance functionality and deprecation of output
filename.
> 2b7781d test: all dump-restore tests should be working now
> 7a203d6 notmuch-dump: treat any remaining arguments after the filename as search t
I would suggest to combine these two into one patch: enhance
implementation (7a203d6) and update the tests (2b7781d) is one unit.
> d6715d7 test: add tests for command line arguments to notmuch-dump
Specifically:
On Mon, 10 Oct 2011 10:49:17 -0300, david@tethera.net wrote:
> The plan is to add the possibility of search terms after the file name,
> and the use of -- to stop looking for an output file name.
> ---
> test/dump-restore | 28 ++++++++++++++++++++++++++++
> 1 files changed, 28 insertions(+), 0 deletions(-)
>
> diff --git a/test/dump-restore b/test/dump-restore
> index 96c4f19..699337c 100755
> --- a/test/dump-restore
> +++ b/test/dump-restore
> @@ -8,6 +8,34 @@ test_expect_success "Dumping all tags" "generate_message &&
> notmuch new &&
> notmuch dump > dump.expected"
>
> +test_begin_subtest "dump outfile"
> +notmuch dump dump-outfile.actual
> +test_expect_equal_file dump.expected dump-outfile.actual
> +
> +test_begin_subtest "dump outfile --"
> +notmuch dump dump-1-arg-dash.actual
> +test_expect_equal_file dump.expected dump-1-arg-dash.actual
>
> [...]
I don't understand the purpose of the second test above. Was this meant
to be ``notmuch dump dump-1-arg-dash.actual --'' (as suggested by the
description), or ``notmuch dump -- > dump-1-arg-dash.actual''?
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
end of thread, other threads:[~2018-02-03 22:38 UTC | newest]
Thread overview: 35+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-03 21:18 David Bremner
2014-10-03 21:18 ` [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures David Bremner
2014-10-17 8:34 ` Jani Nikula
2014-10-18 6:02 ` David Bremner
2014-10-18 6:30 ` David Bremner
2014-10-03 21:18 ` [Patch v2.5 2/4] cli/insert: add fail path to add_file_to_database David Bremner
2014-10-03 21:18 ` [Patch v2.5 3/4] cli/insert: require succesful message indexing for success status David Bremner
2014-10-03 21:19 ` [Patch v2.5 4/4] test/insert: check that indexing errors are accepted with --keep David Bremner
2014-10-03 21:22 ` David Bremner
2014-10-04 6:56 ` tests for notmuch-insert David Bremner
2014-10-16 21:14 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2018-02-01 20:53 Matthew Lear
2018-02-03 22:38 ` Jani Nikula
2017-06-11 11:00 [PATCH] Add Emacs' imenu support in notmuch-show and notmuch-search David Bremner
2017-06-12 13:30 ` Damien Cassou
2017-06-14 1:22 ` David Bremner
2017-06-14 9:44 ` Re: David Bremner
2017-06-14 9:54 ` Re: Damien Cassou
2017-05-23 18:54 Tomi Ollila
2017-05-26 10:40 ` David Bremner
2016-10-15 8:44 Re: Matthew Lear
2016-10-13 19:37 Matt Armstrong
2016-10-13 19:42 ` Matt Armstrong
2016-10-11 21:24 matt
2016-10-12 7:51 ` Mark Walters
2016-10-15 7:09 ` Re: Mark Walters
2016-10-17 12:01 ` Re: David Bremner
2015-01-25 17:58 [PATCH 1/3] doc: add details about Xapian search syntax David Bremner
2015-02-23 20:05 ` David Bremner
2015-02-24 7:32 ` David Bremner
2014-05-06 13:06 David Bremner
2014-05-06 18:14 ` Jameson Graef Rollins
2014-05-06 18:26 ` Re: Tomi Ollila
2014-03-11 18:16 v2 man page build fixups Tomi Ollila
2014-03-13 3:21 ` David Bremner
2014-03-17 10:55 ` Tomi Ollila
2014-03-18 10:52 ` Re: David Bremner
2014-01-19 18:57 [RFC Patch] start of sphinx based docs David Bremner
2014-01-28 16:12 ` David Bremner
2014-01-28 22:54 ` Mark Walters
2014-01-29 2:26 ` Re: David Bremner
2013-02-25 20:44 Martin Owens
2013-02-25 21:02 ` David Bremner
2013-01-16 12:44 david
2013-01-17 10:36 ` David Bremner
2012-12-11 9:00 Damien Cassou
2012-12-13 11:45 ` Mark Walters
2012-02-01 2:49 emacs: quote MML tags in replies Dmitry Kurochkin
2012-02-02 4:01 ` David Bremner
2012-02-03 10:22 ` Pieter Praet
2012-01-23 8:33 show-mode message/thread archiving improvements Jameson Graef Rollins
2012-01-25 0:06 ` Jameson Graef Rollins
2012-01-31 3:28 ` David Bremner
2011-10-09 16:01 output file argument to notmuch dump David Bremner
2011-10-10 13:49 ` david
2011-10-16 20:34 ` Thomas Schwinge
2011-10-16 23:25 ` Re: David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).