From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 84A85429E26 for ; Sun, 16 Oct 2011 16:25:41 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EnfEuLKI0CHa for ; Sun, 16 Oct 2011 16:25:41 -0700 (PDT) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id BF89C429E25 for ; Sun, 16 Oct 2011 16:25:40 -0700 (PDT) Received: from zancas.localnet (fctnnbsc36w-156034064058.pppoe-dynamic.High-Speed.nb.bellaliant.net [156.34.64.58]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p9GNPcri006302 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Sun, 16 Oct 2011 20:25:39 -0300 Received: from bremner by zancas.localnet with local (Exim 4.76) (envelope-from ) id 1RFa5K-0001sw-Lo; Sun, 16 Oct 2011 20:25:38 -0300 From: David Bremner To: Thomas Schwinge Subject: Re: In-Reply-To: <87ipno1xre.fsf@kepler.schwinge.homeip.net> References: <8739f2qhla.fsf@zancas.localnet> <1318254561-25386-1-git-send-email-david@tethera.net> <87ipno1xre.fsf@kepler.schwinge.homeip.net> User-Agent: Notmuch/0.9 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sun, 16 Oct 2011 20:25:38 -0300 Message-ID: <87obxgbjt9.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2011 23:25:41 -0000 On Sun, 16 Oct 2011 22:34:29 +0200, Thomas Schwinge wrote: > Having worked in the same area ;-), I felt competent to review this. And > I definitely do like David's approach. The patches look good, with the > following comments: Thanks for the review. I pushed a modified version of the series which I think fixed all of the things you noticed. d