* (no subject)
@ 2016-10-11 21:24 matt
2016-10-12 7:51 ` Mark Walters
2016-10-17 12:01 ` Re: David Bremner
0 siblings, 2 replies; 4+ messages in thread
From: matt @ 2016-10-11 21:24 UTC (permalink / raw)
To: notmuch, matt
From: Matthew Lear <matt@bubblegen.co.uk>
To: notmuch@notmuchmail.org
Cc: Matthew Lear <matt@bubblegen.co.uk>
Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text.
Date: Tue, 11 Oct 2016 22:24:18 +0100
Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk>
X-Mailer: git-send-email 2.4.10
If an encrypted multipart message is received which contains html and
notmuch-multipart/alternative-discouraged is set to discourage "text/plain",
any encrypted parts are not decrypted during generation of the reply
text. This fixes that problem by making sure notmuch-mua-reply does
that.
---
emacs/notmuch-mua.el | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index c567173..f333655 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -251,6 +251,10 @@ mutiple parts get a header."
(notmuch-show-max-text-part-size 0)
;; Insert headers for parts as appropriate for replying.
(notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function)
+ ;; Ensure that any encrypted parts are
+ ;; decrypted during the generation of the reply
+ ;; text.
+ (notmuch-show-process-crypto process-crypto)
;; Don't indent multipart sub-parts.
(notmuch-show-indent-multipart nil))
;; We don't want sigstatus buttons (an information leak and usually wrong anyway).
--
2.4.10
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re:
2016-10-11 21:24 matt
@ 2016-10-12 7:51 ` Mark Walters
2016-10-15 7:09 ` Re: Mark Walters
2016-10-17 12:01 ` Re: David Bremner
1 sibling, 1 reply; 4+ messages in thread
From: Mark Walters @ 2016-10-12 7:51 UTC (permalink / raw)
To: matt, notmuch, matt
On Tue, 11 Oct 2016, matt@bubblegen.co.uk wrote:
> From: Matthew Lear <matt@bubblegen.co.uk>
> To: notmuch@notmuchmail.org
> Cc: Matthew Lear <matt@bubblegen.co.uk>
> Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text.
> Date: Tue, 11 Oct 2016 22:24:18 +0100
> Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk>
> X-Mailer: git-send-email 2.4.10
>
> If an encrypted multipart message is received which contains html and
> notmuch-multipart/alternative-discouraged is set to discourage "text/plain",
> any encrypted parts are not decrypted during generation of the reply
> text. This fixes that problem by making sure notmuch-mua-reply does
> that.
Hi
I haven't tested this but it looks correct: more broadly I think this is
needed whenever notmuch-show has to get a part directly rather than just
from the sexp reply.
Best wishes
Mark
> ---
> emacs/notmuch-mua.el | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index c567173..f333655 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -251,6 +251,10 @@ mutiple parts get a header."
> (notmuch-show-max-text-part-size 0)
> ;; Insert headers for parts as appropriate for replying.
> (notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function)
> + ;; Ensure that any encrypted parts are
> + ;; decrypted during the generation of the reply
> + ;; text.
> + (notmuch-show-process-crypto process-crypto)
> ;; Don't indent multipart sub-parts.
> (notmuch-show-indent-multipart nil))
> ;; We don't want sigstatus buttons (an information leak and usually wrong anyway).
> --
> 2.4.10
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re:
2016-10-12 7:51 ` Mark Walters
@ 2016-10-15 7:09 ` Mark Walters
0 siblings, 0 replies; 4+ messages in thread
From: Mark Walters @ 2016-10-15 7:09 UTC (permalink / raw)
To: matt, notmuch, matt
On Wed, 12 Oct 2016, Mark Walters <markwalters1009@gmail.com> wrote:
> On Tue, 11 Oct 2016, matt@bubblegen.co.uk wrote:
>> From: Matthew Lear <matt@bubblegen.co.uk>
>> To: notmuch@notmuchmail.org
>> Cc: Matthew Lear <matt@bubblegen.co.uk>
>> Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text.
>> Date: Tue, 11 Oct 2016 22:24:18 +0100
>> Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk>
>> X-Mailer: git-send-email 2.4.10
>>
>> If an encrypted multipart message is received which contains html and
>> notmuch-multipart/alternative-discouraged is set to discourage "text/plain",
>> any encrypted parts are not decrypted during generation of the reply
>> text. This fixes that problem by making sure notmuch-mua-reply does
>> that.
>
> Hi
>
> I haven't tested this but it looks correct: more broadly I think this is
> needed whenever notmuch-show has to get a part directly rather than just
> from the sexp reply.
Hi
Just to confirm I have now tested this -- it compiles and test suite
passes. (Note I don't have suitable encrypted messages to test).
Anyway LGTM +1
Best wishes
Mark
>
> Best wishes
>
> Mark
>
>
>> ---
>> emacs/notmuch-mua.el | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
>> index c567173..f333655 100644
>> --- a/emacs/notmuch-mua.el
>> +++ b/emacs/notmuch-mua.el
>> @@ -251,6 +251,10 @@ mutiple parts get a header."
>> (notmuch-show-max-text-part-size 0)
>> ;; Insert headers for parts as appropriate for replying.
>> (notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function)
>> + ;; Ensure that any encrypted parts are
>> + ;; decrypted during the generation of the reply
>> + ;; text.
>> + (notmuch-show-process-crypto process-crypto)
>> ;; Don't indent multipart sub-parts.
>> (notmuch-show-indent-multipart nil))
>> ;; We don't want sigstatus buttons (an information leak and usually wrong anyway).
>> --
>> 2.4.10
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re:
2016-10-11 21:24 matt
2016-10-12 7:51 ` Mark Walters
@ 2016-10-17 12:01 ` David Bremner
1 sibling, 0 replies; 4+ messages in thread
From: David Bremner @ 2016-10-17 12:01 UTC (permalink / raw)
To: matt, notmuch, matt
matt@bubblegen.co.uk writes:
> From: Matthew Lear <matt@bubblegen.co.uk>
> To: notmuch@notmuchmail.org
> Cc: Matthew Lear <matt@bubblegen.co.uk>
> Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text.
> Date: Tue, 11 Oct 2016 22:24:18 +0100
> Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk>
> X-Mailer: git-send-email 2.4.10
Pushed to master. For future reference it would be nice if the actual
git send-email output made to the list, so I don't have to fix up the
commit message by hand.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-17 12:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-11 21:24 matt
2016-10-12 7:51 ` Mark Walters
2016-10-15 7:09 ` Re: Mark Walters
2016-10-17 12:01 ` Re: David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).