From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures
Date: Sat, 18 Oct 2014 08:30:02 +0200 [thread overview]
Message-ID: <87vbnh51qt.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <87y4sd530r.fsf@maritornes.cs.unb.ca>
David Bremner <david@tethera.net> writes:
> Jani Nikula <jani@nikula.org> writes:
>
>> On Sat, 04 Oct 2014, David Bremner <david@tethera.net> wrote:
>>> These tests are written with the assumption that we want all indexing
>>> failures to be considered as failures by notmuch insert.
>>
>> Just realized this needs a missing prereq test for gdb.
>>
>> BR,
>> Jani.
>
> oops. missed this until after I pushed. I'll look into it ASAP.
I took the liberty of pushing a one-line build fix. I'm not 100%
certain, but I think the usage of "test_require_external_prereq" in
T380-atomicity.sh could be simplified in a similary way.
d
next prev parent reply other threads:[~2014-10-18 6:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 21:18 David Bremner
2014-10-03 21:18 ` [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures David Bremner
2014-10-17 8:34 ` Jani Nikula
2014-10-18 6:02 ` David Bremner
2014-10-18 6:30 ` David Bremner [this message]
2014-10-03 21:18 ` [Patch v2.5 2/4] cli/insert: add fail path to add_file_to_database David Bremner
2014-10-03 21:18 ` [Patch v2.5 3/4] cli/insert: require succesful message indexing for success status David Bremner
2014-10-03 21:19 ` [Patch v2.5 4/4] test/insert: check that indexing errors are accepted with --keep David Bremner
2014-10-03 21:22 ` David Bremner
2014-10-04 6:56 ` tests for notmuch-insert David Bremner
2014-10-16 21:14 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbnh51qt.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).