From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures
Date: Fri, 17 Oct 2014 11:34:45 +0300 [thread overview]
Message-ID: <87siin2ixm.fsf@nikula.org> (raw)
In-Reply-To: <1412371140-21051-2-git-send-email-david@tethera.net>
On Sat, 04 Oct 2014, David Bremner <david@tethera.net> wrote:
> These tests are written with the assumption that we want all indexing
> failures to be considered as failures by notmuch insert.
Just realized this needs a missing prereq test for gdb.
BR,
Jani.
> ---
> test/T070-insert.sh | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/test/T070-insert.sh b/test/T070-insert.sh
> index ea9db07..40a7636 100755
> --- a/test/T070-insert.sh
> +++ b/test/T070-insert.sh
> @@ -183,4 +183,26 @@ test_expect_code 1 "Invalid tags set exit code" \
>
> notmuch config set new.tags $OLDCONFIG
>
> +# DUPLICATE_MESSAGE_ID is not tested here, because it should actually pass.
> +
> +for code in OUT_OF_MEMORY XAPIAN_EXCEPTION FILE_NOT_EMAIL \
> + READ_ONLY_DATABASE UPGRADE_REQUIRED; do
> +gen_insert_msg
> +cat <<EOF > index-file-$code.gdb
> +file notmuch
> +set breakpoint pending on
> +break notmuch_database_add_message
> +commands
> +return NOTMUCH_STATUS_$code
> +continue
> +end
> +run
> +EOF
> +test_begin_subtest "error exit when add_message returns $code"
> +test_subtest_known_broken
> +gdb --batch-silent --return-child-result -x index-file-$code.gdb \
> + --args notmuch insert < $gen_msg_filename
> +test_expect_equal $? 1
> +done
> +
> test_done
> --
> 2.1.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-10-17 8:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 21:18 David Bremner
2014-10-03 21:18 ` [Patch v2.5 1/4] test/insert: add known broken tests for indexing failures David Bremner
2014-10-17 8:34 ` Jani Nikula [this message]
2014-10-18 6:02 ` David Bremner
2014-10-18 6:30 ` David Bremner
2014-10-03 21:18 ` [Patch v2.5 2/4] cli/insert: add fail path to add_file_to_database David Bremner
2014-10-03 21:18 ` [Patch v2.5 3/4] cli/insert: require succesful message indexing for success status David Bremner
2014-10-03 21:19 ` [Patch v2.5 4/4] test/insert: check that indexing errors are accepted with --keep David Bremner
2014-10-03 21:22 ` David Bremner
2014-10-04 6:56 ` tests for notmuch-insert David Bremner
2014-10-16 21:14 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siin2ixm.fsf@nikula.org \
--to=jani@nikula.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).