From: Matthew Lear <matt@bubblegen.co.uk>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re:
Date: Sat, 15 Oct 2016 09:44:00 +0100 [thread overview]
Message-ID: <j46gij965blrtah0rjvbuqys.1476521040936@email.android.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2594 bytes --]
Hi Mark. Excellent :-) I'll look out for it in the repository at some point soon. Cheers, Matt
-------- Original message --------From: Mark Walters <markwalters1009@gmail.com> Date: 15/10/2016 08:09 (GMT+00:00) To: matt@bubblegen.co.uk, notmuch@notmuchmail.org, matt@bubblegen.co.uk Subject: Re:
On Wed, 12 Oct 2016, Mark Walters <markwalters1009@gmail.com> wrote:
> On Tue, 11 Oct 2016, matt@bubblegen.co.uk wrote:
>> From: Matthew Lear <matt@bubblegen.co.uk>
>> To: notmuch@notmuchmail.org
>> Cc: Matthew Lear <matt@bubblegen.co.uk>
>> Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text.
>> Date: Tue, 11 Oct 2016 22:24:18 +0100
>> Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk>
>> X-Mailer: git-send-email 2.4.10
>>
>> If an encrypted multipart message is received which contains html and
>> notmuch-multipart/alternative-discouraged is set to discourage "text/plain",
>> any encrypted parts are not decrypted during generation of the reply
>> text. This fixes that problem by making sure notmuch-mua-reply does
>> that.
>
> Hi
>
> I haven't tested this but it looks correct: more broadly I think this is
> needed whenever notmuch-show has to get a part directly rather than just
> from the sexp reply.
Hi
Just to confirm I have now tested this -- it compiles and test suite
passes. (Note I don't have suitable encrypted messages to test).
Anyway LGTM +1
Best wishes
Mark
>
> Best wishes
>
> Mark
>
>
>> ---
>> emacs/notmuch-mua.el | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
>> index c567173..f333655 100644
>> --- a/emacs/notmuch-mua.el
>> +++ b/emacs/notmuch-mua.el
>> @@ -251,6 +251,10 @@ mutiple parts get a header."
>> (notmuch-show-max-text-part-size 0)
>> ;; Insert headers for parts as appropriate for replying.
>> (notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function)
>> + ;; Ensure that any encrypted parts are
>> + ;; decrypted during the generation of the reply
>> + ;; text.
>> + (notmuch-show-process-crypto process-crypto)
>> ;; Don't indent multipart sub-parts.
>> (notmuch-show-indent-multipart nil))
>> ;; We don't want sigstatus buttons (an information leak and usually wrong anyway).
>> --
>> 2.4.10
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch
[-- Attachment #2: Type: text/html, Size: 3660 bytes --]
next reply other threads:[~2016-10-15 8:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 8:44 Matthew Lear [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-01 20:53 Matthew Lear
2018-02-03 22:38 ` Jani Nikula
2017-06-11 11:00 [PATCH] Add Emacs' imenu support in notmuch-show and notmuch-search David Bremner
2017-06-12 13:30 ` Damien Cassou
2017-06-14 1:22 ` David Bremner
2017-06-14 9:44 ` Re: David Bremner
2017-06-14 9:54 ` Re: Damien Cassou
2017-05-23 18:54 Tomi Ollila
2017-05-26 10:40 ` David Bremner
2016-10-13 19:37 Matt Armstrong
2016-10-13 19:42 ` Matt Armstrong
2016-10-11 21:24 matt
2016-10-12 7:51 ` Mark Walters
2016-10-15 7:09 ` Re: Mark Walters
2016-10-17 12:01 ` Re: David Bremner
2015-01-25 17:58 [PATCH 1/3] doc: add details about Xapian search syntax David Bremner
2015-02-23 20:05 ` David Bremner
2015-02-24 7:32 ` David Bremner
2014-10-03 21:18 David Bremner
2014-10-03 21:22 ` David Bremner
2014-10-16 21:14 ` Re: Jani Nikula
2014-05-06 13:06 David Bremner
2014-05-06 18:14 ` Jameson Graef Rollins
2014-05-06 18:26 ` Re: Tomi Ollila
2014-03-11 18:16 v2 man page build fixups Tomi Ollila
2014-03-13 3:21 ` David Bremner
2014-03-17 10:55 ` Tomi Ollila
2014-03-18 10:52 ` Re: David Bremner
2014-01-19 18:57 [RFC Patch] start of sphinx based docs David Bremner
2014-01-28 16:12 ` David Bremner
2014-01-28 22:54 ` Mark Walters
2014-01-29 2:26 ` Re: David Bremner
2013-02-25 20:44 Martin Owens
2013-02-25 21:02 ` David Bremner
2013-01-16 12:44 david
2013-01-17 10:36 ` David Bremner
2012-12-11 9:00 Damien Cassou
2012-12-13 11:45 ` Mark Walters
2012-02-01 2:49 emacs: quote MML tags in replies Dmitry Kurochkin
2012-02-02 4:01 ` David Bremner
2012-02-03 10:22 ` Pieter Praet
2012-01-23 8:33 show-mode message/thread archiving improvements Jameson Graef Rollins
2012-01-25 0:06 ` Jameson Graef Rollins
2012-01-31 3:28 ` David Bremner
2011-10-09 16:01 output file argument to notmuch dump David Bremner
2011-10-10 13:49 ` david
2011-10-16 20:34 ` Thomas Schwinge
2011-10-16 23:25 ` Re: David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=j46gij965blrtah0rjvbuqys.1476521040936@email.android.com \
--to=matt@bubblegen.co.uk \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).