From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 615BC6DE024A for ; Sat, 15 Oct 2016 00:09:37 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.028 X-Spam-Level: X-Spam-Status: No, score=0.028 tagged_above=-999 required=5 tests=[AWL=-0.102, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3AMo1AxzYwvf for ; Sat, 15 Oct 2016 00:09:36 -0700 (PDT) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by arlo.cworth.org (Postfix) with ESMTPS id CC5B46DE00AC for ; Sat, 15 Oct 2016 00:09:35 -0700 (PDT) Received: by mail-wm0-f43.google.com with SMTP id d128so18573636wmf.1 for ; Sat, 15 Oct 2016 00:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=LiWLE9AIGIjB+21DOMS0Gx3iCkRHrxikvJV0C6KuTzw=; b=xFlktLrVvV5mrr5lmHKxVB3DryG0B5MIze+VeexoARk1uMGd1bJL/aAjG3VhRT86FF 17R2S8KUqT34Fx37PQQKtR82dcBO3rOFrZKSaZuJQoa9Bs5LsBTc6GywDHUNnV3aStNA p9PCUB/zYtK9dF4kYZ97+VHkKAtV72ddng+iIXRjylxgX5loulfpWoKigtDOr2YAw6eD /X9wqFUVBjYoOwS/PxAN3oHVPZz2gLsaUCdX375szbG+pjB6AD2Tti1mVBbXQDy4Dkhg MPM7kXtFNKQ8ZrYC84QusTXHk83dFS3B2098+jfvmEd648BP+cfz/pgI67GEQUnB3xTq L6QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=LiWLE9AIGIjB+21DOMS0Gx3iCkRHrxikvJV0C6KuTzw=; b=JSj1T1zFVLeCnxHE1FcicaC0Pc9jiObhkAw8Cr4AQoM6McIc1uRY+Ywrh/plE3J84W 4mhAKlyYnvpJrTXBxGJfn9uTmoEkV10EO/ZuH3+Ug9pU0sxz/Z8eAdt/NnPErMJJMBOP LOdG7Vm+zNeggH2bdG2jdWLsaMQdg6vb3+owf85s3l+XwJl2rVdCwIbU7pVnHeLE8uiO jJnVXk0+VLHyO/AA4m9Je69axp/6j75GH+EupqZnxsQAIypFvwH33zMKPAt/9c6OIEon HC8Omuz3z7yCLrnMLQIwbzQSmylC4Pdxas3iLmL5MOA/wYr8lDlcOIJ6olvSHy0Jc5qu ZfEQ== X-Gm-Message-State: AA6/9Rnmy3J8SNgvwgY0iUwYcZpTQbMrdsADFxcxHu5G49RLPvIpEjCFDo8pum8VT1i0jg== X-Received: by 10.194.153.66 with SMTP id ve2mr4605963wjb.82.1476515374340; Sat, 15 Oct 2016 00:09:34 -0700 (PDT) Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) by smtp.gmail.com with ESMTPSA id 186sm2066798wmf.8.2016.10.15.00.09.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Oct 2016 00:09:33 -0700 (PDT) From: Mark Walters To: matt@bubblegen.co.uk, notmuch@notmuchmail.org, matt@bubblegen.co.uk Subject: Re: In-Reply-To: <87zima9f8v.fsf@qmul.ac.uk> References: <20161011212430.4F5E62406AF@bubblegen.co.uk> <87zima9f8v.fsf@qmul.ac.uk> Date: Sat, 15 Oct 2016 08:09:33 +0100 Message-ID: <87shry5brm.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Oct 2016 07:09:37 -0000 On Wed, 12 Oct 2016, Mark Walters wrote: > On Tue, 11 Oct 2016, matt@bubblegen.co.uk wrote: >> From: Matthew Lear >> To: notmuch@notmuchmail.org >> Cc: Matthew Lear >> Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text. >> Date: Tue, 11 Oct 2016 22:24:18 +0100 >> Message-Id: <1476221058-10431-1-git-send-email-matt@bubblegen.co.uk> >> X-Mailer: git-send-email 2.4.10 >> >> If an encrypted multipart message is received which contains html and >> notmuch-multipart/alternative-discouraged is set to discourage "text/plain", >> any encrypted parts are not decrypted during generation of the reply >> text. This fixes that problem by making sure notmuch-mua-reply does >> that. > > Hi > > I haven't tested this but it looks correct: more broadly I think this is > needed whenever notmuch-show has to get a part directly rather than just > from the sexp reply. Hi Just to confirm I have now tested this -- it compiles and test suite passes. (Note I don't have suitable encrypted messages to test). Anyway LGTM +1 Best wishes Mark > > Best wishes > > Mark > > >> --- >> emacs/notmuch-mua.el | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el >> index c567173..f333655 100644 >> --- a/emacs/notmuch-mua.el >> +++ b/emacs/notmuch-mua.el >> @@ -251,6 +251,10 @@ mutiple parts get a header." >> (notmuch-show-max-text-part-size 0) >> ;; Insert headers for parts as appropriate for replying. >> (notmuch-show-insert-header-p-function notmuch-mua-reply-insert-header-p-function) >> + ;; Ensure that any encrypted parts are >> + ;; decrypted during the generation of the reply >> + ;; text. >> + (notmuch-show-process-crypto process-crypto) >> ;; Don't indent multipart sub-parts. >> (notmuch-show-indent-multipart nil)) >> ;; We don't want sigstatus buttons (an information leak and usually wrong anyway). >> -- >> 2.4.10 >> >> _______________________________________________ >> notmuch mailing list >> notmuch@notmuchmail.org >> https://notmuchmail.org/mailman/listinfo/notmuch