From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEVsd-0003DZ-48 for guix-patches@gnu.org; Mon, 22 Oct 2018 04:48:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEVsY-0007na-Ej for guix-patches@gnu.org; Mon, 22 Oct 2018 04:48:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59075) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gEVsY-0007nS-9K for guix-patches@gnu.org; Mon, 22 Oct 2018 04:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gEVsY-0006dw-4i for guix-patches@gnu.org; Mon, 22 Oct 2018 04:48:02 -0400 Subject: [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Resent-Message-ID: MIME-Version: 1.0 References: <8736t12frf.fsf@mdc-berlin.de> <87zhv81etw.fsf@mdc-berlin.de> In-Reply-To: From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Mon, 22 Oct 2018 10:46:59 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Laura Lazzati Cc: Ricardo Wurmus , 33099@debbugs.gnu.org Hello Laura, Almost there! Laura Lazzati ezt =C3=ADrta (id=C5=91pont: 201= 8. okt. 21., V, 23:54): > > From 3628e4d7d4814777bb748c3f0ebba133814b2b94 Mon Sep 17 00:00:00 2001 > From: laura > Date: Sun, 21 Oct 2018 18:38:58 -0300 > Subject: [PATCH] gnu: Add r-aspi > > * gnu/packages/cran.scm (r-aspi): New variable > --- > gnu/packages/cran.scm | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > Just a bit knitpicking, could you add the periods to the commit message, li= ke: gnu: Add r-aspi. * gnu/packages/patches/cran.scm (r-aspi): New variable. > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm > index efcc2dccb..c219065e8 100644 > --- a/gnu/packages/cran.scm > +++ b/gnu/packages/cran.scm > @@ -6256,3 +6256,24 @@ a header row or not. The dataset should > contain only one independent variable > (x) and one dependent variable (y) and can contain a weight for each > observation.") > (license license:gpl2))) > + > +(define-public r-aspi > + (package > + (name "r-aspi") > + (version "0.2.0") > + (source > + (origin > + (method url-fetch) > + (uri (cran-uri "aspi" version)) > + (sha256 > + (base32 > + "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87")))) > + (build-system r-build-system) > + (home-page > + "http://cran.r-project.org/web/packages/aspi") > + (synopsis > + "Analysis of symmetry of parasitic infections") > + (description > + "This package provides tools for the analysis and visualization > of bilateral > + asymmetry in parasitic infections.") > + (license license:gpl3+))) > -- > 2.17.1 > This is fine now. I still see these strange line breaks in the patch, how does that look on you side? Can you apply you own patches using git am? You can send an updated patch with the corrected commit message, or I can apply these minor changes and push it. WDYT? Best regards, g_bor