From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDyuk-0006zy-6L for guix-patches@gnu.org; Sat, 20 Oct 2018 17:36:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDyug-0000rV-64 for guix-patches@gnu.org; Sat, 20 Oct 2018 17:36:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57495) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDyuf-0000rP-RW for guix-patches@gnu.org; Sat, 20 Oct 2018 17:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gDyuf-0006kO-O4 for guix-patches@gnu.org; Sat, 20 Oct 2018 17:36:01 -0400 Subject: [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Resent-Message-ID: References: <8736t12frf.fsf@mdc-berlin.de> From: Ricardo Wurmus In-Reply-To: Date: Sat, 20 Oct 2018 23:35:39 +0200 Message-ID: <87zhv81etw.fsf@mdc-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Laura Lazzati Cc: =?UTF-8?Q?G=C3=A1bor?= Boskovits , 33099@debbugs.gnu.org Hi Laura, > I will apply all the changes and send the new version. > Shall I send the modified patch to the debbugs mail that is in the CC of > this mail? Yes, please. >> > > > > + (synopsis "Analysis of Symmetry of Parasitic Infections") >> > > > >> > > > Please use lowercase for all words except for the first. CRAN >> synopses >> > > > are usually in titlecase and the importer can=E2=80=99t automatica= lly figure >> out >> > > > which words should be converted, so this needs to be done manually. >> > Sorry for this, I just copied the comments in cran's website, I'll change > that. Did you not use the CRAN importer to generate this package definition? If you did not then you=E2=80=99re in for a treat as =E2=80=9Cguix import c= ran -r=E2=80=9D can *recursively* generate package definitions for packages on CRAN, even if there are dozens of dependencies. >> > > > > + (license license:gpl3))) >> > > > >> > > > I checked the source files and noticed that it=E2=80=99s actually = GPL 3 or >> > > > later. Here=E2=80=99s an except from the header of aspi.R: >> > I guess this mistake was because in one of the several times of running > ./pre-inst-env guix build r-aspi I was getting an error about the gpl > licence. I will change this too. If you used the importer this is not your fault. On CRAN the license is listed as =E2=80=9CGPL-3=E2=80=9D which the importer turns into =E2=80=9Cgp= l3=E2=80=9D. Often people declare the license as just a single version even though their own license headers permit later versions. PS: please try to reduce the amount of text you quote in replies. It=E2=80= =99s best to only leave the relevant parts that you=E2=80=99re replying to :) -- Ricardo