* Re: 01/01: gnu: gstreamer: Skip failing test on 32-bit systems.
[not found] ` <20190613121215.EBF7320949@vcs0.savannah.gnu.org>
@ 2019-06-13 17:37 ` Mark H Weaver
2019-06-16 8:00 ` Marius Bakke
0 siblings, 1 reply; 5+ messages in thread
From: Mark H Weaver @ 2019-06-13 17:37 UTC (permalink / raw)
To: Marius Bakke; +Cc: guix-devel
Hi Marius,
guix-commits@gnu.org writes:
> mbakke pushed a commit to branch staging
> in repository guix.
>
> commit 2a9d89afb6fb869dd2bdf1e9f710f487786930fc
> Author: Marius Bakke <mbakke@fastmail.com>
> Date: Thu Jun 13 14:08:32 2019 +0200
>
> gnu: gstreamer: Skip failing test on 32-bit systems.
>
> * gnu/packages/gstreamer.scm (gstreamer)[arguments]: When building for a
> 32-bit system, add #:phases.
[...]
> + ,@(if (not (target-64bit?))
> + ;; Skip test that fails on 32-bit systems:
> + ;; <https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316>.
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'check 'disable-gstbufferpool-test
> + (lambda _
> + (substitute* "tests/check/Makefile"
> + (("^[[:blank:]]+gst/gstbufferpool.*$")
> + ""))
> + #t))))
> + '())))
This might be sweeping a critical bug under the rug. Does
Unexpected critical/warning: gst_buffer_resize_range:
assertion 'bufmax >= bufoffs + offset + size' failed
really sound like something we can safely ignore?
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: 01/01: gnu: gstreamer: Skip failing test on 32-bit systems.
2019-06-13 17:37 ` 01/01: gnu: gstreamer: Skip failing test on 32-bit systems Mark H Weaver
@ 2019-06-16 8:00 ` Marius Bakke
2019-06-16 21:31 ` Mark H Weaver
2019-06-27 6:01 ` Mark H Weaver
0 siblings, 2 replies; 5+ messages in thread
From: Marius Bakke @ 2019-06-16 8:00 UTC (permalink / raw)
To: Mark H Weaver; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]
Mark,
Mark H Weaver <mhw@netris.org> writes:
> Hi Marius,
>
> guix-commits@gnu.org writes:
>
>> mbakke pushed a commit to branch staging
>> in repository guix.
>>
>> commit 2a9d89afb6fb869dd2bdf1e9f710f487786930fc
>> Author: Marius Bakke <mbakke@fastmail.com>
>> Date: Thu Jun 13 14:08:32 2019 +0200
>>
>> gnu: gstreamer: Skip failing test on 32-bit systems.
>>
>> * gnu/packages/gstreamer.scm (gstreamer)[arguments]: When building for a
>> 32-bit system, add #:phases.
> [...]
>> + ,@(if (not (target-64bit?))
>> + ;; Skip test that fails on 32-bit systems:
>> + ;; <https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316>.
>> + `(#:phases (modify-phases %standard-phases
>> + (add-before 'check 'disable-gstbufferpool-test
>> + (lambda _
>> + (substitute* "tests/check/Makefile"
>> + (("^[[:blank:]]+gst/gstbufferpool.*$")
>> + ""))
>> + #t))))
>> + '())))
>
> This might be sweeping a critical bug under the rug. Does
>
> Unexpected critical/warning: gst_buffer_resize_range:
> assertion 'bufmax >= bufoffs + offset + size' failed
>
> really sound like something we can safely ignore?
I think you are right to be concerned. I found the upstream commit that
introduced the problem. See
<https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316#note_176773>.
Do you have a preference for reverting the faulty commits, or going back
to 1.14.5?
Thanks for noticing,
Marius
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: 01/01: gnu: gstreamer: Skip failing test on 32-bit systems.
2019-06-16 8:00 ` Marius Bakke
@ 2019-06-16 21:31 ` Mark H Weaver
2019-06-27 6:01 ` Mark H Weaver
1 sibling, 0 replies; 5+ messages in thread
From: Mark H Weaver @ 2019-06-16 21:31 UTC (permalink / raw)
To: Marius Bakke; +Cc: guix-devel
Hi Marius,
Marius Bakke <mbakke@fastmail.com> writes:
> Mark H Weaver <mhw@netris.org> writes:
>
>> guix-commits@gnu.org writes:
>>
>>> mbakke pushed a commit to branch staging
>>> in repository guix.
>>>
>>> commit 2a9d89afb6fb869dd2bdf1e9f710f487786930fc
>>> Author: Marius Bakke <mbakke@fastmail.com>
>>> Date: Thu Jun 13 14:08:32 2019 +0200
>>>
>>> gnu: gstreamer: Skip failing test on 32-bit systems.
>>>
>>> * gnu/packages/gstreamer.scm (gstreamer)[arguments]: When building for a
>>> 32-bit system, add #:phases.
>> [...]
>>> + ,@(if (not (target-64bit?))
>>> + ;; Skip test that fails on 32-bit systems:
>>> + ;; <https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316>.
>>> + `(#:phases (modify-phases %standard-phases
>>> + (add-before 'check 'disable-gstbufferpool-test
>>> + (lambda _
>>> + (substitute* "tests/check/Makefile"
>>> + (("^[[:blank:]]+gst/gstbufferpool.*$")
>>> + ""))
>>> + #t))))
>>> + '())))
>>
>> This might be sweeping a critical bug under the rug. Does
>>
>> Unexpected critical/warning: gst_buffer_resize_range:
>> assertion 'bufmax >= bufoffs + offset + size' failed
>>
>> really sound like something we can safely ignore?
>
> I think you are right to be concerned. I found the upstream commit that
> introduced the problem. See
> <https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316#note_176773>.
Thanks for checking.
> Do you have a preference for reverting the faulty commits, or going back
> to 1.14.5?
It depends on the nature of the faulty commit, whether other later
commits somehow depend on it, and whether other potential security holes
were fixed since 1.14.5. Maybe use 1.14.5, possibly with cherry-picked
fixes applied as patches? I'm not sure, and I don't have time to
investigate right now, but I trust your judgement to choose the best
available option.
Thank you!
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: 01/01: gnu: gstreamer: Skip failing test on 32-bit systems.
2019-06-16 8:00 ` Marius Bakke
2019-06-16 21:31 ` Mark H Weaver
@ 2019-06-27 6:01 ` Mark H Weaver
2019-06-28 18:55 ` Marius Bakke
1 sibling, 1 reply; 5+ messages in thread
From: Mark H Weaver @ 2019-06-27 6:01 UTC (permalink / raw)
To: Marius Bakke; +Cc: guix-devel
Marius Bakke <mbakke@fastmail.com> writes:
> Mark H Weaver <mhw@netris.org> writes:
>
>> Hi Marius,
>>
>> guix-commits@gnu.org writes:
>>
>>> mbakke pushed a commit to branch staging
>>> in repository guix.
>>>
>>> commit 2a9d89afb6fb869dd2bdf1e9f710f487786930fc
>>> Author: Marius Bakke <mbakke@fastmail.com>
>>> Date: Thu Jun 13 14:08:32 2019 +0200
>>>
>>> gnu: gstreamer: Skip failing test on 32-bit systems.
>>>
>>> * gnu/packages/gstreamer.scm (gstreamer)[arguments]: When building for a
>>> 32-bit system, add #:phases.
>> [...]
>>> + ,@(if (not (target-64bit?))
>>> + ;; Skip test that fails on 32-bit systems:
>>> + ;; <https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316>.
>>> + `(#:phases (modify-phases %standard-phases
>>> + (add-before 'check 'disable-gstbufferpool-test
>>> + (lambda _
>>> + (substitute* "tests/check/Makefile"
>>> + (("^[[:blank:]]+gst/gstbufferpool.*$")
>>> + ""))
>>> + #t))))
>>> + '())))
>>
>> This might be sweeping a critical bug under the rug. Does
>>
>> Unexpected critical/warning: gst_buffer_resize_range:
>> assertion 'bufmax >= bufoffs + offset + size' failed
>>
>> really sound like something we can safely ignore?
>
> I think you are right to be concerned. I found the upstream commit that
> introduced the problem. See
> <https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316#note_176773>.
*ping*?
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-28 18:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190613121214.23499.29535@vcs0.savannah.gnu.org>
[not found] ` <20190613121215.EBF7320949@vcs0.savannah.gnu.org>
2019-06-13 17:37 ` 01/01: gnu: gstreamer: Skip failing test on 32-bit systems Mark H Weaver
2019-06-16 8:00 ` Marius Bakke
2019-06-16 21:31 ` Mark H Weaver
2019-06-27 6:01 ` Mark H Weaver
2019-06-28 18:55 ` Marius Bakke
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).