From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: 01/01: gnu: gstreamer: Skip failing test on 32-bit systems. Date: Sun, 16 Jun 2019 10:00:41 +0200 Message-ID: <877e9m3qom.fsf@devup.no> References: <20190613121214.23499.29535@vcs0.savannah.gnu.org> <20190613121215.EBF7320949@vcs0.savannah.gnu.org> <87imt95qtc.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:54108) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcQ5m-00087b-4S for guix-devel@gnu.org; Sun, 16 Jun 2019 04:00:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcQ5k-0008Ty-Ua for guix-devel@gnu.org; Sun, 16 Jun 2019 04:00:46 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36515) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcQ5k-0008TP-L2 for guix-devel@gnu.org; Sun, 16 Jun 2019 04:00:44 -0400 In-Reply-To: <87imt95qtc.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mark, Mark H Weaver writes: > Hi Marius, > > guix-commits@gnu.org writes: > >> mbakke pushed a commit to branch staging >> in repository guix. >> >> commit 2a9d89afb6fb869dd2bdf1e9f710f487786930fc >> Author: Marius Bakke >> Date: Thu Jun 13 14:08:32 2019 +0200 >> >> gnu: gstreamer: Skip failing test on 32-bit systems. >>=20=20=20=20=20 >> * gnu/packages/gstreamer.scm (gstreamer)[arguments]: When building f= or a >> 32-bit system, add #:phases. > [...] >> + ,@(if (not (target-64bit?)) >> + ;; Skip test that fails on 32-bit systems: >> + ;; . >> + `(#:phases (modify-phases %standard-phases >> + (add-before 'check 'disable-gstbufferpool-test >> + (lambda _ >> + (substitute* "tests/check/Makefile" >> + (("^[[:blank:]]+gst/gstbufferpool.*$") >> + "")) >> + #t)))) >> + '()))) > > This might be sweeping a critical bug under the rug. Does > > Unexpected critical/warning: gst_buffer_resize_range: > assertion 'bufmax >=3D bufoffs + offset + size' failed > > really sound like something we can safely ignore? I think you are right to be concerned. I found the upstream commit that introduced the problem. See . Do you have a preference for reverting the faulty commits, or going back to 1.14.5? Thanks for noticing, Marius --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl0F9ykACgkQoqBt8qM6 VPppdggAlHwgR0OaAzmSE2FjZllU1howrgfCX/1iVmd877ofRaB21wifIaQSWaqc UqRJKrR3zoUU4OU9EU0oRg5zPFaUFMjJcuHRppO5iPFSgGbP6WqFUEnNmeP+vUdU xOHkFhhZUBLyuV+hemQBnXulPUVSWbB3pvxkHVTlv6Rm0xpJWB3z2vRcVXJ2np1Q +77Fu8Jv64mHS0kM2ErVqnRPILn62NnxitE2K5H7u9OJWTK6WnPWpPxFveWIRXSf 1PaG8P44RAcrY2Kfr6nf+s/BX3g3iFZM2gv4EuCYo+HtjJGSixPcgPNK2l9BiHCZ Mvu9cl8HWz8IefURh0Brf2JpBP9lHw== =ZPuG -----END PGP SIGNATURE----- --=-=-=--