From: Mark H Weaver <mhw@netris.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: gnu: gstreamer: Skip failing test on 32-bit systems.
Date: Thu, 13 Jun 2019 13:37:40 -0400 [thread overview]
Message-ID: <87imt95qtc.fsf@netris.org> (raw)
In-Reply-To: <20190613121215.EBF7320949@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Thu, 13 Jun 2019 08:12:15 -0400 (EDT)")
Hi Marius,
guix-commits@gnu.org writes:
> mbakke pushed a commit to branch staging
> in repository guix.
>
> commit 2a9d89afb6fb869dd2bdf1e9f710f487786930fc
> Author: Marius Bakke <mbakke@fastmail.com>
> Date: Thu Jun 13 14:08:32 2019 +0200
>
> gnu: gstreamer: Skip failing test on 32-bit systems.
>
> * gnu/packages/gstreamer.scm (gstreamer)[arguments]: When building for a
> 32-bit system, add #:phases.
[...]
> + ,@(if (not (target-64bit?))
> + ;; Skip test that fails on 32-bit systems:
> + ;; <https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316>.
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'check 'disable-gstbufferpool-test
> + (lambda _
> + (substitute* "tests/check/Makefile"
> + (("^[[:blank:]]+gst/gstbufferpool.*$")
> + ""))
> + #t))))
> + '())))
This might be sweeping a critical bug under the rug. Does
Unexpected critical/warning: gst_buffer_resize_range:
assertion 'bufmax >= bufoffs + offset + size' failed
really sound like something we can safely ignore?
Mark
next parent reply other threads:[~2019-06-13 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190613121214.23499.29535@vcs0.savannah.gnu.org>
[not found] ` <20190613121215.EBF7320949@vcs0.savannah.gnu.org>
2019-06-13 17:37 ` Mark H Weaver [this message]
2019-06-16 8:00 ` 01/01: gnu: gstreamer: Skip failing test on 32-bit systems Marius Bakke
2019-06-16 21:31 ` Mark H Weaver
2019-06-27 6:01 ` Mark H Weaver
2019-06-28 18:55 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imt95qtc.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).