From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: 01/01: gnu: gstreamer: Skip failing test on 32-bit systems. Date: Fri, 28 Jun 2019 20:55:46 +0200 Message-ID: <87zhm11qvh.fsf@devup.no> References: <20190613121214.23499.29535@vcs0.savannah.gnu.org> <20190613121215.EBF7320949@vcs0.savannah.gnu.org> <87imt95qtc.fsf@netris.org> <877e9m3qom.fsf@devup.no> <875zorr2gw.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:42096) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgw2N-0000CW-WE for guix-devel@gnu.org; Fri, 28 Jun 2019 14:55:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgw2L-0000Hv-Nn for guix-devel@gnu.org; Fri, 28 Jun 2019 14:55:55 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37391) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgw2J-0000ES-MP for guix-devel@gnu.org; Fri, 28 Jun 2019 14:55:52 -0400 In-Reply-To: <875zorr2gw.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mark H Weaver writes: > Marius Bakke writes: > >> Mark H Weaver writes: >> >>> Hi Marius, >>> >>> guix-commits@gnu.org writes: >>> >>>> mbakke pushed a commit to branch staging >>>> in repository guix. >>>> >>>> commit 2a9d89afb6fb869dd2bdf1e9f710f487786930fc >>>> Author: Marius Bakke >>>> Date: Thu Jun 13 14:08:32 2019 +0200 >>>> >>>> gnu: gstreamer: Skip failing test on 32-bit systems. >>>>=20=20=20=20=20 >>>> * gnu/packages/gstreamer.scm (gstreamer)[arguments]: When building= for a >>>> 32-bit system, add #:phases. >>> [...] >>>> + ,@(if (not (target-64bit?)) >>>> + ;; Skip test that fails on 32-bit systems: >>>> + ;; . >>>> + `(#:phases (modify-phases %standard-phases >>>> + (add-before 'check 'disable-gstbufferpool-test >>>> + (lambda _ >>>> + (substitute* "tests/check/Makefile" >>>> + (("^[[:blank:]]+gst/gstbufferpool.*$") >>>> + "")) >>>> + #t)))) >>>> + '()))) >>> >>> This might be sweeping a critical bug under the rug. Does >>> >>> Unexpected critical/warning: gst_buffer_resize_range: >>> assertion 'bufmax >=3D bufoffs + offset + size' failed >>> >>> really sound like something we can safely ignore? >> >> I think you are right to be concerned. I found the upstream commit that >> introduced the problem. See >> . > > *ping*? Sorry, I've been on holiday. Will get it sorted this weekend. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl0WYrIACgkQoqBt8qM6 VPpAZQf/SUP1qCCUpDdBMBaEAvXSvLfvXB4MWvEttRODzaFqwAr1ps2u1Ngg++hS L+14HPordUdRMiCtggFARd4BB7ZSTKyo6GRm2YtwHS+Z/Yd3J+gFzy5iuiR/PoNr ErA8ZqNJNtUIOsWDidRaPvisSZpcJ2/DpImU0z6XPrn9c0dBK4NhC4aBrhiPHtyQ lZWNl2UTgefUsilYYavo3djta7vexxyYJxmsPLBxKl7Amr28Dj0szJrbxAULVfLn IIxjG2U6xTL+AWkfRiUw+V2D9wt4bVEU8SH9ePYBjh7Bxu9DlJudQDnbkWU+fxoV QBLpT7K8oV/zYOEvTJyExcyKV0oh8A== =qzCB -----END PGP SIGNATURE----- --=-=-=--