From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: 01/01: gnu: gstreamer: Skip failing test on 32-bit systems.
Date: Thu, 13 Jun 2019 13:37:40 -0400
Message-ID: <87imt95qtc.fsf@netris.org>
References: <20190613121214.23499.29535@vcs0.savannah.gnu.org>
 <20190613121215.EBF7320949@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:41429)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <mhw@netris.org>) id 1hbThy-0006Xb-Fk
 for guix-devel@gnu.org; Thu, 13 Jun 2019 13:40:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mhw@netris.org>) id 1hbThu-0006x0-5B
 for guix-devel@gnu.org; Thu, 13 Jun 2019 13:40:18 -0400
Received: from world.peace.net ([64.112.178.59]:46254)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mhw@netris.org>) id 1hbTht-0006AM-Fu
 for guix-devel@gnu.org; Thu, 13 Jun 2019 13:40:13 -0400
In-Reply-To: <20190613121215.EBF7320949@vcs0.savannah.gnu.org>
 (guix-commits@gnu.org's message of "Thu, 13 Jun 2019 08:12:15 -0400
 (EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Hi Marius,

guix-commits@gnu.org writes:

> mbakke pushed a commit to branch staging
> in repository guix.
>
> commit 2a9d89afb6fb869dd2bdf1e9f710f487786930fc
> Author: Marius Bakke <mbakke@fastmail.com>
> Date:   Thu Jun 13 14:08:32 2019 +0200
>
>     gnu: gstreamer: Skip failing test on 32-bit systems.
>     
>     * gnu/packages/gstreamer.scm (gstreamer)[arguments]: When building for a
>     32-bit system, add #:phases.
[...]
> +       ,@(if (not (target-64bit?))
> +           ;; Skip test that fails on 32-bit systems:
> +           ;; <https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316>.
> +           `(#:phases (modify-phases %standard-phases
> +                        (add-before 'check 'disable-gstbufferpool-test
> +                          (lambda _
> +                            (substitute* "tests/check/Makefile"
> +                              (("^[[:blank:]]+gst/gstbufferpool.*$")
> +                               ""))
> +                              #t))))
> +           '())))

This might be sweeping a critical bug under the rug.  Does

  Unexpected critical/warning: gst_buffer_resize_range:
    assertion 'bufmax >= bufoffs + offset + size' failed

really sound like something we can safely ignore?

      Mark