Re: 01/01: gnu: gstreamer: Skip failing test on 32-bit systems.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]

Mark,

Mark H Weaver <mhw@netris.org> writes:

> Hi Marius,
>
> guix-commits@gnu.org writes:
>
>> mbakke pushed a commit to branch staging
>> in repository guix.
>>
>> commit 2a9d89afb6fb869dd2bdf1e9f710f487786930fc
>> Author: Marius Bakke <mbakke@fastmail.com>
>> Date:   Thu Jun 13 14:08:32 2019 +0200
>>
>>     gnu: gstreamer: Skip failing test on 32-bit systems.
>>     
>>     * gnu/packages/gstreamer.scm (gstreamer)[arguments]: When building for a
>>     32-bit system, add #:phases.
> [...]
>> +       ,@(if (not (target-64bit?))
>> +           ;; Skip test that fails on 32-bit systems:
>> +           ;; <https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316>.
>> +           `(#:phases (modify-phases %standard-phases
>> +                        (add-before 'check 'disable-gstbufferpool-test
>> +                          (lambda _
>> +                            (substitute* "tests/check/Makefile"
>> +                              (("^[[:blank:]]+gst/gstbufferpool.*$")
>> +                               ""))
>> +                              #t))))
>> +           '())))
>
> This might be sweeping a critical bug under the rug.  Does
>
>   Unexpected critical/warning: gst_buffer_resize_range:
>     assertion 'bufmax >= bufoffs + offset + size' failed
>
> really sound like something we can safely ignore?

I think you are right to be concerned.  I found the upstream commit that
introduced the problem.  See
<https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/316#note_176773>.

Do you have a preference for reverting the faulty commits, or going back
to 1.14.5?

Thanks for noticing,
Marius

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]