From: Juri Linkov <juri@linkov.net>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA?] Controlling Isearch from the minibuffer
Date: Tue, 25 May 2021 23:50:27 +0300 [thread overview]
Message-ID: <87wnrm35d8.fsf@mail.linkov.net> (raw)
In-Reply-To: <87eee65yor.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 16 May 2021 21:19:16 +0300")
>> Now, I took a closer look at the history of changes around lazy
>> highlight and the interactions with other features seems very tricky.
>> I'm not super confident about the patch I'm attaching, but if you are
>> willing to review it and test a bit, I hope it helps.
>
> Everything looks right, but this needs more testing before pushing.
Testing revealed some problems:
1. After enabling isearch-lazy-count, modes that use lazy-highligh,
such as e.g. query-replace displays the isearch message
overwriting query-replace prompt. Maybe this is because of the
removed check for 'isearch-mode' in isearch-lazy-highlight-* functions?
2. Using 'C-q' (isearch-quote-char) in the minibuffer or comint
displays a truncated string, e.g. on 'M-! C-r C-q C-a'.
Maybe the default message function should be called directly
in isearch-quote-char?
3. Maybe the same default message function should be called directly
also in some other functions like isearch-lazy-highlight-new-loop
and isearch-lazy-highlight-buffer-update?
next prev parent reply other threads:[~2021-05-25 20:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 10:13 [WIP PATCH] Controlling Isearch from the minibuffer Augusto Stoffel
2021-05-09 13:36 ` Alan Mackenzie
2021-05-09 17:58 ` Augusto Stoffel
2021-05-10 19:51 ` Alan Mackenzie
2021-05-11 9:00 ` Augusto Stoffel
2021-05-11 15:34 ` [External] : " Drew Adams
2021-05-11 18:31 ` Juri Linkov
2021-05-11 19:38 ` Drew Adams
2021-05-12 6:45 ` Augusto Stoffel
2021-05-12 12:44 ` Stefan Monnier
2021-05-12 15:31 ` Drew Adams
2021-05-12 22:17 ` Kévin Le Gouguec
2021-05-12 23:07 ` Drew Adams
2021-05-13 15:12 ` Kévin Le Gouguec
2021-05-12 21:09 ` Augusto Stoffel
2021-05-12 15:30 ` Drew Adams
2021-05-09 19:09 ` Juri Linkov
2021-05-09 19:05 ` Juri Linkov
2021-05-10 20:24 ` Augusto Stoffel
2021-05-10 21:17 ` Juri Linkov
2021-05-12 6:40 ` Augusto Stoffel
2021-05-12 17:13 ` Juri Linkov
2021-05-12 20:52 ` Augusto Stoffel
2021-05-13 16:31 ` Juri Linkov
2021-05-13 20:12 ` [ELPA?] " Augusto Stoffel
2021-05-14 1:17 ` Jean Louis
2021-05-14 8:36 ` Augusto Stoffel
2021-05-14 17:30 ` Augusto Stoffel
2021-05-14 18:20 ` Juri Linkov
2021-05-16 11:00 ` Augusto Stoffel
2021-05-16 18:19 ` Juri Linkov
2021-05-25 20:50 ` Juri Linkov [this message]
2021-05-29 11:48 ` Augusto Stoffel
2021-05-14 18:18 ` Juri Linkov
2021-05-16 18:12 ` Juri Linkov
2021-05-16 18:49 ` Augusto Stoffel
2021-05-21 9:09 ` Augusto Stoffel
2021-05-21 10:25 ` Eli Zaretskii
2021-05-21 11:56 ` Augusto Stoffel
2021-05-21 12:31 ` Eli Zaretskii
2021-05-21 12:49 ` Augusto Stoffel
2021-05-21 15:05 ` Stefan Monnier
2021-05-21 15:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnrm35d8.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=arstoffel@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).