Re: [ELPA?] Controlling Isearch from the minibuffer

[Augusto Stoffel <arstoffel@gmail.com>]

On Sun, 16 May 2021 at 21:12, Juri Linkov <juri@linkov.net> wrote:

>> I'm pretty convinced that the approach of my first patch
>> (`with-isearch-window' macro, etc.) is the right way to implement this
>> and possibly other future features.  On the other hand, I understand
>> that it would be premature to just change isearch.el in this direction
>> without a deeper reflection and further testing.
>
> Wrapping the bodies of all isearch commands in a macro `with-isearch-window'
> is much more intrusive change than handling commands in hooks
> after adding just one such line for every command:
>
>   (put 'isearch-repeat-forward 'isearch-from-minibuffer t)

I agree that the hook approach is less intrusive, but I after
implementing it I felt it was too hacky, and probably more brittle.

In the meanwhile Daniel Mendler made several helpful suggestions for the
package version of the feature, now I feel there's not much technical
reason to make the feature built into isearch.el (I would love the extra
visibility/availability, but that's not an argument for inclusion).  In
particular, this use case is different from an improved
`isearch-edit-string' in several small ways, which would hinder a lot of
code reuse.

How do I formalize the ELPA submission?  (There's a Github link a few
messages back.)